* "Pick the right alignment default when creating dax devices" failed to build on powerpc
@ 2019-09-20 14:03 Qian Cai
2019-09-20 14:25 ` Aneesh Kumar K.V
0 siblings, 1 reply; 6+ messages in thread
From: Qian Cai @ 2019-09-20 14:03 UTC (permalink / raw)
To: Aneesh Kumar K.V
Cc: Dan Williams, Michael Ellerman, linuxppc-dev, linux-kernel
The linux-next commit "libnvdimm/dax: Pick the right alignment default when
creating dax devices" causes powerpc failed to build with this config. Reverted
it fixed the issue.
ERROR: "hash__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
ERROR: "radix__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko]
undefined!
make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
make: *** [Makefile:1305: modules] Error 2
[1] https://patchwork.kernel.org/patch/11133445/
[2] https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc
2019-09-20 14:03 "Pick the right alignment default when creating dax devices" failed to build on powerpc Qian Cai
@ 2019-09-20 14:25 ` Aneesh Kumar K.V
2019-09-20 18:17 ` Qian Cai
0 siblings, 1 reply; 6+ messages in thread
From: Aneesh Kumar K.V @ 2019-09-20 14:25 UTC (permalink / raw)
To: Qian Cai; +Cc: Dan Williams, Michael Ellerman, linuxppc-dev, linux-kernel
Qian Cai <cai@lca.pw> writes:
> The linux-next commit "libnvdimm/dax: Pick the right alignment default when
> creating dax devices" causes powerpc failed to build with this config. Reverted
> it fixed the issue.
>
> ERROR: "hash__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
> ERROR: "radix__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko]
> undefined!
> make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
> make: *** [Makefile:1305: modules] Error 2
>
> [1] https://patchwork.kernel.org/patch/11133445/
> [2] https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
Sorry for breaking the build. How about?
commit ea15fd8b5489e2c8e9f1b96d67248a7428ffb74a
Author: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Date: Fri Sep 20 19:47:56 2019 +0530
powerpc/book3s/nvdimm: Fix build error with nvdimm kernel module
Fix the below comiple error.
ERROR: "hash__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
ERROR: "radix__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
diff --git a/arch/powerpc/include/asm/book3s/64/radix.h b/arch/powerpc/include/asm/book3s/64/radix.h
index e04a839cb5b9..65a6966f1de4 100644
--- a/arch/powerpc/include/asm/book3s/64/radix.h
+++ b/arch/powerpc/include/asm/book3s/64/radix.h
@@ -254,7 +254,13 @@ extern void radix__pgtable_trans_huge_deposit(struct mm_struct *mm, pmd_t *pmdp,
extern pgtable_t radix__pgtable_trans_huge_withdraw(struct mm_struct *mm, pmd_t *pmdp);
extern pmd_t radix__pmdp_huge_get_and_clear(struct mm_struct *mm,
unsigned long addr, pmd_t *pmdp);
-extern int radix__has_transparent_hugepage(void);
+static inline int radix__has_transparent_hugepage(void)
+{
+ /* For radix 2M at PMD level means thp */
+ if (mmu_psize_defs[MMU_PAGE_2M].shift == PMD_SHIFT)
+ return 1;
+ return 0;
+}
#endif
extern int __meminit radix__vmemmap_create_mapping(unsigned long start,
diff --git a/arch/powerpc/mm/book3s64/hash_pgtable.c b/arch/powerpc/mm/book3s64/hash_pgtable.c
index d1f390ac9cdb..64733b9cb20a 100644
--- a/arch/powerpc/mm/book3s64/hash_pgtable.c
+++ b/arch/powerpc/mm/book3s64/hash_pgtable.c
@@ -406,6 +406,8 @@ int hash__has_transparent_hugepage(void)
return 1;
}
+EXPORT_SYMBOL_GPL(hash__has_transparent_hugepage);
+
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
#ifdef CONFIG_STRICT_KERNEL_RWX
diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c
index b4ca9e95e678..dc7a38f0a45b 100644
--- a/arch/powerpc/mm/book3s64/radix_pgtable.c
+++ b/arch/powerpc/mm/book3s64/radix_pgtable.c
@@ -1057,13 +1057,6 @@ pmd_t radix__pmdp_huge_get_and_clear(struct mm_struct *mm,
return old_pmd;
}
-int radix__has_transparent_hugepage(void)
-{
- /* For radix 2M at PMD level means thp */
- if (mmu_psize_defs[MMU_PAGE_2M].shift == PMD_SHIFT)
- return 1;
- return 0;
-}
#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
void radix__ptep_set_access_flags(struct vm_area_struct *vma, pte_t *ptep,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc
2019-09-20 14:25 ` Aneesh Kumar K.V
@ 2019-09-20 18:17 ` Qian Cai
2019-09-20 18:31 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Qian Cai @ 2019-09-20 18:17 UTC (permalink / raw)
To: Aneesh Kumar K.V
Cc: Dan Williams, Michael Ellerman, linuxppc-dev, linux-kernel
On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote:
> Qian Cai <cai@lca.pw> writes:
>
> > The linux-next commit "libnvdimm/dax: Pick the right alignment default when
> > creating dax devices" causes powerpc failed to build with this config. Reverted
> > it fixed the issue.
> >
> > ERROR: "hash__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
> > ERROR: "radix__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko]
> > undefined!
> > make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
> > make: *** [Makefile:1305: modules] Error 2
> >
> > [1] https://patchwork.kernel.org/patch/11133445/
> > [2] https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>
> Sorry for breaking the build. How about?
It works fine.
>
> commit ea15fd8b5489e2c8e9f1b96d67248a7428ffb74a
> Author: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> Date: Fri Sep 20 19:47:56 2019 +0530
>
> powerpc/book3s/nvdimm: Fix build error with nvdimm kernel module
>
> Fix the below comiple error.
>
> ERROR: "hash__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
> ERROR: "radix__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>
> diff --git a/arch/powerpc/include/asm/book3s/64/radix.h b/arch/powerpc/include/asm/book3s/64/radix.h
> index e04a839cb5b9..65a6966f1de4 100644
> --- a/arch/powerpc/include/asm/book3s/64/radix.h
> +++ b/arch/powerpc/include/asm/book3s/64/radix.h
> @@ -254,7 +254,13 @@ extern void radix__pgtable_trans_huge_deposit(struct mm_struct *mm, pmd_t *pmdp,
> extern pgtable_t radix__pgtable_trans_huge_withdraw(struct mm_struct *mm, pmd_t *pmdp);
> extern pmd_t radix__pmdp_huge_get_and_clear(struct mm_struct *mm,
> unsigned long addr, pmd_t *pmdp);
> -extern int radix__has_transparent_hugepage(void);
> +static inline int radix__has_transparent_hugepage(void)
> +{
> + /* For radix 2M at PMD level means thp */
> + if (mmu_psize_defs[MMU_PAGE_2M].shift == PMD_SHIFT)
> + return 1;
> + return 0;
> +}
> #endif
>
> extern int __meminit radix__vmemmap_create_mapping(unsigned long start,
> diff --git a/arch/powerpc/mm/book3s64/hash_pgtable.c b/arch/powerpc/mm/book3s64/hash_pgtable.c
> index d1f390ac9cdb..64733b9cb20a 100644
> --- a/arch/powerpc/mm/book3s64/hash_pgtable.c
> +++ b/arch/powerpc/mm/book3s64/hash_pgtable.c
> @@ -406,6 +406,8 @@ int hash__has_transparent_hugepage(void)
>
> return 1;
> }
> +EXPORT_SYMBOL_GPL(hash__has_transparent_hugepage);
> +
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>
> #ifdef CONFIG_STRICT_KERNEL_RWX
> diff --git a/arch/powerpc/mm/book3s64/radix_pgtable.c b/arch/powerpc/mm/book3s64/radix_pgtable.c
> index b4ca9e95e678..dc7a38f0a45b 100644
> --- a/arch/powerpc/mm/book3s64/radix_pgtable.c
> +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c
> @@ -1057,13 +1057,6 @@ pmd_t radix__pmdp_huge_get_and_clear(struct mm_struct *mm,
> return old_pmd;
> }
>
> -int radix__has_transparent_hugepage(void)
> -{
> - /* For radix 2M at PMD level means thp */
> - if (mmu_psize_defs[MMU_PAGE_2M].shift == PMD_SHIFT)
> - return 1;
> - return 0;
> -}
> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
>
> void radix__ptep_set_access_flags(struct vm_area_struct *vma, pte_t *ptep,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc
2019-09-20 18:17 ` Qian Cai
@ 2019-09-20 18:31 ` Dan Williams
2019-09-22 12:03 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Dan Williams @ 2019-09-20 18:31 UTC (permalink / raw)
To: Qian Cai
Cc: Aneesh Kumar K.V, Michael Ellerman, linuxppc-dev,
Linux Kernel Mailing List
On Fri, Sep 20, 2019 at 11:18 AM Qian Cai <cai@lca.pw> wrote:
>
> On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote:
> > Qian Cai <cai@lca.pw> writes:
> >
> > > The linux-next commit "libnvdimm/dax: Pick the right alignment default when
> > > creating dax devices" causes powerpc failed to build with this config. Reverted
> > > it fixed the issue.
> > >
> > > ERROR: "hash__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko] undefined!
> > > ERROR: "radix__has_transparent_hugepage" [drivers/nvdimm/libnvdimm.ko]
> > > undefined!
> > > make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
> > > make: *** [Makefile:1305: modules] Error 2
> > >
> > > [1] https://patchwork.kernel.org/patch/11133445/
> > > [2] https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
> >
> > Sorry for breaking the build. How about?
>
> It works fine.
Thanks, but let's delay "libnvdimm/dax: Pick the right alignment
default when creating dax devices" until after -rc1 to allow Michael
time to ack/nak this new export.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc
2019-09-20 18:31 ` Dan Williams
@ 2019-09-22 12:03 ` Michael Ellerman
2019-09-23 21:27 ` Dan Williams
0 siblings, 1 reply; 6+ messages in thread
From: Michael Ellerman @ 2019-09-22 12:03 UTC (permalink / raw)
To: Dan Williams, Qian Cai
Cc: Aneesh Kumar K.V, Michael Ellerman, linuxppc-dev,
Linux Kernel Mailing List
On 21 September 2019 4:31:16 am AEST, Dan Williams <dan.j.williams@intel.com> wrote:
>On Fri, Sep 20, 2019 at 11:18 AM Qian Cai <cai@lca.pw> wrote:
>>
>> On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote:
>> > Qian Cai <cai@lca.pw> writes:
>> >
>> > > The linux-next commit "libnvdimm/dax: Pick the right alignment
>default when
>> > > creating dax devices" causes powerpc failed to build with this
>config. Reverted
>> > > it fixed the issue.
>> > >
>> > > ERROR: "hash__has_transparent_hugepage"
>[drivers/nvdimm/libnvdimm.ko] undefined!
>> > > ERROR: "radix__has_transparent_hugepage"
>[drivers/nvdimm/libnvdimm.ko]
>> > > undefined!
>> > > make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
>> > > make: *** [Makefile:1305: modules] Error 2
>> > >
>> > > [1] https://patchwork.kernel.org/patch/11133445/
>> > > [2]
>https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
>> >
>> > Sorry for breaking the build. How about?
>>
>> It works fine.
>
>Thanks, but let's delay "libnvdimm/dax: Pick the right alignment
>default when creating dax devices" until after -rc1 to allow Michael
>time to ack/nak this new export.
Thanks Dan. It looks fine to me:
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: "Pick the right alignment default when creating dax devices" failed to build on powerpc
2019-09-22 12:03 ` Michael Ellerman
@ 2019-09-23 21:27 ` Dan Williams
0 siblings, 0 replies; 6+ messages in thread
From: Dan Williams @ 2019-09-23 21:27 UTC (permalink / raw)
To: Michael Ellerman
Cc: Qian Cai, Aneesh Kumar K.V, Michael Ellerman, linuxppc-dev,
Linux Kernel Mailing List
On Sun, Sep 22, 2019 at 5:04 AM Michael Ellerman <michael@ellerman.id.au> wrote:
>
>
>
> On 21 September 2019 4:31:16 am AEST, Dan Williams <dan.j.williams@intel.com> wrote:
> >On Fri, Sep 20, 2019 at 11:18 AM Qian Cai <cai@lca.pw> wrote:
> >>
> >> On Fri, 2019-09-20 at 19:55 +0530, Aneesh Kumar K.V wrote:
> >> > Qian Cai <cai@lca.pw> writes:
> >> >
> >> > > The linux-next commit "libnvdimm/dax: Pick the right alignment
> >default when
> >> > > creating dax devices" causes powerpc failed to build with this
> >config. Reverted
> >> > > it fixed the issue.
> >> > >
> >> > > ERROR: "hash__has_transparent_hugepage"
> >[drivers/nvdimm/libnvdimm.ko] undefined!
> >> > > ERROR: "radix__has_transparent_hugepage"
> >[drivers/nvdimm/libnvdimm.ko]
> >> > > undefined!
> >> > > make[1]: *** [scripts/Makefile.modpost:93: __modpost] Error 1
> >> > > make: *** [Makefile:1305: modules] Error 2
> >> > >
> >> > > [1] https://patchwork.kernel.org/patch/11133445/
> >> > > [2]
> >https://raw.githubusercontent.com/cailca/linux-mm/master/powerpc.config
> >> >
> >> > Sorry for breaking the build. How about?
> >>
> >> It works fine.
> >
> >Thanks, but let's delay "libnvdimm/dax: Pick the right alignment
> >default when creating dax devices" until after -rc1 to allow Michael
> >time to ack/nak this new export.
>
> Thanks Dan. It looks fine to me:
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Thanks Michael. Aneesh, care to resend with this ack, but also reword
the changelog to say that this patch is a pre-requisite for the follow
on patch to pick dax device alignment? In other words, lets hide this
compile breakage from git-bisect by merging this export before the
consumer patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-23 21:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 14:03 "Pick the right alignment default when creating dax devices" failed to build on powerpc Qian Cai
2019-09-20 14:25 ` Aneesh Kumar K.V
2019-09-20 18:17 ` Qian Cai
2019-09-20 18:31 ` Dan Williams
2019-09-22 12:03 ` Michael Ellerman
2019-09-23 21:27 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).