* [PATCH linux-next] device-dax: fix BLOCK dependency
@ 2017-05-13 18:59 Fabian Frederick
2017-05-13 23:21 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2017-05-13 18:59 UTC (permalink / raw)
To: Dan Williams
Cc: Johannes Thumshirn, Arnd Bergmann, linux-kernel, Fabian Frederick
commit ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")
uses get_start_sect() which requires CONFIG_BLOCK
make allnoconfig + dax gives the following:
drivers/dax/super.c: In function 'bdev_dax_pgoff':
drivers/dax/super.c:50:26: error: implicit declaration of function
'get_start_sect' [-Werror=implicit-function-declaration]
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/dax/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
index b79aa8f..1806628 100644
--- a/drivers/dax/Kconfig
+++ b/drivers/dax/Kconfig
@@ -1,5 +1,6 @@
menuconfig DAX
tristate "DAX: direct access to differentiated memory"
+ depends on BLOCK
select SRCU
default m if NVDIMM_DAX
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] device-dax: fix BLOCK dependency
2017-05-13 18:59 [PATCH linux-next] device-dax: fix BLOCK dependency Fabian Frederick
@ 2017-05-13 23:21 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2017-05-13 23:21 UTC (permalink / raw)
To: Fabian Frederick; +Cc: Johannes Thumshirn, Arnd Bergmann, linux-kernel
On Sat, May 13, 2017 at 11:59 AM, Fabian Frederick <fabf@skynet.be> wrote:
> commit ef51042472f5 ("block, dax: move "select DAX" from BLOCK to FS_DAX")
> uses get_start_sect() which requires CONFIG_BLOCK
>
> make allnoconfig + dax gives the following:
>
> drivers/dax/super.c: In function 'bdev_dax_pgoff':
> drivers/dax/super.c:50:26: error: implicit declaration of function
> 'get_start_sect' [-Werror=implicit-function-declaration]
>
Ah, sorry for this breakage, I guess this is a config that kbuild does
not attempt. I'll fix this up by not compiling the block-related
helpers in the BLOCK=n case.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-13 23:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-13 18:59 [PATCH linux-next] device-dax: fix BLOCK dependency Fabian Frederick
2017-05-13 23:21 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).