* [PATCH] ACPI: nfit: constify *_attribute_group.
@ 2017-06-22 10:14 Arvind Yadav
2017-06-28 4:42 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-06-22 10:14 UTC (permalink / raw)
To: rjw, lenb, dan.j.williams; +Cc: linux-acpi, linux-kernel
File size before:
text data bss dec hex filename
20792 1580 994 23366 5b46 drivers/acpi/nfit/core.o
File size After adding 'const':
text data bss dec hex filename
20968 1388 994 23350 5b36 drivers/acpi/nfit/core.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/acpi/nfit/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 656acb5..1871bec 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1066,7 +1066,7 @@ static umode_t nfit_visible(struct kobject *kobj, struct attribute *a, int n)
NULL,
};
-static struct attribute_group acpi_nfit_attribute_group = {
+static const struct attribute_group acpi_nfit_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_attributes,
.is_visible = nfit_visible,
@@ -1346,7 +1346,7 @@ static umode_t acpi_nfit_dimm_attr_visible(struct kobject *kobj,
return a->mode;
}
-static struct attribute_group acpi_nfit_dimm_attribute_group = {
+static const struct attribute_group acpi_nfit_dimm_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_dimm_attributes,
.is_visible = acpi_nfit_dimm_attr_visible,
@@ -1640,7 +1640,7 @@ static ssize_t range_index_show(struct device *dev,
NULL,
};
-static struct attribute_group acpi_nfit_region_attribute_group = {
+static const struct attribute_group acpi_nfit_region_attribute_group = {
.name = "nfit",
.attrs = acpi_nfit_region_attributes,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: nfit: constify *_attribute_group.
2017-06-22 10:14 [PATCH] ACPI: nfit: constify *_attribute_group Arvind Yadav
@ 2017-06-28 4:42 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2017-06-28 4:42 UTC (permalink / raw)
To: Arvind Yadav; +Cc: Rafael J. Wysocki, Len Brown, Linux ACPI, linux-kernel
On Thu, Jun 22, 2017 at 3:14 AM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> File size before:
> text data bss dec hex filename
> 20792 1580 994 23366 5b46 drivers/acpi/nfit/core.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 20968 1388 994 23350 5b36 drivers/acpi/nfit/core.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/acpi/nfit/core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Looks good to me, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-28 4:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-22 10:14 [PATCH] ACPI: nfit: constify *_attribute_group Arvind Yadav
2017-06-28 4:42 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).