* [v2 PATCH] mm: dax: add comment for PFN_SPECIAL
@ 2018-09-27 22:15 Yang Shi
2018-09-27 22:37 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Yang Shi @ 2018-09-27 22:15 UTC (permalink / raw)
To: dan.j.williams, akpm; +Cc: yang.shi, linux-mm, linux-kernel
The comment for PFN_SPECIAL is missed in pfn_t.h. Add comment to get
consistent with other pfn flags.
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
---
v2: rephrase the comment per Dan
include/linux/pfn_t.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h
index 21713dc..d6cc4b5 100644
--- a/include/linux/pfn_t.h
+++ b/include/linux/pfn_t.h
@@ -9,6 +9,8 @@
* PFN_SG_LAST - pfn references a page and is the last scatterlist entry
* PFN_DEV - pfn is not covered by system memmap by default
* PFN_MAP - pfn has a dynamic page mapping established by a device driver
+ * PFN_SPECIAL - for CONFIG_FS_DAX_LIMITED builds to allow XIP, but not
+ * get_user_pages
*/
#define PFN_FLAGS_MASK (((u64) ~PAGE_MASK) << (BITS_PER_LONG_LONG - PAGE_SHIFT))
#define PFN_SG_CHAIN (1ULL << (BITS_PER_LONG_LONG - 1))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [v2 PATCH] mm: dax: add comment for PFN_SPECIAL
2018-09-27 22:15 [v2 PATCH] mm: dax: add comment for PFN_SPECIAL Yang Shi
@ 2018-09-27 22:37 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2018-09-27 22:37 UTC (permalink / raw)
To: yang.shi; +Cc: Andrew Morton, Linux MM, Linux Kernel Mailing List
On Thu, Sep 27, 2018 at 3:17 PM <yang.shi@linux.alibaba.com> wrote:
>
> The comment for PFN_SPECIAL is missed in pfn_t.h. Add comment to get
> consistent with other pfn flags.
>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
> ---
> v2: rephrase the comment per Dan
Looks good for the -mm tree.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> include/linux/pfn_t.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/pfn_t.h b/include/linux/pfn_t.h
> index 21713dc..d6cc4b5 100644
> --- a/include/linux/pfn_t.h
> +++ b/include/linux/pfn_t.h
> @@ -9,6 +9,8 @@
> * PFN_SG_LAST - pfn references a page and is the last scatterlist entry
> * PFN_DEV - pfn is not covered by system memmap by default
> * PFN_MAP - pfn has a dynamic page mapping established by a device driver
> + * PFN_SPECIAL - for CONFIG_FS_DAX_LIMITED builds to allow XIP, but not
> + * get_user_pages
> */
> #define PFN_FLAGS_MASK (((u64) ~PAGE_MASK) << (BITS_PER_LONG_LONG - PAGE_SHIFT))
> #define PFN_SG_CHAIN (1ULL << (BITS_PER_LONG_LONG - 1))
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-27 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 22:15 [v2 PATCH] mm: dax: add comment for PFN_SPECIAL Yang Shi
2018-09-27 22:37 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).