* [PATCH] cciss: remove useless set memory to zero use memset()
@ 2012-08-27 7:06 Wei Yongjun
0 siblings, 0 replies; only message in thread
From: Wei Yongjun @ 2012-08-27 7:06 UTC (permalink / raw)
To: mike.miller; +Cc: yongjun_wei, iss_storagedev, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The memory return by kzalloc() or kmem_cache_zalloc() has already
be set to zero, so remove useless memset(0).
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/block/cciss.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index b0f553b..ca83f96 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -5205,7 +5205,6 @@ static void cciss_shutdown(struct pci_dev *pdev)
return;
}
/* write all data in the battery backed cache to disk */
- memset(flush_buf, 0, 4);
return_code = sendcmd_withirq(h, CCISS_CACHE_FLUSH, flush_buf,
4, 0, CTLR_LUNID, TYPE_CMD);
kfree(flush_buf);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-08-27 7:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-27 7:06 [PATCH] cciss: remove useless set memory to zero use memset() Wei Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).