* [PATCH] pch_dma: fix error return code in pch_dma_probe()
@ 2013-07-17 0:34 Wei Yongjun
2013-07-22 9:24 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-07-17 0:34 UTC (permalink / raw)
To: vinod.koul, djbw; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -ENODEV when no proper base address found error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/dma/pch_dma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index 237f1d5..956314d 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -860,6 +860,7 @@ static int pch_dma_probe(struct pci_dev *pdev,
if (!(pci_resource_flags(pdev, 1) & IORESOURCE_MEM)) {
dev_err(&pdev->dev, "Cannot find proper base address\n");
+ err = -ENODEV;
goto err_disable_pdev;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pch_dma: fix error return code in pch_dma_probe()
2013-07-17 0:34 [PATCH] pch_dma: fix error return code in pch_dma_probe() Wei Yongjun
@ 2013-07-22 9:24 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2013-07-22 9:24 UTC (permalink / raw)
To: Wei Yongjun; +Cc: djbw, yongjun_wei, linux-kernel
On Wed, Jul 17, 2013 at 08:34:59AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENODEV when no proper base address found error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-22 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-17 0:34 [PATCH] pch_dma: fix error return code in pch_dma_probe() Wei Yongjun
2013-07-22 9:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).