* [PATCH -next] rsxx: fix error return code in rsxx_pci_probe()
@ 2013-06-21 2:46 Wei Yongjun
2013-06-21 14:05 ` Philip J. Kelleher
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-06-21 2:46 UTC (permalink / raw)
To: josh.h.morris, axboe, pjk1939; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return -ENOMEM in the create_singlethread_workqueue() error handling
case instead of 0, as done elsewhere in this function.
Introduced by commit a3299ab18591d36ad5622f5064619123c439b779.
(rsxx: Individual workqueues for interruptible events.)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/block/rsxx/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index 6e85e21..11eb897 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx/core.c
@@ -946,6 +946,7 @@ static int rsxx_pci_probe(struct pci_dev *dev,
card->event_wq = create_singlethread_workqueue(DRIVER_NAME"_event");
if (!card->event_wq) {
dev_err(CARD_TO_DEV(card), "Failed card event setup.\n");
+ st = -ENOMEM;
goto failed_event_handler;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rsxx: fix error return code in rsxx_pci_probe()
2013-06-21 2:46 [PATCH -next] rsxx: fix error return code in rsxx_pci_probe() Wei Yongjun
@ 2013-06-21 14:05 ` Philip J. Kelleher
0 siblings, 0 replies; 2+ messages in thread
From: Philip J. Kelleher @ 2013-06-21 14:05 UTC (permalink / raw)
To: Wei Yongjun; +Cc: josh.h.morris, axboe, yongjun_wei, linux-kernel
On Fri, Jun 21, 2013 at 10:46:38AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -ENOMEM in the create_singlethread_workqueue() error handling
> case instead of 0, as done elsewhere in this function.
>
> Introduced by commit a3299ab18591d36ad5622f5064619123c439b779.
> (rsxx: Individual workqueues for interruptible events.)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/block/rsxx/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
> index 6e85e21..11eb897 100644
> --- a/drivers/block/rsxx/core.c
> +++ b/drivers/block/rsxx/core.c
> @@ -946,6 +946,7 @@ static int rsxx_pci_probe(struct pci_dev *dev,
> card->event_wq = create_singlethread_workqueue(DRIVER_NAME"_event");
> if (!card->event_wq) {
> dev_err(CARD_TO_DEV(card), "Failed card event setup.\n");
> + st = -ENOMEM;
> goto failed_event_handler;
> }
Thank You for fixing that.
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-21 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-21 2:46 [PATCH -next] rsxx: fix error return code in rsxx_pci_probe() Wei Yongjun
2013-06-21 14:05 ` Philip J. Kelleher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).