linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ARM: at91: remove unused variable in at91_dt_node_to_map()
@ 2012-10-26 14:54 Wei Yongjun
  2012-10-28 19:33 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-10-26 14:54 UTC (permalink / raw)
  To: linus.walleij, grant.likely, rob.herring
  Cc: yongjun_wei, linux-kernel, devicetree-discuss

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

The variable pin is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/pinctrl/pinctrl-at91.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 01bf924..19b57bb 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -221,7 +221,6 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev,
 	struct device_node *parent;
 	int map_num = 1;
 	int i;
-	struct at91_pmx_pin *pin;
 
 	/*
 	 * first find the group of this node and check if we need create
@@ -256,8 +255,6 @@ static int at91_dt_node_to_map(struct pinctrl_dev *pctldev,
 	/* create config map */
 	new_map++;
 	for (i = 0; i < grp->npins; i++) {
-		pin = &grp->pins_conf[i];
-
 		new_map[i].type = PIN_MAP_TYPE_CONFIGS_PIN;
 		new_map[i].data.configs.group_or_pin =
 				pin_get_name(pctldev, grp->pins[i]);


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] ARM: at91: remove unused variable in at91_dt_node_to_map()
  2012-10-26 14:54 [PATCH -next] ARM: at91: remove unused variable in at91_dt_node_to_map() Wei Yongjun
@ 2012-10-28 19:33 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2012-10-28 19:33 UTC (permalink / raw)
  To: Wei Yongjun, Jean-Christophe PLAGNIOL-VILLARD
  Cc: grant.likely, rob.herring, yongjun_wei, linux-kernel, devicetree-discuss

On Fri, Oct 26, 2012 at 4:54 PM, Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable pin is initialized but never used
> otherwise, so remove the unused variable.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks, patch applied to my AT91 branch.

BTW I will change the subject from ARM: AT91 to pinctrl/at91 on
all of them.

Of future mailings please include Mr. Jean-Christophe Plaiginol-Villard
on patches to the AT91 pinctrl driver.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-28 19:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-26 14:54 [PATCH -next] ARM: at91: remove unused variable in at91_dt_node_to_map() Wei Yongjun
2012-10-28 19:33 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).