* [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail
@ 2012-09-05 7:09 Wei Yongjun
2012-09-05 12:38 ` [Drbd-dev] " Philipp Reisner
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-05 7:09 UTC (permalink / raw)
To: drbd-dev; +Cc: yongjun_wei, drbd-user, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/block/drbd/drbd_worker.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/block/drbd/drbd_worker.c b/drivers/block/drbd/drbd_worker.c
index 6bce2cc..a196281 100644
--- a/drivers/block/drbd/drbd_worker.c
+++ b/drivers/block/drbd/drbd_worker.c
@@ -141,8 +141,7 @@ static void drbd_endio_write_sec_final(struct drbd_epoch_entry *e) __releases(lo
spin_lock_irqsave(&mdev->req_lock, flags);
mdev->writ_cnt += e->size >> 9;
- list_del(&e->w.list); /* has been on active_ee or sync_ee */
- list_add_tail(&e->w.list, &mdev->done_ee);
+ list_move_tail(&e->w.list, &mdev->done_ee);
/* No hlist_del_init(&e->collision) here, we did not send the Ack yet,
* neither did we wake possibly waiting conflicting requests.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Drbd-dev] [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail
2012-09-05 7:09 [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail Wei Yongjun
@ 2012-09-05 12:38 ` Philipp Reisner
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Reisner @ 2012-09-05 12:38 UTC (permalink / raw)
To: Wei Yongjun; +Cc: drbd-dev, yongjun_wei, linux-kernel, drbd-user
Thanks, applied.
Best regards,
Phil
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/block/drbd/drbd_worker.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/drbd/drbd_worker.c
> b/drivers/block/drbd/drbd_worker.c index 6bce2cc..a196281 100644
> --- a/drivers/block/drbd/drbd_worker.c
> +++ b/drivers/block/drbd/drbd_worker.c
> @@ -141,8 +141,7 @@ static void drbd_endio_write_sec_final(struct
> drbd_epoch_entry *e) __releases(lo
>
> spin_lock_irqsave(&mdev->req_lock, flags);
> mdev->writ_cnt += e->size >> 9;
> - list_del(&e->w.list); /* has been on active_ee or sync_ee */
> - list_add_tail(&e->w.list, &mdev->done_ee);
> + list_move_tail(&e->w.list, &mdev->done_ee);
>
> /* No hlist_del_init(&e->collision) here, we did not send the Ack yet,
> * neither did we wake possibly waiting conflicting requests.
>
>
> _______________________________________________
> drbd-dev mailing list
> drbd-dev@lists.linbit.com
> http://lists.linbit.com/mailman/listinfo/drbd-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-05 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-05 7:09 [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail Wei Yongjun
2012-09-05 12:38 ` [Drbd-dev] " Philipp Reisner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).