* [PATCH] net/ipv4/tcp_bpf: Delete an unnecessary check before the function call “consume_skb”
@ 2019-08-22 16:32 Markus Elfring
2019-08-22 21:12 ` Song Liu
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-08-22 16:32 UTC (permalink / raw)
To: netdev, bpf, Alexei Starovoitov, Alexey Kuznetsov,
Daniel Borkmann, David S. Miller, Eric Dumazet,
Hideaki Yoshifuji, John Fastabend, Martin KaFai Lau, Song Liu,
Yonghong Song
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 22 Aug 2019 18:20:42 +0200
The consume_skb() function performs also input parameter validation.
Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
net/ipv4/tcp_bpf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/tcp_bpf.c b/net/ipv4/tcp_bpf.c
index 8a56e09cfb0e..4ae18bd431a0 100644
--- a/net/ipv4/tcp_bpf.c
+++ b/net/ipv4/tcp_bpf.c
@@ -103,8 +103,7 @@ int __tcp_bpf_recvmsg(struct sock *sk, struct sk_psock *psock,
msg_rx->sg.start = i;
if (!sge->length && msg_rx->sg.start == msg_rx->sg.end) {
list_del(&msg_rx->list);
- if (msg_rx->skb)
- consume_skb(msg_rx->skb);
+ consume_skb(msg_rx->skb);
kfree(msg_rx);
}
msg_rx = list_first_entry_or_null(&psock->ingress_msg,
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/ipv4/tcp_bpf: Delete an unnecessary check before the function call “consume_skb”
2019-08-22 16:32 [PATCH] net/ipv4/tcp_bpf: Delete an unnecessary check before the function call “consume_skb” Markus Elfring
@ 2019-08-22 21:12 ` Song Liu
0 siblings, 0 replies; 2+ messages in thread
From: Song Liu @ 2019-08-22 21:12 UTC (permalink / raw)
To: Markus Elfring
Cc: Networking, bpf, Alexei Starovoitov, Alexey Kuznetsov,
Daniel Borkmann, David S. Miller, Eric Dumazet,
Hideaki Yoshifuji, John Fastabend, Martin KaFai Lau, Song Liu,
Yonghong Song, LKML, kernel-janitors
On Thu, Aug 22, 2019 at 10:19 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 22 Aug 2019 18:20:42 +0200
>
> The consume_skb() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Song Liu <songliubraving@fb.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-22 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 16:32 [PATCH] net/ipv4/tcp_bpf: Delete an unnecessary check before the function call “consume_skb” Markus Elfring
2019-08-22 21:12 ` Song Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).