linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script
@ 2018-06-22 20:00 Jeffrin Jose T
  2018-06-25  5:09 ` Song Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Jeffrin Jose T @ 2018-06-22 20:00 UTC (permalink / raw)
  To: ast, daniel, shuah; +Cc: netdev, linux-kernel, linux-kselftest, Jeffrin Jose T

This test_lwt_seg6local.sh will execute with root privilege.

This patch is atleast used to notify the user about the privilege
required related to smooth execution of the script.

Signed-off-by: Jeffrin Jose T (Rajagiri SET) <ahiliation@gmail.com>
---
 tools/testing/selftests/bpf/test_lwt_seg6local.sh | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/testing/selftests/bpf/test_lwt_seg6local.sh b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
index 1c77994b5e71..30575577a8b2 100755
--- a/tools/testing/selftests/bpf/test_lwt_seg6local.sh
+++ b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
@@ -21,6 +21,15 @@
 # An UDP datagram is sent from fb00::1 to fb00::6. The test succeeds if this
 # datagram can be read on NS6 when binding to fb00::6.
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+msg="skip all tests:"
+if [ $UID != 0 ]; then
+    echo $msg please run this as root >&2
+    exit $ksft_skip
+fi
+
 TMP_FILE="/tmp/selftest_lwt_seg6local.txt"
 
 cleanup()
-- 
2.17.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script
  2018-06-22 20:00 [PATCH] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script Jeffrin Jose T
@ 2018-06-25  5:09 ` Song Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Song Liu @ 2018-06-25  5:09 UTC (permalink / raw)
  To: Jeffrin Jose T
  Cc: Alexei Starovoitov, Daniel Borkmann, shuah, Networking,
	open list, linux-kselftest

On Fri, Jun 22, 2018 at 1:00 PM, Jeffrin Jose T <ahiliation@gmail.com> wrote:
> This test_lwt_seg6local.sh will execute with root privilege.
>
> This patch is atleast used to notify the user about the privilege
> required related to smooth execution of the script.
>
> Signed-off-by: Jeffrin Jose T (Rajagiri SET) <ahiliation@gmail.com>

Acked-by: Song Liu <songliubraving@fb.com>

> ---
>  tools/testing/selftests/bpf/test_lwt_seg6local.sh | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/test_lwt_seg6local.sh b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
> index 1c77994b5e71..30575577a8b2 100755
> --- a/tools/testing/selftests/bpf/test_lwt_seg6local.sh
> +++ b/tools/testing/selftests/bpf/test_lwt_seg6local.sh
> @@ -21,6 +21,15 @@
>  # An UDP datagram is sent from fb00::1 to fb00::6. The test succeeds if this
>  # datagram can be read on NS6 when binding to fb00::6.
>
> +# Kselftest framework requirement - SKIP code is 4.
> +ksft_skip=4
> +
> +msg="skip all tests:"
> +if [ $UID != 0 ]; then
> +    echo $msg please run this as root >&2
> +    exit $ksft_skip
> +fi
> +
>  TMP_FILE="/tmp/selftest_lwt_seg6local.txt"
>
>  cleanup()
> --
> 2.17.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-25  5:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-22 20:00 [PATCH] selftests: bpf: notification about privilege required to run test_lwt_seg6local.sh testing script Jeffrin Jose T
2018-06-25  5:09 ` Song Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).