From: Song Liu <song@kernel.org>
To: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: Jia He <justin.he@arm.com>,
open list <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
nd@arm.com, linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier
Date: Fri, 23 Jul 2021 10:05:14 -0700 [thread overview]
Message-ID: <CAPhsuW7C5kjnutW1rdkg7jENsrg8k47_+R24G7RZRrM07s2Ymw@mail.gmail.com> (raw)
In-Reply-To: <51d24b1a-7146-bacd-87ee-4be487c455d8@linux.dev>
On Fri, Jul 16, 2021 at 2:41 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
>
>
>
> On 7/15/21 11:15 AM, Jia He wrote:
> > After the behavior of '%pD' is changed to print the full path of file,
> > the log printing can be simplified.
> >
> > Given the space with proper length would be allocated in vprintk_store(),
> > it is worthy of dropping kmalloc()/kfree() to avoid additional space
> > allocation. The error case is well handled in d_path_unsafe(), the error
> > string would be copied in '%pD' buffer, no need to additionally handle
> > IS_ERR().
> >
> > Cc: Song Liu <song@kernel.org>
> > Cc: linux-raid@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Jia He <justin.he@arm.com>
> > ---
> > drivers/md/md-bitmap.c | 13 ++-----------
> > 1 file changed, 2 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c
> > index e29c6298ef5c..a82f1c2ef83c 100644
> > --- a/drivers/md/md-bitmap.c
> > +++ b/drivers/md/md-bitmap.c
> > @@ -862,21 +862,12 @@ static void md_bitmap_file_unmap(struct bitmap_storage *store)
> > */
> > static void md_bitmap_file_kick(struct bitmap *bitmap)
> > {
> > - char *path, *ptr = NULL;
> > -
> > if (!test_and_set_bit(BITMAP_STALE, &bitmap->flags)) {
> > md_bitmap_update_sb(bitmap);
> >
> > if (bitmap->storage.file) {
> > - path = kmalloc(PAGE_SIZE, GFP_KERNEL);
> > - if (path)
> > - ptr = file_path(bitmap->storage.file,
> > - path, PAGE_SIZE);
> > -
> > - pr_warn("%s: kicking failed bitmap file %s from array!\n",
> > - bmname(bitmap), IS_ERR(ptr) ? "" : ptr);
> > -
> > - kfree(path);
> > + pr_warn("%s: kicking failed bitmap file %pD from array!\n",
> > + bmname(bitmap), bitmap->storage.file);
This is neat!
Acked-by: Song Liu <song@kernel.org>
> > } else
> > pr_warn("%s: disabling internal bitmap due to errors\n",
> > bmname(bitmap));
>
> Looks good, Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev>
next prev parent reply other threads:[~2021-07-23 17:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 3:15 [PATCH RFC 00/13] Simplify the print format string with new '%pD' Jia He
2021-07-15 3:15 ` [PATCH RFC 01/13] s390/hmcdrv: remove the redundant directory path in format string Jia He
2021-07-15 3:15 ` [PATCH RFC 02/13] afs: Remove the number postfix of '%pD' " Jia He
2021-07-15 3:15 ` [PATCH RFC 03/13] fs: " Jia He
2021-07-15 3:15 ` [PATCH RFC 04/13] NFS: " Jia He
2021-07-15 3:15 ` [PATCH RFC 05/13] NFSD: " Jia He
2021-07-15 3:15 ` [PATCH RFC 06/13] ovl: remove " Jia He
2021-07-15 3:15 ` [PATCH RFC 07/13] iomap: simplify iomap_swapfile_fail() with '%pD' specifier Jia He
2021-07-15 17:11 ` Darrick J. Wong
2021-07-16 6:11 ` Christoph Hellwig
2021-07-16 6:17 ` Justin He
2021-07-15 3:15 ` [PATCH RFC 08/13] fs/coredump: simplify the printing with '%pD' and '%pd' specifier Jia He
2021-07-15 3:15 ` [PATCH RFC 09/13] mm/filemap: simplify the printing with '%pD' specifier Jia He
2021-07-15 3:15 ` [PATCH RFC 10/13] usb: gadget: " Jia He
2021-07-15 7:26 ` Felipe Balbi
2021-07-15 8:10 ` Greg Kroah-Hartman
2021-07-15 3:15 ` [PATCH RFC 11/13] md/bitmap: " Jia He
2021-07-16 9:38 ` Guoqing Jiang
2021-07-23 17:05 ` Song Liu [this message]
2021-07-15 3:15 ` [PATCH RFC 12/13] mm: simplify the printing with '%pd' specifier Jia He
2021-07-15 3:15 ` [PATCH RFC 13/13] ext4: simplify the printing with '%pD' specifier Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPhsuW7C5kjnutW1rdkg7jENsrg8k47_+R24G7RZRrM07s2Ymw@mail.gmail.com \
--to=song@kernel.org \
--cc=guoqing.jiang@linux.dev \
--cc=hch@infradead.org \
--cc=justin.he@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=nd@arm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).