* [PATCH] sgi-xpc: mark expected switch fall-through
@ 2019-03-20 16:03 Gustavo A. R. Silva
2019-03-20 16:05 ` Robin Holt
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 16:03 UTC (permalink / raw)
To: Cliff Whickman, Robin Holt, Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/misc/sgi-xp/xpc_uv.c: In function ‘xpc_handle_activate_mq_msg_uv’:
drivers/misc/sgi-xp/xpc_uv.c:573:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
xpc_wakeup_channel_mgr(part);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/misc/sgi-xp/xpc_uv.c:575:2: note: here
case XPC_ACTIVATE_MQ_MSG_MARK_ENGAGED_UV:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/misc/sgi-xp/xpc_uv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
index 9e443df44b3b..0c6de97dd347 100644
--- a/drivers/misc/sgi-xp/xpc_uv.c
+++ b/drivers/misc/sgi-xp/xpc_uv.c
@@ -572,6 +572,7 @@ xpc_handle_activate_mq_msg_uv(struct xpc_partition *part,
xpc_wakeup_channel_mgr(part);
}
+ /* fall through */
case XPC_ACTIVATE_MQ_MSG_MARK_ENGAGED_UV:
spin_lock_irqsave(&part_uv->flags_lock, irq_flags);
part_uv->flags |= XPC_P_ENGAGED_UV;
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sgi-xpc: mark expected switch fall-through
2019-03-20 16:03 [PATCH] sgi-xpc: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-03-20 16:05 ` Robin Holt
0 siblings, 0 replies; 2+ messages in thread
From: Robin Holt @ 2019-03-20 16:05 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Cliff Whickman, Arnd Bergmann, Greg Kroah-Hartman, LKML, Kees Cook
On Wed, Mar 20, 2019 at 11:04 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
...
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Robin Holt<robinmholt@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-20 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 16:03 [PATCH] sgi-xpc: mark expected switch fall-through Gustavo A. R. Silva
2019-03-20 16:05 ` Robin Holt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).