From: Robin Holt <robinmholt@gmail.com>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cliff Whickman <cpw@sgi.com>
Subject: Re: [PATCH] sgi-xp: use designated initializers
Date: Wed, 21 Dec 2016 10:24:14 -0600 [thread overview]
Message-ID: <CAPp3RGpypuUhOoEMv_wODdD4m4VoRytuRrJhL1NyJYwwqBxCcA@mail.gmail.com> (raw)
In-Reply-To: <20161217010127.GA140378@beast>
On Fri, Dec 16, 2016 at 7:01 PM, Kees Cook <keescook@chromium.org> wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from grsecurity.
I guess I don't understand the context enough here to give you a
Signed-off-by. Can you give us more background on this randomization?
>From what I see in the code here, I can see you are providing
equivalent functionality and I would give it a signed-off-by, but I am
not sure this randomization of which you speak is not going to cause
problems for XP, XPC, XPNET, and XPMEM (out of tree GPL kernel
module).
Robin
next prev parent reply other threads:[~2016-12-21 16:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 1:01 [PATCH] sgi-xp: use designated initializers Kees Cook
2016-12-21 16:24 ` Robin Holt [this message]
2017-01-03 23:19 ` Kees Cook
2017-03-29 20:48 ` Kees Cook
2017-05-06 7:16 ` Kees Cook
2017-05-08 17:32 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPp3RGpypuUhOoEMv_wODdD4m4VoRytuRrJhL1NyJYwwqBxCcA@mail.gmail.com \
--to=robinmholt@gmail.com \
--cc=cpw@sgi.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).