* [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
@ 2021-06-21 20:04 Marcin Wojtas
2021-06-21 20:06 ` Marcin Wojtas
2021-07-14 12:27 ` [net-next: PATCH v3 1/1] " Rafael J. Wysocki
0 siblings, 2 replies; 7+ messages in thread
From: Marcin Wojtas @ 2021-06-21 20:04 UTC (permalink / raw)
To: linux-kernel, linux-acpi, devel
Cc: jaz, gjb, upstream, Samer.El-Haj-Mahmoud, jon, tn, rjw, lenb,
erik.kaneda, robert.moore, Marcin Wojtas
The Microsoft Debug Port Table 2 (DBG2) specification revision
May 31, 2017 adds support for 16550-compatible Serial Port
Subtype with parameters defined in Generic Address Structure (GAS) [1]
Add its support in SPCR parsing routine.
[1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
include/acpi/actbl1.h | 1 +
drivers/acpi/spcr.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
index ce59903c2695..f746012eba8d 100644
--- a/include/acpi/actbl1.h
+++ b/include/acpi/actbl1.h
@@ -498,6 +498,7 @@ struct acpi_dbg2_device {
#define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E
#define ACPI_DBG2_ARM_DCC 0x000F
#define ACPI_DBG2_BCM2835 0x0010
+#define ACPI_DBG2_16550_WITH_GAS 0x0012
#define ACPI_DBG2_1394_STANDARD 0x0000
diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
index 88460bacd5ae..25c2d0be953e 100644
--- a/drivers/acpi/spcr.c
+++ b/drivers/acpi/spcr.c
@@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
break;
case ACPI_DBG2_16550_COMPATIBLE:
case ACPI_DBG2_16550_SUBSET:
+ case ACPI_DBG2_16550_WITH_GAS:
uart = "uart";
break;
default:
--
2.29.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
2021-06-21 20:04 [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype Marcin Wojtas
@ 2021-06-21 20:06 ` Marcin Wojtas
2021-06-25 17:18 ` [PATCH] " Marcin Wojtas
2021-07-14 12:27 ` [net-next: PATCH v3 1/1] " Rafael J. Wysocki
1 sibling, 1 reply; 7+ messages in thread
From: Marcin Wojtas @ 2021-06-21 20:06 UTC (permalink / raw)
To: Linux Kernel Mailing List, ACPI Devel Maling List, devel
Apologies for the patch prefix, of course it's a first version and
unrelated to the networking subsystem.
Best regards,
Marcin
pon., 21 cze 2021 o 22:05 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> The Microsoft Debug Port Table 2 (DBG2) specification revision
> May 31, 2017 adds support for 16550-compatible Serial Port
> Subtype with parameters defined in Generic Address Structure (GAS) [1]
>
> Add its support in SPCR parsing routine.
>
> [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> include/acpi/actbl1.h | 1 +
> drivers/acpi/spcr.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index ce59903c2695..f746012eba8d 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -498,6 +498,7 @@ struct acpi_dbg2_device {
> #define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E
> #define ACPI_DBG2_ARM_DCC 0x000F
> #define ACPI_DBG2_BCM2835 0x0010
> +#define ACPI_DBG2_16550_WITH_GAS 0x0012
>
> #define ACPI_DBG2_1394_STANDARD 0x0000
>
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index 88460bacd5ae..25c2d0be953e 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> break;
> case ACPI_DBG2_16550_COMPATIBLE:
> case ACPI_DBG2_16550_SUBSET:
> + case ACPI_DBG2_16550_WITH_GAS:
> uart = "uart";
> break;
> default:
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
2021-06-21 20:06 ` Marcin Wojtas
@ 2021-06-25 17:18 ` Marcin Wojtas
2021-06-25 17:20 ` Rafael J. Wysocki
0 siblings, 1 reply; 7+ messages in thread
From: Marcin Wojtas @ 2021-06-25 17:18 UTC (permalink / raw)
To: Linux Kernel Mailing List, ACPI Devel Maling List, devel
Cc: Grzegorz Jaszczyk, Grzegorz Bernacki, upstream,
Samer El-Haj-Mahmoud, Jon Nettleton, Tomasz Nowicki, rjw, lenb,
erik.kaneda, robert.moore, Marcin Wojtas
Hi,
pon., 21 cze 2021 o 22:06 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> Apologies for the patch prefix, of course it's a first version and
> unrelated to the networking subsystem.
>
> Best regards,
> Marcin
>
>
> pon., 21 cze 2021 o 22:05 Marcin Wojtas <mw@semihalf.com> napisał(a):
> >
> > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > May 31, 2017 adds support for 16550-compatible Serial Port
> > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> >
> > Add its support in SPCR parsing routine.
> >
> > [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> > include/acpi/actbl1.h | 1 +
> > drivers/acpi/spcr.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index ce59903c2695..f746012eba8d 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -498,6 +498,7 @@ struct acpi_dbg2_device {
> > #define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E
> > #define ACPI_DBG2_ARM_DCC 0x000F
> > #define ACPI_DBG2_BCM2835 0x0010
> > +#define ACPI_DBG2_16550_WITH_GAS 0x0012
> >
> > #define ACPI_DBG2_1394_STANDARD 0x0000
> >
> > diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> > index 88460bacd5ae..25c2d0be953e 100644
> > --- a/drivers/acpi/spcr.c
> > +++ b/drivers/acpi/spcr.c
> > @@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> > break;
> > case ACPI_DBG2_16550_COMPATIBLE:
> > case ACPI_DBG2_16550_SUBSET:
> > + case ACPI_DBG2_16550_WITH_GAS:
> > uart = "uart";
> > break;
> > default:
> > --
Do you have any comments / remarks to the patch?
Best regards,
Marcin
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
2021-06-25 17:18 ` [PATCH] " Marcin Wojtas
@ 2021-06-25 17:20 ` Rafael J. Wysocki
2021-06-25 17:21 ` Marcin Wojtas
0 siblings, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2021-06-25 17:20 UTC (permalink / raw)
To: Marcin Wojtas
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Grzegorz Jaszczyk, Grzegorz Bernacki, upstream,
Samer El-Haj-Mahmoud, Jon Nettleton, Tomasz Nowicki,
Rafael J. Wysocki, Len Brown, Erik Kaneda, Robert Moore
On Fri, Jun 25, 2021 at 7:18 PM Marcin Wojtas <mw@semihalf.com> wrote:
>
> Hi,
>
> pon., 21 cze 2021 o 22:06 Marcin Wojtas <mw@semihalf.com> napisał(a):
> >
> > Apologies for the patch prefix, of course it's a first version and
> > unrelated to the networking subsystem.
> >
> > Best regards,
> > Marcin
> >
> >
> > pon., 21 cze 2021 o 22:05 Marcin Wojtas <mw@semihalf.com> napisał(a):
> > >
> > > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > > May 31, 2017 adds support for 16550-compatible Serial Port
> > > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> > >
> > > Add its support in SPCR parsing routine.
> > >
> > > [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
> > >
> > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > ---
> > > include/acpi/actbl1.h | 1 +
> > > drivers/acpi/spcr.c | 1 +
> > > 2 files changed, 2 insertions(+)
> > >
> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > > index ce59903c2695..f746012eba8d 100644
> > > --- a/include/acpi/actbl1.h
> > > +++ b/include/acpi/actbl1.h
> > > @@ -498,6 +498,7 @@ struct acpi_dbg2_device {
> > > #define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E
> > > #define ACPI_DBG2_ARM_DCC 0x000F
> > > #define ACPI_DBG2_BCM2835 0x0010
> > > +#define ACPI_DBG2_16550_WITH_GAS 0x0012
> > >
> > > #define ACPI_DBG2_1394_STANDARD 0x0000
> > >
> > > diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> > > index 88460bacd5ae..25c2d0be953e 100644
> > > --- a/drivers/acpi/spcr.c
> > > +++ b/drivers/acpi/spcr.c
> > > @@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> > > break;
> > > case ACPI_DBG2_16550_COMPATIBLE:
> > > case ACPI_DBG2_16550_SUBSET:
> > > + case ACPI_DBG2_16550_WITH_GAS:
> > > uart = "uart";
> > > break;
> > > default:
> > > --
>
> Do you have any comments / remarks to the patch?
Yes, I do, but I will get back to you next week.
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
2021-06-25 17:20 ` Rafael J. Wysocki
@ 2021-06-25 17:21 ` Marcin Wojtas
0 siblings, 0 replies; 7+ messages in thread
From: Marcin Wojtas @ 2021-06-25 17:21 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Grzegorz Jaszczyk, Grzegorz Bernacki, upstream,
Samer El-Haj-Mahmoud, Jon Nettleton, Tomasz Nowicki,
Rafael J. Wysocki, Len Brown, Erik Kaneda, Robert Moore
pt., 25 cze 2021 o 19:20 Rafael J. Wysocki <rafael@kernel.org> napisał(a):
>
> On Fri, Jun 25, 2021 at 7:18 PM Marcin Wojtas <mw@semihalf.com> wrote:
> >
> > Hi,
> >
> > pon., 21 cze 2021 o 22:06 Marcin Wojtas <mw@semihalf.com> napisał(a):
> > >
> > > Apologies for the patch prefix, of course it's a first version and
> > > unrelated to the networking subsystem.
> > >
> > > Best regards,
> > > Marcin
> > >
> > >
> > > pon., 21 cze 2021 o 22:05 Marcin Wojtas <mw@semihalf.com> napisał(a):
> > > >
> > > > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > > > May 31, 2017 adds support for 16550-compatible Serial Port
> > > > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> > > >
> > > > Add its support in SPCR parsing routine.
> > > >
> > > > [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
> > > >
> > > > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > > > ---
> > > > include/acpi/actbl1.h | 1 +
> > > > drivers/acpi/spcr.c | 1 +
> > > > 2 files changed, 2 insertions(+)
> > > >
> > > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > > > index ce59903c2695..f746012eba8d 100644
> > > > --- a/include/acpi/actbl1.h
> > > > +++ b/include/acpi/actbl1.h
> > > > @@ -498,6 +498,7 @@ struct acpi_dbg2_device {
> > > > #define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E
> > > > #define ACPI_DBG2_ARM_DCC 0x000F
> > > > #define ACPI_DBG2_BCM2835 0x0010
> > > > +#define ACPI_DBG2_16550_WITH_GAS 0x0012
> > > >
> > > > #define ACPI_DBG2_1394_STANDARD 0x0000
> > > >
> > > > diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> > > > index 88460bacd5ae..25c2d0be953e 100644
> > > > --- a/drivers/acpi/spcr.c
> > > > +++ b/drivers/acpi/spcr.c
> > > > @@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> > > > break;
> > > > case ACPI_DBG2_16550_COMPATIBLE:
> > > > case ACPI_DBG2_16550_SUBSET:
> > > > + case ACPI_DBG2_16550_WITH_GAS:
> > > > uart = "uart";
> > > > break;
> > > > default:
> > > > --
> >
> > Do you have any comments / remarks to the patch?
>
> Yes, I do, but I will get back to you next week.
>
Great, thank you!
Marcin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
2021-06-21 20:04 [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype Marcin Wojtas
2021-06-21 20:06 ` Marcin Wojtas
@ 2021-07-14 12:27 ` Rafael J. Wysocki
2021-07-14 19:18 ` Marcin Wojtas
1 sibling, 1 reply; 7+ messages in thread
From: Rafael J. Wysocki @ 2021-07-14 12:27 UTC (permalink / raw)
To: Marcin Wojtas
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Grzegorz Jaszczyk, Grzegorz Bernacki, upstream,
Samer El-Haj-Mahmoud, Jon, Tomasz Nowicki, Rafael J. Wysocki,
Len Brown, Erik Kaneda, Robert Moore
Sorry for the delay.
On Mon, Jun 21, 2021 at 10:05 PM Marcin Wojtas <mw@semihalf.com> wrote:
>
> The Microsoft Debug Port Table 2 (DBG2) specification revision
> May 31, 2017 adds support for 16550-compatible Serial Port
> Subtype with parameters defined in Generic Address Structure (GAS) [1]
>
> Add its support in SPCR parsing routine.
>
> [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> include/acpi/actbl1.h | 1 +
> drivers/acpi/spcr.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index ce59903c2695..f746012eba8d 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
This is an ACPICA header, so the first part of the patch should go in
via the ACPICA upstream repository.
Can you please resend this as two patches to make it easier to process it?
> @@ -498,6 +498,7 @@ struct acpi_dbg2_device {
> #define ACPI_DBG2_ARM_SBSA_GENERIC 0x000E
> #define ACPI_DBG2_ARM_DCC 0x000F
> #define ACPI_DBG2_BCM2835 0x0010
> +#define ACPI_DBG2_16550_WITH_GAS 0x0012
>
> #define ACPI_DBG2_1394_STANDARD 0x0000
>
> diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> index 88460bacd5ae..25c2d0be953e 100644
> --- a/drivers/acpi/spcr.c
> +++ b/drivers/acpi/spcr.c
> @@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> break;
> case ACPI_DBG2_16550_COMPATIBLE:
> case ACPI_DBG2_16550_SUBSET:
> + case ACPI_DBG2_16550_WITH_GAS:
> uart = "uart";
> break;
> default:
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype
2021-07-14 12:27 ` [net-next: PATCH v3 1/1] " Rafael J. Wysocki
@ 2021-07-14 19:18 ` Marcin Wojtas
0 siblings, 0 replies; 7+ messages in thread
From: Marcin Wojtas @ 2021-07-14 19:18 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
open list:ACPI COMPONENT ARCHITECTURE (ACPICA),
Grzegorz Jaszczyk, Grzegorz Bernacki, upstream,
Samer El-Haj-Mahmoud, Jon, Tomasz Nowicki, Rafael J. Wysocki,
Len Brown, Erik Kaneda, Robert Moore
Hi Rafael,
śr., 14 lip 2021 o 14:27 Rafael J. Wysocki <rafael@kernel.org> napisał(a):
>
> Sorry for the delay.
>
> On Mon, Jun 21, 2021 at 10:05 PM Marcin Wojtas <mw@semihalf.com> wrote:
> >
> > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > May 31, 2017 adds support for 16550-compatible Serial Port
> > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> >
> > Add its support in SPCR parsing routine.
> >
> > [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> > include/acpi/actbl1.h | 1 +
> > drivers/acpi/spcr.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > index ce59903c2695..f746012eba8d 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
>
> This is an ACPICA header, so the first part of the patch should go in
> via the ACPICA upstream repository.
>
> Can you please resend this as two patches to make it easier to process it?
>
I created a pull request to the ACPICA upstream with adding all the
missing DBG2 subtypes:
https://github.com/acpica/acpica/pull/705
Once that is accepted and lands, I will import the header update to
Linux along with the driver modification.
Best regards,
Marcin
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-14 19:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-21 20:04 [net-next: PATCH v3 1/1] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype Marcin Wojtas
2021-06-21 20:06 ` Marcin Wojtas
2021-06-25 17:18 ` [PATCH] " Marcin Wojtas
2021-06-25 17:20 ` Rafael J. Wysocki
2021-06-25 17:21 ` Marcin Wojtas
2021-07-14 12:27 ` [net-next: PATCH v3 1/1] " Rafael J. Wysocki
2021-07-14 19:18 ` Marcin Wojtas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).