[PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

[PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

[Ricardo Ribalda Delgado]

Without this patch, some hosts keep restarting indefinitely the target.

Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup)
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---

v2: Request by Felipe Balbi

Use Fixes: on commit message

 drivers/usb/gadget/udc/net2280.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
index f4eac11..2e95715 100644
--- a/drivers/usb/gadget/udc/net2280.c
+++ b/drivers/usb/gadget/udc/net2280.c
@@ -3320,7 +3320,7 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
 	if (stat & tmp) {
 		writel(tmp, &dev->regs->irqstat1);
 		if ((((stat & BIT(ROOT_PORT_RESET_INTERRUPT)) &&
-				(readl(&dev->usb->usbstat) & mask)) ||
+				((readl(&dev->usb->usbstat) & mask) == 0)) ||
 				((readl(&dev->usb->usbctl) &
 					BIT(VBUS_PIN)) == 0)) &&
 				(dev->gadget.speed != USB_SPEED_UNKNOWN)) {
-- 
2.1.0

Re: [PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

[Ricardo Ribalda Delgado]

Hello Felipe

I think that you have forgotten about this patch :). It is needed by
usb3380 in usb3.0 mode. Otherwise the device keeps reseting.

Thanks!

On Tue, Aug 26, 2014 at 6:00 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> Without this patch, some hosts keep restarting indefinitely the target.
>
> Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup)
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>
> v2: Request by Felipe Balbi
>
> Use Fixes: on commit message
>
>  drivers/usb/gadget/udc/net2280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> index f4eac11..2e95715 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -3320,7 +3320,7 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
>         if (stat & tmp) {
>                 writel(tmp, &dev->regs->irqstat1);
>                 if ((((stat & BIT(ROOT_PORT_RESET_INTERRUPT)) &&
> -                               (readl(&dev->usb->usbstat) & mask)) ||
> +                               ((readl(&dev->usb->usbstat) & mask) == 0)) ||
>                                 ((readl(&dev->usb->usbctl) &
>                                         BIT(VBUS_PIN)) == 0)) &&
>                                 (dev->gadget.speed != USB_SPEED_UNKNOWN)) {
> --
> 2.1.0
>



-- 
Ricardo Ribalda

Re: [PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi,

On Mon, Sep 01, 2014 at 01:25:31PM +0200, Ricardo Ribalda Delgado wrote:
> Hello Felipe
> 
> I think that you have forgotten about this patch :). It is needed by
> usb3380 in usb3.0 mode. Otherwise the device keeps reseting.

it's in my testing/fixes. I'm pretty much done with testing, just wanna
wait for -rc3 before sending more fixes.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]