From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jakub Sitnicki <jsitnicki@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Mike Travis <travis@sgi.com>, Thierry Reding <treding@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] kernel/resource: Invalid memory access in __release_resource
Date: Thu, 23 Apr 2015 10:06:36 +0200 [thread overview]
Message-ID: <CAPybu_2rTee+cJvFXNwoovHGywEf1CM3j_JMVaSy_nxj8uNS1g@mail.gmail.com> (raw)
In-Reply-To: <20150422164701.GJ20701@google.com>
Hi Bjorn
On Wed, Apr 22, 2015 at 6:47 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>
> I'm not really a fan of this. The NULL pointer oops is a very good clue
> all by itself, and it doesn't require any extra code here.
It is a pointer to 0x30.
For some reason my platform can handle a couple of oops, but if I get
a fair amount of them in a short period of time, the whole thing
crashes and debugging gets complicated. (no access to dmesg or remote
debugging).
Therefore this particular bug gave me a bad time. Now that we have
located the root of the problem and solved the problem from the root,
this particular error will never be hit. I just wanted to save
somebody else's time with this patch.
All that said, if the other patches are applied, my platform works
completely fine. So it is completely your call to accept this or not
:)
I will resend the patchset without this patch
Thanks!
--
Ricardo Ribalda
next prev parent reply other threads:[~2015-04-23 8:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 16:14 [PATCH v3 0/4] Fix null pointer deference when calling of_platform_depopulate Ricardo Ribalda Delgado
2015-04-22 16:14 ` [PATCH v3 1/4] kernel/resource: Invalid memory access in __release_resource Ricardo Ribalda Delgado
2015-04-22 16:47 ` Bjorn Helgaas
2015-04-23 8:06 ` Ricardo Ribalda Delgado [this message]
2015-04-22 16:14 ` [PATCH v3 2/4] base/platform: Only insert MEM and IO resources Ricardo Ribalda Delgado
2015-04-22 16:14 ` [PATCH v3 3/4] base/platform: Continue on insert_resource() error Ricardo Ribalda Delgado
2015-04-22 16:44 ` Bjorn Helgaas
2015-04-23 7:55 ` Ricardo Ribalda Delgado
2015-04-23 13:26 ` Bjorn Helgaas
2015-04-23 16:54 ` Thierry Reding
2015-04-22 16:14 ` [PATCH v3 4/4] of/platform: Use platform_device interface Ricardo Ribalda Delgado
2015-04-22 16:25 ` Rob Herring
2015-04-23 7:28 ` Ricardo Ribalda Delgado
2015-04-23 13:49 ` Ricardo Ribalda Delgado
2015-05-24 19:29 ` [PATCH v3.1 " Greg Kroah-Hartman
2015-05-26 7:26 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPybu_2rTee+cJvFXNwoovHGywEf1CM3j_JMVaSy_nxj8uNS1g@mail.gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=jsitnicki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=travis@sgi.com \
--cc=treding@nvidia.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).