RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()

From: Thomas Shao <huishao@microsoft.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Mike Surcouf <mps.surcouf.lkml@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
	Jeff Epler <jepler@unpythonic.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"olaf@aepfle.de" <olaf@aepfle.de>,
	"apw@canonical.com" <apw@canonical.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	KY Srinivasan <kys@microsoft.com>,
	John Stultz <john.stultz@linaro.org>,
	Richard Cochran <rcochran@linutronix.de>
Subject: RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()
Date: Wed, 22 Oct 2014 13:51:12 +0000	[thread overview]
Message-ID: <CD2CABCB2C0A0D4682C5F8AD840141540D6BE1@HKXPRD3002MB006.064d.mgd.msft.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1410221441370.5308@nanos>

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Thomas Gleixner
> Sent: Wednesday, October 22, 2014 8:42 PM
> To: Mike Surcouf
> Cc: Thomas Shao; Richard Cochran; Jeff Epler; gregkh@linuxfoundation.org;
> LKML; devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> jasowang@redhat.com; KY Srinivasan; John Stultz; Richard Cochran
> Subject: Re: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for
> do_adjtimex()
> 
> On Wed, 22 Oct 2014, Mike Surcouf wrote:
> 
> > I get that NTP can be installed locally.  This is how I regulate time
> > on my guests.  I agree the admin argument probably doesn't stand up.
> >
> > The problem is hyperv_clocksource (pluggable time source used by
> > hyperv guests) is systematically fast in my environment. by around
> > -250 PPM.
> > I get away with NTP (just).
> > However others have had to use tickadj to get hyperv_clocksource close
> > enough for NTP to work i.e. inside +/-500 PPM. (This IS outside normal
> > admin tasks)
> >
> > So if we are going to use NTP as the solution for hyperv guests (which
> > is a valid one) the systematic drift of hyperv_clocksource in
> > different environments will need to be addressed.  Maybe this patch
> > could be modified to tune the tick count on boot before NTP starts and
> > then leave it alone so NTP can take over.
> 
> How about fixing hyperv_clocksource in the first place?
> 

I've tested the hyperv_clocksource in my environment using upstream kernel. There is some minor time drift (around 1.5 second one day), it should not be that big, and break ntp. 

Mike, can you share me your kernel version and which Linux distro do you use? 

> Thanks,
> 
> 	tglx
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the
> body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/