From: Thomas Gleixner <tglx@linutronix.de>
To: Thomas Shao <huishao@microsoft.com>
Cc: John Stultz <john.stultz@linaro.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
"apw@canonical.com" <apw@canonical.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
KY Srinivasan <kys@microsoft.com>,
Richard Cochran <rcochran@linutronix.de>
Subject: RE: [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex()
Date: Tue, 21 Oct 2014 10:23:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1410211020101.5308@nanos> (raw)
In-Reply-To: <CD2CABCB2C0A0D4682C5F8AD840141540D290B@HKXPRD3002MB006.064d.mgd.msft.net>
On Tue, 21 Oct 2014, Thomas Shao wrote:
> I didn't find a way to detect whether NTPd is running in the hyper-v module.
And you better do not try at all.
> In http://doc.ntp.org/4.1.0/ntpd.htm, it mentioned: Normally, the
> time is slewed if the offset is less than the step threshold, which
> is 128 ms by default, and stepped if above the threshold.
>
> In my implementation, I use 100ms as the threshold (maybe I should
> change to 128?). If the time difference is less than 100ms, I just
> do nothing. So, if NTPd is running, ideally it could keep the time
> drift less than 128, so the adjustment in my patch will not get
> triggered.
Your implementation has nothing to do with NTP at all. It's not even
close to NTP. It's a random hack to inject host time or slew into
timekeeping with the precision of a random number generator.
> And moreover, by default, the guest-host time sync is turn
> off. There is a module parameter to control it. We'll also document
> customer that do not turn on this if NTP is configured.
Pretty well thought out mechanism to ensure that people will get it
wrong in the first place.
Thanks,
tglx
next prev parent reply other threads:[~2014-10-21 8:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 8:39 [PATCH v2 1/2] timekeeping: add EXPORT_SYMBOL_GPL for do_adjtimex() Thomas Shao
2014-10-20 18:28 ` Thomas Gleixner
2014-10-20 18:40 ` Thomas Gleixner
2014-10-21 3:18 ` Thomas Shao
2014-10-21 3:24 ` John Stultz
2014-10-21 4:08 ` Thomas Shao
2014-10-21 8:23 ` Thomas Gleixner [this message]
2014-10-21 4:02 ` Jeff Epler
2014-10-21 4:55 ` Thomas Shao
2014-10-21 8:25 ` Thomas Gleixner
2014-10-21 8:20 ` Richard Cochran
2014-10-21 10:11 ` Thomas Shao
2014-10-22 11:01 ` Mike Surcouf
2014-10-22 12:42 ` Thomas Gleixner
2014-10-22 13:51 ` Thomas Shao
2014-10-22 14:20 ` Mike Surcouf
2014-10-21 8:13 ` Richard Cochran
2014-10-21 9:16 ` Thomas Shao
2014-10-21 8:19 ` Thomas Gleixner
2014-10-21 9:02 ` Thomas Shao
2014-10-21 2:37 ` Thomas Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1410211020101.5308@nanos \
--to=tglx@linutronix.de \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=huishao@microsoft.com \
--cc=jasowang@redhat.com \
--cc=john.stultz@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=rcochran@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).