[PATCH] writeback: fix comment in __mark_inode_dirty

[PATCH] writeback: fix comment in __mark_inode_dirty

[Wang Long]

Signed-off-by: Wang Long <wanglong19@meituan.com>
---
 fs/fs-writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index cea4836..8d477cf 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
 			trace_writeback_dirty_inode_enqueue(inode);
 
 			/*
-			 * If this is the first dirty inode for this bdi,
+			 * If this is the first dirty inode for this wb,
 			 * we have to wake-up the corresponding bdi thread
 			 * to make sure background write-back happens
 			 * later.
-- 
1.8.3.1

Re: [PATCH] writeback: fix comment in __mark_inode_dirty

[Tejun Heo]

Hello, Wang.

On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote:
> Signed-off-by: Wang Long <wanglong19@meituan.com>
> ---
>  fs/fs-writeback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index cea4836..8d477cf 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>  			trace_writeback_dirty_inode_enqueue(inode);
>  
>  			/*
> -			 * If this is the first dirty inode for this bdi,
> +			 * If this is the first dirty inode for this wb,

Acked-by: Tejun Heo <tj@kernel.org>

This probably should go through the block tree tho.  Please cc Jens
Axboe.

Thanks.

-- 
tejun

Re: [PATCH] writeback: fix comment in __mark_inode_dirty

[wanglong]

Cc: Jens Axboe

> On 5 Dec 2017, at 11:48 PM, tj@kernel.org wrote:
> 
> Hello, Wang.
> 
> On Tue, Dec 05, 2017 at 12:52:54AM -0500, Wang Long wrote:
>> Signed-off-by: Wang Long <wanglong19@meituan.com>
>> ---
>> fs/fs-writeback.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
>> index cea4836..8d477cf 100644
>> --- a/fs/fs-writeback.c
>> +++ b/fs/fs-writeback.c
>> @@ -2209,7 +2209,7 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>> 			trace_writeback_dirty_inode_enqueue(inode);
>> 
>> 			/*
>> -			 * If this is the first dirty inode for this bdi,
>> +			 * If this is the first dirty inode for this wb,
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 
> This probably should go through the block tree tho.  Please cc Jens
> Axboe.
> 
> Thanks.
> 
> -- 
> tejun