* Re: [PATCH v3] perf inject --jit: Remove //anon mmap events
@ 2019-12-28 18:02 Francois Saint-Jacques
2019-12-29 15:51 ` Jiri Olsa
0 siblings, 1 reply; 4+ messages in thread
From: Francois Saint-Jacques @ 2019-12-28 18:02 UTC (permalink / raw)
To: jolsa; +Cc: Steve.MacLean, eranian, linux-kernel
I'd just like to weight in that this patch fixes the issue Steve
mentioned. I have a local experiment using LLVM's ORC jit with jitdump
support and couldn't get any symbols recognized by perf until applying
this patch.
Thank you,
François
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] perf inject --jit: Remove //anon mmap events
2019-12-28 18:02 [PATCH v3] perf inject --jit: Remove //anon mmap events Francois Saint-Jacques
@ 2019-12-29 15:51 ` Jiri Olsa
2020-04-27 22:03 ` [EXTERNAL] " Steve MacLean
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Olsa @ 2019-12-29 15:51 UTC (permalink / raw)
To: Francois Saint-Jacques
Cc: Steve.MacLean, eranian, linux-kernel, Arnaldo Carvalho de Melo
On Sat, Dec 28, 2019 at 01:02:13PM -0500, Francois Saint-Jacques wrote:
> I'd just like to weight in that this patch fixes the issue Steve
> mentioned. I have a local experiment using LLVM's ORC jit with jitdump
> support and couldn't get any symbols recognized by perf until applying
> this patch.
great, please reply to the orginal patch post with tested-by
Arnaldo, could you please check on this one?
there was some discussion about used clockid, but Stephane or
any other jit guys did not raise any particular concern AFAICS,
also it's simple enough to revert in case there's any issue
thanks,
jirka
>
> Thank you,
> François
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXTERNAL] Re: [PATCH v3] perf inject --jit: Remove //anon mmap events
2019-12-29 15:51 ` Jiri Olsa
@ 2020-04-27 22:03 ` Steve MacLean
2020-04-28 9:53 ` Jiri Olsa
0 siblings, 1 reply; 4+ messages in thread
From: Steve MacLean @ 2020-04-27 22:03 UTC (permalink / raw)
To: Jiri Olsa, Francois Saint-Jacques
Cc: eranian, linux-kernel, Arnaldo Carvalho de Melo
> it's simple enough to revert in case there's any issue
>
> thanks,
> jirka
Can we go ahead and merge this?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [EXTERNAL] Re: [PATCH v3] perf inject --jit: Remove //anon mmap events
2020-04-27 22:03 ` [EXTERNAL] " Steve MacLean
@ 2020-04-28 9:53 ` Jiri Olsa
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Olsa @ 2020-04-28 9:53 UTC (permalink / raw)
To: Steve MacLean
Cc: Francois Saint-Jacques, eranian, linux-kernel, Arnaldo Carvalho de Melo
On Mon, Apr 27, 2020 at 10:03:58PM +0000, Steve MacLean wrote:
> > it's simple enough to revert in case there's any issue
> >
> > thanks,
> > jirka
>
> Can we go ahead and merge this?
>
I saw the explanation you posted:
https://lore.kernel.org/lkml/CY4PR21MB0632B5EE447DA9B931CB114DF7740@CY4PR21MB0632.namprd21.prod.outlook.com/
could you please add it to the patch changelog and repost?
as I said I'm ok with the patch, Stephane?
jirka
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-28 9:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-28 18:02 [PATCH v3] perf inject --jit: Remove //anon mmap events Francois Saint-Jacques
2019-12-29 15:51 ` Jiri Olsa
2020-04-27 22:03 ` [EXTERNAL] " Steve MacLean
2020-04-28 9:53 ` Jiri Olsa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).