* [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
@ 2016-06-01 9:19 Ashwin Ravichandran
2016-06-01 9:35 ` Ian Abbott
2016-06-18 4:01 ` Greg KH
0 siblings, 2 replies; 7+ messages in thread
From: Ashwin Ravichandran @ 2016-06-01 9:19 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, hsweeten, abbotti, Ashwin Ravichandran
Fixed a coding style issue.
Signed-off-by: Ashwin Ravichandran <ashwinravichandran24@gmail.com>
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
index 3757074..9c27999 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
@@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev,
data[0] != ADDIDATA_TIMER)
return -EINVAL;
- devpriv->tsk_Current = current;
+ devpriv->tsk_current = current;
devpriv->timer_mode = data[0];
diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
index 40ff914..b2f6712 100644
--- a/drivers/staging/comedi/drivers/addi_apci_3501.c
+++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
@@ -68,7 +68,7 @@
struct apci3501_private {
unsigned long amcc;
unsigned long tcw;
- struct task_struct *tsk_Current;
+ struct task_struct *tsk_current;
unsigned char timer_mode;
};
@@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
}
/* Enable Interrupt Send a signal to from kernel to user space */
- send_sig(SIGIO, devpriv->tsk_Current, 0);
+ send_sig(SIGIO, devpriv->tsk_current, 0);
ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
ADDI_TCW_CTRL_IRQ_ENA);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
2016-06-01 9:19 [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue Ashwin Ravichandran
@ 2016-06-01 9:35 ` Ian Abbott
2016-06-18 4:01 ` Greg KH
2016-06-18 4:01 ` Greg KH
1 sibling, 1 reply; 7+ messages in thread
From: Ian Abbott @ 2016-06-01 9:35 UTC (permalink / raw)
To: Ashwin Ravichandran, gregkh; +Cc: devel, linux-kernel, hsweeten
On 01/06/16 10:19, Ashwin Ravichandran wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Ashwin Ravichandran <ashwinravichandran24@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
> drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 3757074..9c27999 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev,
> data[0] != ADDIDATA_TIMER)
> return -EINVAL;
>
> - devpriv->tsk_Current = current;
> + devpriv->tsk_current = current;
>
> devpriv->timer_mode = data[0];
>
> diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> index 40ff914..b2f6712 100644
> --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> @@ -68,7 +68,7 @@
> struct apci3501_private {
> unsigned long amcc;
> unsigned long tcw;
> - struct task_struct *tsk_Current;
> + struct task_struct *tsk_current;
> unsigned char timer_mode;
> };
>
> @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> }
>
> /* Enable Interrupt Send a signal to from kernel to user space */
> - send_sig(SIGIO, devpriv->tsk_Current, 0);
> + send_sig(SIGIO, devpriv->tsk_current, 0);
> ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
> ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
> ADDI_TCW_CTRL_IRQ_ENA);
>
The patch looks fine (although this odd-ball Comedi driver shouldn't
really be sending signals to a user-space task!).
Is this really PATCH 2649/2649?
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
2016-06-01 9:19 [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue Ashwin Ravichandran
2016-06-01 9:35 ` Ian Abbott
@ 2016-06-18 4:01 ` Greg KH
1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2016-06-18 4:01 UTC (permalink / raw)
To: Ashwin Ravichandran; +Cc: devel, abbotti, linux-kernel
On Wed, Jun 01, 2016 at 02:19:35AM -0700, Ashwin Ravichandran wrote:
> Fixed a coding style issue.
Which one?
And where are the 2648 previous patches in this series?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
2016-06-01 9:35 ` Ian Abbott
@ 2016-06-18 4:01 ` Greg KH
2016-06-20 17:22 ` Hartley Sweeten
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2016-06-18 4:01 UTC (permalink / raw)
To: Ian Abbott; +Cc: Ashwin Ravichandran, devel, linux-kernel
On Wed, Jun 01, 2016 at 10:35:57AM +0100, Ian Abbott wrote:
> On 01/06/16 10:19, Ashwin Ravichandran wrote:
> > Fixed a coding style issue.
> >
> > Signed-off-by: Ashwin Ravichandran <ashwinravichandran24@gmail.com>
> > ---
> > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
> > drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> > index 3757074..9c27999 100644
> > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> > @@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev,
> > data[0] != ADDIDATA_TIMER)
> > return -EINVAL;
> >
> > - devpriv->tsk_Current = current;
> > + devpriv->tsk_current = current;
> >
> > devpriv->timer_mode = data[0];
> >
> > diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
> > index 40ff914..b2f6712 100644
> > --- a/drivers/staging/comedi/drivers/addi_apci_3501.c
> > +++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
> > @@ -68,7 +68,7 @@
> > struct apci3501_private {
> > unsigned long amcc;
> > unsigned long tcw;
> > - struct task_struct *tsk_Current;
> > + struct task_struct *tsk_current;
> > unsigned char timer_mode;
> > };
> >
> > @@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > }
> >
> > /* Enable Interrupt Send a signal to from kernel to user space */
> > - send_sig(SIGIO, devpriv->tsk_Current, 0);
> > + send_sig(SIGIO, devpriv->tsk_current, 0);
> > ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
> > ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
> > ADDI_TCW_CTRL_IRQ_ENA);
> >
>
> The patch looks fine (although this odd-ball Comedi driver shouldn't really
> be sending signals to a user-space task!).
Yeah, that's really odd, fixing that would be nice...
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
2016-06-18 4:01 ` Greg KH
@ 2016-06-20 17:22 ` Hartley Sweeten
0 siblings, 0 replies; 7+ messages in thread
From: Hartley Sweeten @ 2016-06-20 17:22 UTC (permalink / raw)
To: Greg KH, Ian Abbott; +Cc: devel, linux-kernel, Ashwin Ravichandran
On Friday, June 17, 2016 9:02 PM, Greg KH wrote:
>> The patch looks fine (although this odd-ball Comedi driver shouldn't really
>> be sending signals to a user-space task!).
>
> Yeah, that's really odd, fixing that would be nice...
This is the last addi-data driver that does this. It's on my list to fix.
Hartley
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
2016-06-01 6:00 Ashwin
@ 2016-06-01 6:10 ` Greg KH
0 siblings, 0 replies; 7+ messages in thread
From: Greg KH @ 2016-06-01 6:10 UTC (permalink / raw)
To: Ashwin; +Cc: devel, linux-kernel, hsweeten, abbotti
On Tue, May 31, 2016 at 11:00:01PM -0700, Ashwin wrote:
> From: Ashwin R <ashwinravichandran24@gmail.com>
I need a "full" name here, and in the signed-off-by line please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue
@ 2016-06-01 6:00 Ashwin
2016-06-01 6:10 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Ashwin @ 2016-06-01 6:00 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, hsweeten, abbotti, Ashwin R
From: Ashwin R <ashwinravichandran24@gmail.com>
Fixed a coding style issue.
Signed-off-by: Ashwin R <ashwinravichandran24@gmail.com>
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 2 +-
drivers/staging/comedi/drivers/addi_apci_3501.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
index 3757074..9c27999 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
@@ -28,7 +28,7 @@ static int apci3501_config_insn_timer(struct comedi_device *dev,
data[0] != ADDIDATA_TIMER)
return -EINVAL;
- devpriv->tsk_Current = current;
+ devpriv->tsk_current = current;
devpriv->timer_mode = data[0];
diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c b/drivers/staging/comedi/drivers/addi_apci_3501.c
index 40ff914..b2f6712 100644
--- a/drivers/staging/comedi/drivers/addi_apci_3501.c
+++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
@@ -68,7 +68,7 @@
struct apci3501_private {
unsigned long amcc;
unsigned long tcw;
- struct task_struct *tsk_Current;
+ struct task_struct *tsk_current;
unsigned char timer_mode;
};
@@ -273,7 +273,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
}
/* Enable Interrupt Send a signal to from kernel to user space */
- send_sig(SIGIO, devpriv->tsk_Current, 0);
+ send_sig(SIGIO, devpriv->tsk_current, 0);
ctrl = inl(devpriv->tcw + ADDI_TCW_CTRL_REG);
ctrl &= ~(ADDI_TCW_CTRL_GATE | ADDI_TCW_CTRL_TRIG |
ADDI_TCW_CTRL_IRQ_ENA);
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-06-20 17:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-01 9:19 [PATCH 2649/2649] Staging: comedi : fixed a camel case style issue Ashwin Ravichandran
2016-06-01 9:35 ` Ian Abbott
2016-06-18 4:01 ` Greg KH
2016-06-20 17:22 ` Hartley Sweeten
2016-06-18 4:01 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2016-06-01 6:00 Ashwin
2016-06-01 6:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).