* drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ?
@ 2016-05-23 11:11 David Binderman
2016-05-23 11:26 ` Yuval Mintz
0 siblings, 1 reply; 2+ messages in thread
From: David Binderman @ 2016-05-23 11:11 UTC (permalink / raw)
To: Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev, linux-kernel, dcb314
Hello there,
drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210:16: warning: comparison
is always false due to limited range of data type [-Wtype-limits]
Source code is
if (priority < 0) {
but
u8 tc, priority, priority_map;
Regards
David Binderman
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ?
2016-05-23 11:11 drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ? David Binderman
@ 2016-05-23 11:26 ` Yuval Mintz
0 siblings, 0 replies; 2+ messages in thread
From: Yuval Mintz @ 2016-05-23 11:26 UTC (permalink / raw)
To: David Binderman, netdev, linux-kernel, dcb314; +Cc: Dan Carpenter, Ariel Elior
> Hello there,
>
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210:16: warning: comparison is
> always false due to limited range of data type [-Wtype-limits]
>
> Source code is
>
> if (priority < 0) {
>
> but
>
> u8 tc, priority, priority_map;
>
>
> Regards
>
> David Binderman
Hi David,
Dan Carpenter has already sent a fix for this one ~an hour ago.
[https://patchwork.ozlabs.org/patch/625114/]
Thanks,
Yuval
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-23 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-23 11:11 drivers/net/ethernet/qlogic/qed/qed_dcbx.c:210: pointless test ? David Binderman
2016-05-23 11:26 ` Yuval Mintz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).