linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] rust: MAINTAINERS: Add the zulip link
@ 2023-01-28  7:22 Boqun Feng
  2023-01-28 10:29 ` Vincenzo Palazzo
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Boqun Feng @ 2023-01-28  7:22 UTC (permalink / raw)
  To: rust-for-linux
  Cc: Greg KH, Boqun Feng, Miguel Ojeda, Alex Gaynor,
	Wedson Almeida Filho, Gary Guo, Björn Roy Baron,
	linux-kernel

Zulip organization "rust-for-linux" has been created since about 2 years
ago[1], and proven to be a great place for Rust related discussion,
therefore add the information in MAINTAINERS file so that newcomers have
more options to find guide and help.

[1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/

Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
v1 -> v2:

	* 	As suggested by Greg KH, add commit message.

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 42fc47c6edfd..30161207f365 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18219,6 +18219,7 @@ R:	Boqun Feng <boqun.feng@gmail.com>
 R:	Gary Guo <gary@garyguo.net>
 R:	Björn Roy Baron <bjorn3_gh@protonmail.com>
 L:	rust-for-linux@vger.kernel.org
+C:	zulip://rust-for-linux.zulipchat.com
 S:	Supported
 W:	https://github.com/Rust-for-Linux/linux
 B:	https://github.com/Rust-for-Linux/linux/issues
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] rust: MAINTAINERS: Add the zulip link
  2023-01-28  7:22 [PATCH v2] rust: MAINTAINERS: Add the zulip link Boqun Feng
@ 2023-01-28 10:29 ` Vincenzo Palazzo
  2023-02-01  1:38 ` Miguel Ojeda
  2023-02-02  8:45 ` [PATCH v2] " Alice Ferrazzi
  2 siblings, 0 replies; 7+ messages in thread
From: Vincenzo Palazzo @ 2023-01-28 10:29 UTC (permalink / raw)
  To: Boqun Feng, rust-for-linux
  Cc: Greg KH, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho,
	Gary Guo, Björn Roy Baron, linux-kernel

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

On Sat Jan 28, 2023 at 8:22 AM CET, Boqun Feng wrote:
> Zulip organization "rust-for-linux" has been created since about 2 years
> ago[1], and proven to be a great place for Rust related discussion,
> therefore add the information in MAINTAINERS file so that newcomers have
> more options to find guide and help.
>
> [1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/
>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
> v1 -> v2:
>
> 	* 	As suggested by Greg KH, add commit message.
>
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42fc47c6edfd..30161207f365 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18219,6 +18219,7 @@ R:	Boqun Feng <boqun.feng@gmail.com>
>  R:	Gary Guo <gary@garyguo.net>
>  R:	Björn Roy Baron <bjorn3_gh@protonmail.com>
>  L:	rust-for-linux@vger.kernel.org
> +C:	zulip://rust-for-linux.zulipchat.com
>  S:	Supported
>  W:	https://github.com/Rust-for-Linux/linux
>  B:	https://github.com/Rust-for-Linux/linux/issues
> -- 
> 2.39.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] rust: MAINTAINERS: Add the zulip link
  2023-01-28  7:22 [PATCH v2] rust: MAINTAINERS: Add the zulip link Boqun Feng
  2023-01-28 10:29 ` Vincenzo Palazzo
@ 2023-02-01  1:38 ` Miguel Ojeda
  2023-02-01 18:45   ` [PATCH v3] " Boqun Feng
  2023-02-02  8:45 ` [PATCH v2] " Alice Ferrazzi
  2 siblings, 1 reply; 7+ messages in thread
From: Miguel Ojeda @ 2023-02-01  1:38 UTC (permalink / raw)
  To: Boqun Feng
  Cc: rust-for-linux, Greg KH, Miguel Ojeda, Alex Gaynor,
	Wedson Almeida Filho, Gary Guo, Björn Roy Baron,
	linux-kernel

On Sat, Jan 28, 2023 at 8:23 AM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> Zulip organization "rust-for-linux" has been created since about 2 years

"was created about 2 years ago ... and has proven" maybe?

> [1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/

We typically do links as a tag, like:

    Link: https://..../ [1]

>  R:     Gary Guo <gary@garyguo.net>
>  R:     Björn Roy Baron <bjorn3_gh@protonmail.com>
>  L:     rust-for-linux@vger.kernel.org
> +C:     zulip://rust-for-linux.zulipchat.com
>  S:     Supported
>  W:     https://github.com/Rust-for-Linux/linux
>  B:     https://github.com/Rust-for-Linux/linux/issues

The preferred order according to the top of the file is `C:` after
`B:` -- could you please move it? (even if not everybody follows it)

Thanks Boqun!

Also, for reference for others: a few of us discussed a bit in Zulip
whether to use `zulip://` or `https://` here: `zulip://` hints at the
fact that it is possible to join with apps/clients and not just with a
web browser, which is why Boqun wants to use this one. Support for the
URI scheme in place of the `https://` one isn't great in some of the
apps, though, so I worried it could be confusing.

Hopefully the URI scheme support will improve in the future. So let's
try `zulip://` -- it may help getting better support for that URI
scheme too :)

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v3] rust: MAINTAINERS: Add the zulip link
  2023-02-01  1:38 ` Miguel Ojeda
@ 2023-02-01 18:45   ` Boqun Feng
  2023-02-01 22:50     ` Miguel Ojeda
  2023-02-02  7:27     ` Vincenzo Palazzo
  0 siblings, 2 replies; 7+ messages in thread
From: Boqun Feng @ 2023-02-01 18:45 UTC (permalink / raw)
  To: rust-for-linux
  Cc: Greg KH, Boqun Feng, Miguel Ojeda, Alex Gaynor,
	Wedson Almeida Filho, Gary Guo, Björn Roy Baron,
	linux-kernel

Zulip organization "rust-for-linux" was created 2 years ago[1] and has
proven to be a great place for Rust related discussion, therefore
add the information in MAINTAINERS file so that newcomers have more
options to find guide and help.

Link: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/ [1]
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
v2 -> v3:

	*	Commit message improvement per Miguel.
	*	Reorder the line after "B:" as suggested by Miguel.

v1 -> v2:

	* 	As suggested by Greg KH, add commit message.
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 42fc47c6edfd..80fc5f050f28 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18222,6 +18222,7 @@ L:	rust-for-linux@vger.kernel.org
 S:	Supported
 W:	https://github.com/Rust-for-Linux/linux
 B:	https://github.com/Rust-for-Linux/linux/issues
+C:	zulip://rust-for-linux.zulipchat.com
 T:	git https://github.com/Rust-for-Linux/linux.git rust-next
 F:	Documentation/rust/
 F:	rust/
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] rust: MAINTAINERS: Add the zulip link
  2023-02-01 18:45   ` [PATCH v3] " Boqun Feng
@ 2023-02-01 22:50     ` Miguel Ojeda
  2023-02-02  7:27     ` Vincenzo Palazzo
  1 sibling, 0 replies; 7+ messages in thread
From: Miguel Ojeda @ 2023-02-01 22:50 UTC (permalink / raw)
  To: Boqun Feng, Vincenzo Palazzo
  Cc: rust-for-linux, Greg KH, Miguel Ojeda, Alex Gaynor,
	Wedson Almeida Filho, Gary Guo, Björn Roy Baron,
	linux-kernel

On Wed, Feb 1, 2023 at 7:46 PM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> Zulip organization "rust-for-linux" was created 2 years ago[1] and has
> proven to be a great place for Rust related discussion, therefore
> add the information in MAINTAINERS file so that newcomers have more
> options to find guide and help.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/ [1]
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>

Applied to rust-next, thanks Boqun!

(Vincenzo: if you would like me to apply your tag to v3, please let me know.)

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v3] rust: MAINTAINERS: Add the zulip link
  2023-02-01 18:45   ` [PATCH v3] " Boqun Feng
  2023-02-01 22:50     ` Miguel Ojeda
@ 2023-02-02  7:27     ` Vincenzo Palazzo
  1 sibling, 0 replies; 7+ messages in thread
From: Vincenzo Palazzo @ 2023-02-02  7:27 UTC (permalink / raw)
  To: Boqun Feng, rust-for-linux
  Cc: Greg KH, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho,
	Gary Guo, Björn Roy Baron, linux-kernel

On Wed Feb 1, 2023 at 7:45 PM CET, Boqun Feng wrote:
> Zulip organization "rust-for-linux" was created 2 years ago[1] and has
> proven to be a great place for Rust related discussion, therefore
> add the information in MAINTAINERS file so that newcomers have more
> options to find guide and help.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/ [1]
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>


> v2 -> v3:
>
> 	*	Commit message improvement per Miguel.
> 	*	Reorder the line after "B:" as suggested by Miguel.
>
> v1 -> v2:
>
> 	* 	As suggested by Greg KH, add commit message.
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42fc47c6edfd..80fc5f050f28 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18222,6 +18222,7 @@ L:	rust-for-linux@vger.kernel.org
>  S:	Supported
>  W:	https://github.com/Rust-for-Linux/linux
>  B:	https://github.com/Rust-for-Linux/linux/issues
> +C:	zulip://rust-for-linux.zulipchat.com
>  T:	git https://github.com/Rust-for-Linux/linux.git rust-next
>  F:	Documentation/rust/
>  F:	rust/
> -- 
> 2.39.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2] rust: MAINTAINERS: Add the zulip link
  2023-01-28  7:22 [PATCH v2] rust: MAINTAINERS: Add the zulip link Boqun Feng
  2023-01-28 10:29 ` Vincenzo Palazzo
  2023-02-01  1:38 ` Miguel Ojeda
@ 2023-02-02  8:45 ` Alice Ferrazzi
  2 siblings, 0 replies; 7+ messages in thread
From: Alice Ferrazzi @ 2023-02-02  8:45 UTC (permalink / raw)
  To: Boqun Feng
  Cc: rust-for-linux, Greg KH, Miguel Ojeda, Alex Gaynor,
	Wedson Almeida Filho, Gary Guo, Björn Roy Baron,
	linux-kernel

On Sat, Jan 28, 2023 at 4:23 PM Boqun Feng <boqun.feng@gmail.com> wrote:
>
> Zulip organization "rust-for-linux" has been created since about 2 years
> ago[1], and proven to be a great place for Rust related discussion,
> therefore add the information in MAINTAINERS file so that newcomers have
> more options to find guide and help.
>
> [1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/
>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
> v1 -> v2:
>
>         *       As suggested by Greg KH, add commit message.
>
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42fc47c6edfd..30161207f365 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18219,6 +18219,7 @@ R:      Boqun Feng <boqun.feng@gmail.com>
>  R:     Gary Guo <gary@garyguo.net>
>  R:     Björn Roy Baron <bjorn3_gh@protonmail.com>
>  L:     rust-for-linux@vger.kernel.org
> +C:     zulip://rust-for-linux.zulipchat.com
>  S:     Supported
>  W:     https://github.com/Rust-for-Linux/linux
>  B:     https://github.com/Rust-for-Linux/linux/issues
> --
> 2.39.1
>

Looks ok also for me to try out the zulip:// URI scheme.

Reviewed-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>

-- 
======================================
Cybertrust Japan Co.,Ltd.
Alice Ferrazzi
alice.ferrazzi@miraclelinux.com
======================================

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-02-02  8:46 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28  7:22 [PATCH v2] rust: MAINTAINERS: Add the zulip link Boqun Feng
2023-01-28 10:29 ` Vincenzo Palazzo
2023-02-01  1:38 ` Miguel Ojeda
2023-02-01 18:45   ` [PATCH v3] " Boqun Feng
2023-02-01 22:50     ` Miguel Ojeda
2023-02-02  7:27     ` Vincenzo Palazzo
2023-02-02  8:45 ` [PATCH v2] " Alice Ferrazzi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).