* [PATCH 1/1] netvsc: Deal with rescinded channels correctly
@ 2017-04-19 20:49 kys
2017-04-19 20:52 ` KY Srinivasan
0 siblings, 1 reply; 2+ messages in thread
From: kys @ 2017-04-19 20:49 UTC (permalink / raw)
To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
Cc: K. Y. Srinivasan
From: K. Y. Srinivasan <kys@microsoft.com>
We will not be able to send packets over a channel that has been
rescinded. Make necessary adjustments so we can properly cleanup
even when the channel is rescinded. This issue can be trigerred
in the NIC hot-remove path.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/net/hyperv/netvsc.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
index 7ab06b3..b5b10fc 100644
--- a/drivers/net/hyperv/netvsc.c
+++ b/drivers/net/hyperv/netvsc.c
@@ -135,6 +135,13 @@ static void netvsc_destroy_buf(struct hv_device *device)
sizeof(struct nvsp_message),
(unsigned long)revoke_packet,
VM_PKT_DATA_INBAND, 0);
+ /* If the failure is because the channel is rescinded;
+ * ignore the failure since we cannot send on a rescinded
+ * channel. This would allow us to properly cleanup
+ * even when the channel is rescinded.
+ */
+ if (device->channel->rescind)
+ ret = 0;
/*
* If we failed here, we might as well return and
* have a leak rather than continue and a bugchk
@@ -195,6 +202,15 @@ static void netvsc_destroy_buf(struct hv_device *device)
sizeof(struct nvsp_message),
(unsigned long)revoke_packet,
VM_PKT_DATA_INBAND, 0);
+
+ /* If the failure is because the channel is rescinded;
+ * ignore the failure since we cannot send on a rescinded
+ * channel. This would allow us to properly cleanup
+ * even when the channel is rescinded.
+ */
+ if (device->channel->rescind)
+ ret = 0;
+
/* If we failed here, we might as well return and
* have a leak rather than continue and a bugchk
*/
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 1/1] netvsc: Deal with rescinded channels correctly
2017-04-19 20:49 [PATCH 1/1] netvsc: Deal with rescinded channels correctly kys
@ 2017-04-19 20:52 ` KY Srinivasan
0 siblings, 0 replies; 2+ messages in thread
From: KY Srinivasan @ 2017-04-19 20:52 UTC (permalink / raw)
To: KY Srinivasan, davem, netdev, linux-kernel, devel, olaf, apw,
jasowang, leann.ogasawara, marcelo.cerri, Stephen Hemminger
> -----Original Message-----
> From: kys@exchange.microsoft.com [mailto:kys@exchange.microsoft.com]
> Sent: Wednesday, April 19, 2017 1:49 PM
> To: davem@davemloft.net; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; devel@linuxdriverproject.org; olaf@aepfle.de;
> apw@canonical.com; jasowang@redhat.com;
> leann.ogasawara@canonical.comi; marcelo.cerri@canonical.com; Stephen
> Hemminger <sthemmin@microsoft.com>
> Cc: KY Srinivasan <kys@microsoft.com>
> Subject: [PATCH 1/1] netvsc: Deal with rescinded channels correctly
>
> [This sender failed our fraud detection checks and may not be who they
> appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing]
>
> From: K. Y. Srinivasan <kys@microsoft.com>
>
> We will not be able to send packets over a channel that has been
> rescinded. Make necessary adjustments so we can properly cleanup
> even when the channel is rescinded. This issue can be trigerred
> in the NIC hot-remove path.
>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Dave,
Please drop this path; I will resend.
K. Y
> ---
> drivers/net/hyperv/netvsc.c | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/hyperv/netvsc.c b/drivers/net/hyperv/netvsc.c
> index 7ab06b3..b5b10fc 100644
> --- a/drivers/net/hyperv/netvsc.c
> +++ b/drivers/net/hyperv/netvsc.c
> @@ -135,6 +135,13 @@ static void netvsc_destroy_buf(struct hv_device
> *device)
> sizeof(struct nvsp_message),
> (unsigned long)revoke_packet,
> VM_PKT_DATA_INBAND, 0);
> + /* If the failure is because the channel is rescinded;
> + * ignore the failure since we cannot send on a rescinded
> + * channel. This would allow us to properly cleanup
> + * even when the channel is rescinded.
> + */
> + if (device->channel->rescind)
> + ret = 0;
> /*
> * If we failed here, we might as well return and
> * have a leak rather than continue and a bugchk
> @@ -195,6 +202,15 @@ static void netvsc_destroy_buf(struct hv_device
> *device)
> sizeof(struct nvsp_message),
> (unsigned long)revoke_packet,
> VM_PKT_DATA_INBAND, 0);
> +
> + /* If the failure is because the channel is rescinded;
> + * ignore the failure since we cannot send on a rescinded
> + * channel. This would allow us to properly cleanup
> + * even when the channel is rescinded.
> + */
> + if (device->channel->rescind)
> + ret = 0;
> +
> /* If we failed here, we might as well return and
> * have a leak rather than continue and a bugchk
> */
> --
> 1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-19 20:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 20:49 [PATCH 1/1] netvsc: Deal with rescinded channels correctly kys
2017-04-19 20:52 ` KY Srinivasan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).