* [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int
@ 2017-02-28 11:02 Colin King
2017-02-28 11:29 ` Rangankar, Manish
2017-03-01 2:56 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-02-28 11:02 UTC (permalink / raw)
To: QLogic-Storage-Upstream, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The call to qedi_setup_int is not updating the return code rc yet rc
is being checked for an error. Fix this by assigning rc to the return
code from the call to qedi_setup_int.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/qedi/qedi_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 5eda21d..8e3d928 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1805,7 +1805,7 @@ static int __qedi_probe(struct pci_dev *pdev, int mode)
*/
qedi_ops->common->update_pf_params(qedi->cdev, &qedi->pf_params);
- qedi_setup_int(qedi);
+ rc = qedi_setup_int(qedi);
if (rc)
goto stop_iscsi_func;
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int
2017-02-28 11:02 [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int Colin King
@ 2017-02-28 11:29 ` Rangankar, Manish
2017-03-01 2:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Rangankar, Manish @ 2017-02-28 11:29 UTC (permalink / raw)
To: Colin King, Dept-Eng QLogic Storage Upstream,
James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
On 28/02/17 4:32 PM, "Colin King" <colin.king@canonical.com> wrote:
>From: Colin Ian King <colin.king@canonical.com>
>
>The call to qedi_setup_int is not updating the return code rc yet rc
>is being checked for an error. Fix this by assigning rc to the return
>code from the call to qedi_setup_int.
>
>Signed-off-by: Colin Ian King <colin.king@canonical.com>
>---
> drivers/scsi/qedi/qedi_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
>index 5eda21d..8e3d928 100644
>--- a/drivers/scsi/qedi/qedi_main.c
>+++ b/drivers/scsi/qedi/qedi_main.c
>@@ -1805,7 +1805,7 @@ static int __qedi_probe(struct pci_dev *pdev, int
>mode)
> */
> qedi_ops->common->update_pf_params(qedi->cdev, &qedi->pf_params);
>
>- qedi_setup_int(qedi);
>+ rc = qedi_setup_int(qedi);
> if (rc)
> goto stop_iscsi_func;
>
>--
>2.10.2
>
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int
2017-02-28 11:02 [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int Colin King
2017-02-28 11:29 ` Rangankar, Manish
@ 2017-03-01 2:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-03-01 2:56 UTC (permalink / raw)
To: Colin King
Cc: QLogic-Storage-Upstream, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin> The call to qedi_setup_int is not updating the return code rc yet
Colin> rc is being checked for an error. Fix this by assigning rc to the
Colin> return code from the call to qedi_setup_int.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-01 3:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-28 11:02 [PATCH] scsi: qedi: fix missing return error code check on call to qedi_setup_int Colin King
2017-02-28 11:29 ` Rangankar, Manish
2017-03-01 2:56 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).