* [PATCH] fs/ntfs: remove redundant variable idx
@ 2022-05-17 9:36 Colin Ian King
2022-05-17 9:36 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2022-05-17 9:36 UTC (permalink / raw)
To: Anton Altaparmakov, linux-ntfs-dev; +Cc: kernel-janitors, linux-kernel
The variable idx is assigned a value and is never read. The variable
is not used and is redundant, remove it.
Cleans up clang scan build warning:
warning: Although the value stored to 'idx' is used in the enclosing
expression, the value is never actually read from 'idx'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ntfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index e1392a9b8ceb..a8abe2296514 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
last_vcn = -1;
do {
VCN vcn;
- pgoff_t idx, start_idx;
+ pgoff_t start_idx;
unsigned ofs, do_pages, u;
size_t copied;
- start_idx = idx = pos >> PAGE_SHIFT;
+ start_idx = pos >> PAGE_SHIFT;
ofs = pos & ~PAGE_MASK;
bytes = PAGE_SIZE - ofs;
do_pages = 1;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] fs/ntfs: remove redundant variable idx
2022-05-17 9:36 [PATCH] fs/ntfs: remove redundant variable idx Colin Ian King
@ 2022-05-17 9:36 ` Colin Ian King
2022-05-17 12:09 ` Anton Altaparmakov
0 siblings, 1 reply; 3+ messages in thread
From: Colin Ian King @ 2022-05-17 9:36 UTC (permalink / raw)
To: Anton Altaparmakov, linux-ntfs-dev; +Cc: kernel-janitors, linux-kernel
The variable idx is assigned a value and is never read. The variable
is not used and is redundant, remove it.
Cleans up clang scan build warning:
warning: Although the value stored to 'idx' is used in the enclosing
expression, the value is never actually read from 'idx'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ntfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index e1392a9b8ceb..a8abe2296514 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
last_vcn = -1;
do {
VCN vcn;
- pgoff_t idx, start_idx;
+ pgoff_t start_idx;
unsigned ofs, do_pages, u;
size_t copied;
- start_idx = idx = pos >> PAGE_SHIFT;
+ start_idx = pos >> PAGE_SHIFT;
ofs = pos & ~PAGE_MASK;
bytes = PAGE_SIZE - ofs;
do_pages = 1;
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs/ntfs: remove redundant variable idx
2022-05-17 9:36 ` Colin Ian King
@ 2022-05-17 12:09 ` Anton Altaparmakov
0 siblings, 0 replies; 3+ messages in thread
From: Anton Altaparmakov @ 2022-05-17 12:09 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-ntfs-dev, kernel-janitors, Linux Kernel Mailing List,
Colin Ian King
Hi Andrew,
Please could you merge this? Thanks a lot!
Best regards,
Anton
> On 17 May 2022, at 10:36, Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The variable idx is assigned a value and is never read. The variable
> is not used and is redundant, remove it.
>
> Cleans up clang scan build warning:
> warning: Although the value stored to 'idx' is used in the enclosing
> expression, the value is never actually read from 'idx'
> [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Anton Altaparmakov <anton@tuxera.com>
> ---
> fs/ntfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
> index e1392a9b8ceb..a8abe2296514 100644
> --- a/fs/ntfs/file.c
> +++ b/fs/ntfs/file.c
> @@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i,
> last_vcn = -1;
> do {
> VCN vcn;
> - pgoff_t idx, start_idx;
> + pgoff_t start_idx;
> unsigned ofs, do_pages, u;
> size_t copied;
>
> - start_idx = idx = pos >> PAGE_SHIFT;
> + start_idx = pos >> PAGE_SHIFT;
> ofs = pos & ~PAGE_MASK;
> bytes = PAGE_SIZE - ofs;
> do_pages = 1;
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-17 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-17 9:36 [PATCH] fs/ntfs: remove redundant variable idx Colin Ian King
2022-05-17 9:36 ` Colin Ian King
2022-05-17 12:09 ` Anton Altaparmakov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).