* Re: [PATCH] arm64: dts: imx8mn-ddr4-evk: Enable GPIO LED
2019-09-02 20:45 [PATCH] arm64: dts: imx8mn-ddr4-evk: Enable GPIO LED Anson Huang
@ 2019-09-02 20:31 ` Pavel Machek
2019-09-03 1:30 ` Anson Huang
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Machek @ 2019-09-02 20:31 UTC (permalink / raw)
To: Anson Huang
Cc: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, linux-arm-kernel, linux-kernel, Linux-imx
On Mon 2019-09-02 16:45:38, Anson Huang wrote:
> i.MX8MN DDR4 EVK board has a GPIO LED to indicate status,
> add support for it.
LED maintainers want to be on the cc list...
> @@ -15,6 +15,18 @@
> stdout-path = &uart2;
> };
>
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_led>;
> +
> + status {
> + label = "status";
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
And we should really standardize labels for user-controlled status LEDs. Mentioning
color would be nice, for a start.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: dts: imx8mn-ddr4-evk: Enable GPIO LED
@ 2019-09-02 20:45 Anson Huang
2019-09-02 20:31 ` Pavel Machek
0 siblings, 1 reply; 3+ messages in thread
From: Anson Huang @ 2019-09-02 20:45 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, linux-arm-kernel, linux-kernel
Cc: Linux-imx
i.MX8MN DDR4 EVK board has a GPIO LED to indicate status,
add support for it.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
index b698061..9349bad 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mn-ddr4-evk.dts
@@ -15,6 +15,18 @@
stdout-path = &uart2;
};
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_gpio_led>;
+
+ status {
+ label = "status";
+ gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
+ default-state = "on";
+ };
+ };
+
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -54,6 +66,12 @@
>;
};
+ pinctrl_gpio_led: gpioledgrp {
+ fsl,pins = <
+ MX8MN_IOMUXC_NAND_READY_B_GPIO3_IO16 0x19
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX8MN_IOMUXC_I2C1_SCL_I2C1_SCL 0x400001c3
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] arm64: dts: imx8mn-ddr4-evk: Enable GPIO LED
2019-09-02 20:31 ` Pavel Machek
@ 2019-09-03 1:30 ` Anson Huang
0 siblings, 0 replies; 3+ messages in thread
From: Anson Huang @ 2019-09-03 1:30 UTC (permalink / raw)
To: Pavel Machek
Cc: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
devicetree, linux-arm-kernel, linux-kernel, dl-linux-imx
Hi, Pavel
> On Mon 2019-09-02 16:45:38, Anson Huang wrote:
> > i.MX8MN DDR4 EVK board has a GPIO LED to indicate status, add support
> > for it.
>
> LED maintainers want to be on the cc list...
The get_maintainer.pl does NOT show the LED maintainers...But I have added it
in V2.
>
> > @@ -15,6 +15,18 @@
> > stdout-path = &uart2;
> > };
> >
> > + leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_gpio_led>;
> > +
> > + status {
> > + label = "status";
> > + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> > + default-state = "on";
> > + };
>
> And we should really standardize labels for user-controlled status LEDs.
> Mentioning color would be nice, for a start.
OK, I change the label to "yellow:status" in V2, please help review, thanks.
Anson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-03 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 20:45 [PATCH] arm64: dts: imx8mn-ddr4-evk: Enable GPIO LED Anson Huang
2019-09-02 20:31 ` Pavel Machek
2019-09-03 1:30 ` Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).