* [PATCH v4 1/3] USB3/DWC3: Add definition for global soc bus configuration register @ 2017-01-18 8:12 Changming Huang 2017-01-18 8:12 ` [PATCH v4 2/3] USB3/DWC3: Add property "snps,incr-burst-type-adjustment" for INCR burst type Changming Huang 2017-01-18 8:12 ` [PATCH v4 3/3] USB3/DWC3: Enable undefined length " Changming Huang 0 siblings, 2 replies; 10+ messages in thread From: Changming Huang @ 2017-01-18 8:12 UTC (permalink / raw) To: balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Changming Huang Add the macro definition for global soc bus configuration register 0/1 Signed-off-by: Changming Huang <jerry.huang@nxp.com> --- Changes in v4: - no change Changes in v3: - no change Changes in v2: - split the patch - add more macro definition for soc bus configuration register drivers/usb/dwc3/core.h | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index de5a857..065aa6f 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -161,6 +161,32 @@ /* Bit fields */ +/* Global SoC Bus Configuration Register 0 */ +#define AXI3_CACHE_TYPE_AW 0x8 /* write allocate */ +#define AXI3_CACHE_TYPE_AR 0x4 /* read allocate */ +#define AXI3_CACHE_TYPE_SNP 0x2 /* cacheable */ +#define AXI3_CACHE_TYPE_BUF 0x1 /* bufferable */ +#define DWC3_GSBUSCFG0_DATARD_SHIFT 28 +#define DWC3_GSBUSCFG0_DESCRD_SHIFT 24 +#define DWC3_GSBUSCFG0_DATAWR_SHIFT 20 +#define DWC3_GSBUSCFG0_DESCWR_SHIFT 16 +#define DWC3_GSBUSCFG0_SNP_MASK 0xffff0000 +#define DWC3_GSBUSCFG0_DATABIGEND (1 << 11) +#define DWC3_GSBUSCFG0_DESCBIGEND (1 << 10) +#define DWC3_GSBUSCFG0_INCR256BRSTENA (1 << 7) /* INCR256 burst */ +#define DWC3_GSBUSCFG0_INCR128BRSTENA (1 << 6) /* INCR128 burst */ +#define DWC3_GSBUSCFG0_INCR64BRSTENA (1 << 5) /* INCR64 burst */ +#define DWC3_GSBUSCFG0_INCR32BRSTENA (1 << 4) /* INCR32 burst */ +#define DWC3_GSBUSCFG0_INCR16BRSTENA (1 << 3) /* INCR16 burst */ +#define DWC3_GSBUSCFG0_INCR8BRSTENA (1 << 2) /* INCR8 burst */ +#define DWC3_GSBUSCFG0_INCR4BRSTENA (1 << 1) /* INCR4 burst */ +#define DWC3_GSBUSCFG0_INCRBRSTENA (1 << 0) /* undefined length enable */ +#define DWC3_GSBUSCFG0_INCRBRST_MASK 0xff + +/* Global SoC Bus Configuration Register 1 */ +#define DWC3_GSBUSCFG1_1KPAGEENA (1 << 12) /* 1K page boundary enable */ +#define DWC3_GSBUSCFG1_PTRANSLIMIT_MASK 0xf00 + /* Global Debug Queue/FIFO Space Available Register */ #define DWC3_GDBGFIFOSPACE_NUM(n) ((n) & 0x1f) #define DWC3_GDBGFIFOSPACE_TYPE(n) (((n) << 5) & 0x1e0) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 2/3] USB3/DWC3: Add property "snps,incr-burst-type-adjustment" for INCR burst type 2017-01-18 8:12 [PATCH v4 1/3] USB3/DWC3: Add definition for global soc bus configuration register Changming Huang @ 2017-01-18 8:12 ` Changming Huang 2017-01-18 8:12 ` [PATCH v4 3/3] USB3/DWC3: Enable undefined length " Changming Huang 1 sibling, 0 replies; 10+ messages in thread From: Changming Huang @ 2017-01-18 8:12 UTC (permalink / raw) To: balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Changming Huang Property "snps,incr-burst-type-adjustment = <x>, <y>..." for USB3.0 DWC3. When Just one value means INCRx mode with fix burst type. When more than one value, means undefined length burst mode, USB controller can use the length less than or equal to the largest enabled burst length. While enabling undefined length INCR burst type and INCR16 burst type, get better write performance on NXP Layerscape platform: around 3% improvement (from 364MB/s to 375MB/s). Signed-off-by: Changming Huang <jerry.huang@nxp.com> --- Changes in v4: - change definition for this property. Changes in v3: - add new property for INCR burst in usb node. Documentation/devicetree/bindings/usb/dwc3.txt | 6 ++++++ arch/arm/boot/dts/ls1021a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 3 +++ arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 2 ++ 4 files changed, 12 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt index e3e6983..a68dbfc 100644 --- a/Documentation/devicetree/bindings/usb/dwc3.txt +++ b/Documentation/devicetree/bindings/usb/dwc3.txt @@ -55,6 +55,11 @@ Optional properties: fladj_30mhz_sdbnd signal is invalid or incorrect. - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated. + - snps,incr-burst-type-adjustment: Value for INCR burst type of GSBUSCFG0 + register, undefined length INCR burst type enable and INCRx type. + When just one value, which means INCRX burst mode. When more than one + value, which means undefined length INCR burst type enabled. + The values can be 1, 4, 8, 16, 32, 64, 128 and 256. This is usually a subnode to DWC3 glue to which it is connected. @@ -63,4 +68,5 @@ dwc3@4a030000 { reg = <0x4a030000 0xcfff>; interrupts = <0 92 4> usb-phy = <&usb2_phy>, <&usb3,phy>; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 368e219..6eee0d5 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -627,6 +627,7 @@ dr_mode = "host"; snps,quirk-frame-length-adjustment = <0x20>; snps,dis_rxdet_inp3_quirk; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; pcie@3400000 { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index 97d331e..04ffd66 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -482,6 +482,7 @@ dr_mode = "host"; snps,quirk-frame-length-adjustment = <0x20>; snps,dis_rxdet_inp3_quirk; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; usb1: usb3@3000000 { @@ -491,6 +492,7 @@ dr_mode = "host"; snps,quirk-frame-length-adjustment = <0x20>; snps,dis_rxdet_inp3_quirk; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; usb2: usb3@3100000 { @@ -500,6 +502,7 @@ dr_mode = "host"; snps,quirk-frame-length-adjustment = <0x20>; snps,dis_rxdet_inp3_quirk; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; sata: sata@3200000 { diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi index d058e56..902cc93 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi @@ -710,6 +710,7 @@ dr_mode = "host"; snps,quirk-frame-length-adjustment = <0x20>; snps,dis_rxdet_inp3_quirk; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; usb1: usb3@3110000 { @@ -720,6 +721,7 @@ dr_mode = "host"; snps,quirk-frame-length-adjustment = <0x20>; snps,dis_rxdet_inp3_quirk; + snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>; }; ccn@4000000 { -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-01-18 8:12 [PATCH v4 1/3] USB3/DWC3: Add definition for global soc bus configuration register Changming Huang 2017-01-18 8:12 ` [PATCH v4 2/3] USB3/DWC3: Add property "snps,incr-burst-type-adjustment" for INCR burst type Changming Huang @ 2017-01-18 8:12 ` Changming Huang 2017-02-10 7:45 ` Jerry Huang 1 sibling, 1 reply; 10+ messages in thread From: Changming Huang @ 2017-01-18 8:12 UTC (permalink / raw) To: balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Changming Huang, Rajesh Bhagat Enable the undefined length INCR burst type and set INCRx. Different platform may has the different burst size type. In order to get best performance, we need to tune the burst size to one special value, instead of the default value. Signed-off-by: Changming Huang <jerry.huang@nxp.com> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> --- Changes in v4: - Modify the codes according to the definition of this property. Changes in v3: - add new property for INCR burst in usb node to reset GSBUSCFG0. Changes in v2: - split patch - create one new function to handle soc bus configuration register. drivers/usb/dwc3/core.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++ drivers/usb/dwc3/core.h | 7 ++++ 2 files changed, 90 insertions(+) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 369bab1..446aec3 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -650,6 +650,87 @@ static void dwc3_core_setup_global_control(struct dwc3 *dwc) dwc3_writel(dwc->regs, DWC3_GCTL, reg); } +/* set global soc bus configuration registers */ +static void dwc3_set_soc_bus_cfg(struct dwc3 *dwc) +{ + struct device *dev = dwc->dev; + u32 *vals; + u32 cfg; + int ntype; + int ret; + int i; + + cfg = dwc3_readl(dwc->regs, DWC3_GSBUSCFG0); + + /* + * Handle property "snps,incr-burst-type-adjustment". + * Get the number of value from this property: + * result <= 0, means this property is not supported. + * result = 1, means INCRx burst mode supported. + * result > 1, means undefined length burst mode supported. + */ + ntype = device_property_read_u32_array(dev, + "snps,incr-burst-type-adjustment", NULL, 0); + if (ntype > 0) { + vals = kcalloc(ntype, sizeof(u32), GFP_KERNEL); + if (!vals) { + dev_err(dev, "Error to get memory\n"); + return; + } + /* Get INCR burst type, and parse it */ + ret = device_property_read_u32_array(dev, + "snps,incr-burst-type-adjustment", vals, ntype); + if (ret) { + dev_err(dev, "Error to get property\n"); + return; + } + *(dwc->incrx_type + 1) = vals[0]; + if (ntype > 1) { + *dwc->incrx_type = 1; + for (i = 1; i < ntype; i++) { + if (vals[i] > *(dwc->incrx_type + 1)) + *(dwc->incrx_type + 1) = vals[i]; + } + } else + *dwc->incrx_type = 0; + + /* Enable Undefined Length INCR Burst and Enable INCRx Burst */ + cfg &= ~DWC3_GSBUSCFG0_INCRBRST_MASK; + if (*dwc->incrx_type) + cfg |= DWC3_GSBUSCFG0_INCRBRSTENA; + switch (*(dwc->incrx_type + 1)) { + case 256: + cfg |= DWC3_GSBUSCFG0_INCR256BRSTENA; + break; + case 128: + cfg |= DWC3_GSBUSCFG0_INCR128BRSTENA; + break; + case 64: + cfg |= DWC3_GSBUSCFG0_INCR64BRSTENA; + break; + case 32: + cfg |= DWC3_GSBUSCFG0_INCR32BRSTENA; + break; + case 16: + cfg |= DWC3_GSBUSCFG0_INCR16BRSTENA; + break; + case 8: + cfg |= DWC3_GSBUSCFG0_INCR8BRSTENA; + break; + case 4: + cfg |= DWC3_GSBUSCFG0_INCR4BRSTENA; + break; + case 1: + break; + default: + dev_err(dev, "Invalid property\n"); + break; + } + } + + dwc3_writel(dwc->regs, DWC3_GSBUSCFG0, cfg); +} + /** * dwc3_core_init - Low-level initialization of DWC3 Core * @dwc: Pointer to our controller context structure @@ -698,6 +779,8 @@ static int dwc3_core_init(struct dwc3 *dwc) /* Adjust Frame Length */ dwc3_frame_length_adjustment(dwc); + dwc3_set_soc_bus_cfg(dwc); + usb_phy_set_suspend(dwc->usb2_phy, 0); usb_phy_set_suspend(dwc->usb3_phy, 0); ret = phy_power_on(dwc->usb2_generic_phy); diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index 065aa6f..9df6304 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -805,6 +805,7 @@ struct dwc3_scratchpad_array { * @regs: base address for our registers * @regs_size: address space size * @fladj: frame length adjustment + * @incrx_type: INCR burst type adjustment * @irq_gadget: peripheral controller's IRQ number * @nr_scratch: number of scratch buffers * @u1u2: only used on revisions <1.83a for workaround @@ -928,6 +929,12 @@ struct dwc3 { enum usb_phy_interface hsphy_mode; u32 fladj; + /* + * For INCR burst type. + * First field: for undefined length INCR burst type enable. + * Second field: for INCRx burst type enable + */ + u32 incrx_type[2]; u32 irq_gadget; u32 nr_scratch; u32 u1u2; -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-01-18 8:12 ` [PATCH v4 3/3] USB3/DWC3: Enable undefined length " Changming Huang @ 2017-02-10 7:45 ` Jerry Huang 2017-02-10 8:44 ` Felipe Balbi 0 siblings, 1 reply; 10+ messages in thread From: Jerry Huang @ 2017-02-10 7:45 UTC (permalink / raw) To: Jerry Huang, balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat > -----Original Message----- > From: Changming Huang [mailto:jerry.huang@nxp.com] > Sent: Wednesday, January 18, 2017 4:12 PM > To: balbi@kernel.org; robh+dt@kernel.org; mark.rutland@arm.com; > catalin.marinas@arm.com > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Jerry > Huang <jerry.huang@nxp.com>; Rajesh Bhagat <rajesh.bhagat@nxp.com> > Subject: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst > type > > Enable the undefined length INCR burst type and set INCRx. > Different platform may has the different burst size type. > In order to get best performance, we need to tune the burst size to one > special value, instead of the default value. > > Signed-off-by: Changming Huang <jerry.huang@nxp.com> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> > --- > Changes in v4: > - Modify the codes according to the definition of this property. > Changes in v3: > - add new property for INCR burst in usb node to reset GSBUSCFG0. > Changes in v2: > - split patch > - create one new function to handle soc bus configuration register. > > drivers/usb/dwc3/core.c | 83 > +++++++++++++++++++++++++++++++++++++++++++++++ > drivers/usb/dwc3/core.h | 7 ++++ > 2 files changed, 90 insertions(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index > 369bab1..446aec3 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -650,6 +650,87 @@ static void dwc3_core_setup_global_control(struct > dwc3 *dwc) > dwc3_writel(dwc->regs, DWC3_GCTL, reg); } > > +/* set global soc bus configuration registers */ static void > +dwc3_set_soc_bus_cfg(struct dwc3 *dwc) { > + struct device *dev = dwc->dev; > + u32 *vals; > + u32 cfg; > + int ntype; > + int ret; > + int i; > + > + cfg = dwc3_readl(dwc->regs, DWC3_GSBUSCFG0); > + > + /* > + * Handle property "snps,incr-burst-type-adjustment". > + * Get the number of value from this property: > + * result <= 0, means this property is not supported. > + * result = 1, means INCRx burst mode supported. > + * result > 1, means undefined length burst mode supported. > + */ > + ntype = device_property_read_u32_array(dev, > + "snps,incr-burst-type-adjustment", NULL, 0); > + if (ntype > 0) { > + vals = kcalloc(ntype, sizeof(u32), GFP_KERNEL); > + if (!vals) { > + dev_err(dev, "Error to get memory\n"); > + return; > + } > + /* Get INCR burst type, and parse it */ > + ret = device_property_read_u32_array(dev, > + "snps,incr-burst-type-adjustment", vals, ntype); > + if (ret) { > + dev_err(dev, "Error to get property\n"); > + return; > + } > + *(dwc->incrx_type + 1) = vals[0]; > + if (ntype > 1) { > + *dwc->incrx_type = 1; > + for (i = 1; i < ntype; i++) { > + if (vals[i] > *(dwc->incrx_type + 1)) > + *(dwc->incrx_type + 1) = vals[i]; > + } > + } else > + *dwc->incrx_type = 0; > + > + /* Enable Undefined Length INCR Burst and Enable INCRx > Burst */ > + cfg &= ~DWC3_GSBUSCFG0_INCRBRST_MASK; > + if (*dwc->incrx_type) > + cfg |= DWC3_GSBUSCFG0_INCRBRSTENA; > + switch (*(dwc->incrx_type + 1)) { > + case 256: > + cfg |= DWC3_GSBUSCFG0_INCR256BRSTENA; > + break; > + case 128: > + cfg |= DWC3_GSBUSCFG0_INCR128BRSTENA; > + break; > + case 64: > + cfg |= DWC3_GSBUSCFG0_INCR64BRSTENA; > + break; > + case 32: > + cfg |= DWC3_GSBUSCFG0_INCR32BRSTENA; > + break; > + case 16: > + cfg |= DWC3_GSBUSCFG0_INCR16BRSTENA; > + break; > + case 8: > + cfg |= DWC3_GSBUSCFG0_INCR8BRSTENA; > + break; > + case 4: > + cfg |= DWC3_GSBUSCFG0_INCR4BRSTENA; > + break; > + case 1: > + break; > + default: > + dev_err(dev, "Invalid property\n"); > + break; > + } > + } > + > + dwc3_writel(dwc->regs, DWC3_GSBUSCFG0, cfg); } > + > /** > * dwc3_core_init - Low-level initialization of DWC3 Core > * @dwc: Pointer to our controller context structure @@ -698,6 +779,8 @@ > static int dwc3_core_init(struct dwc3 *dwc) > /* Adjust Frame Length */ > dwc3_frame_length_adjustment(dwc); > > + dwc3_set_soc_bus_cfg(dwc); > + > usb_phy_set_suspend(dwc->usb2_phy, 0); > usb_phy_set_suspend(dwc->usb3_phy, 0); > ret = phy_power_on(dwc->usb2_generic_phy); > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index > 065aa6f..9df6304 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -805,6 +805,7 @@ struct dwc3_scratchpad_array { > * @regs: base address for our registers > * @regs_size: address space size > * @fladj: frame length adjustment > + * @incrx_type: INCR burst type adjustment > * @irq_gadget: peripheral controller's IRQ number > * @nr_scratch: number of scratch buffers > * @u1u2: only used on revisions <1.83a for workaround @@ -928,6 +929,12 > @@ struct dwc3 { > enum usb_phy_interface hsphy_mode; > > u32 fladj; > + /* > + * For INCR burst type. > + * First field: for undefined length INCR burst type enable. > + * Second field: for INCRx burst type enable > + */ > + u32 incrx_type[2]; > u32 irq_gadget; > u32 nr_scratch; > u32 u1u2; > -- > 1.7.9.5 Hi, Balbi and all guys, Any comment for these patches? Can they be accepted? ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-02-10 7:45 ` Jerry Huang @ 2017-02-10 8:44 ` Felipe Balbi 2017-02-10 15:30 ` Jerry Huang 2017-02-20 8:39 ` Jerry Huang 0 siblings, 2 replies; 10+ messages in thread From: Felipe Balbi @ 2017-02-10 8:44 UTC (permalink / raw) To: Jerry Huang, Jerry Huang, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat [-- Attachment #1: Type: text/plain, Size: 599 bytes --] Hi, Jerry Huang <jerry.huang@nxp.com> writes: >> @@ struct dwc3 { >> enum usb_phy_interface hsphy_mode; >> >> u32 fladj; >> + /* >> + * For INCR burst type. >> + * First field: for undefined length INCR burst type enable. >> + * Second field: for INCRx burst type enable >> + */ >> + u32 incrx_type[2]; >> u32 irq_gadget; >> u32 nr_scratch; >> u32 u1u2; >> -- >> 1.7.9.5 > Hi, Balbi and all guys, > Any comment for these patches? Can they be accepted? Rob had comments which you didn't reply yet. I cannot take this patchset yet ;-) -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-02-10 8:44 ` Felipe Balbi @ 2017-02-10 15:30 ` Jerry Huang 2017-03-10 11:26 ` Felipe Balbi 2017-02-20 8:39 ` Jerry Huang 1 sibling, 1 reply; 10+ messages in thread From: Jerry Huang @ 2017-02-10 15:30 UTC (permalink / raw) To: Felipe Balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat > >> -- > >> 1.7.9.5 > > Hi, Balbi and all guys, > > Any comment for these patches? Can they be accepted? > > Rob had comments which you didn't reply yet. I cannot take this patchset > yet ;-) > Balbi, I look into his mail again, which was based v3, and I replied it. He had different understanding for undefined length burst mode. It seems he think for this mode, just setting bit[0] (INCRBrstEna) and don't need to set other field. However, according to the DWC USB3.0 controller databook, when it is undefined length INCR burst mode, we still need to set one max burst type, such as INCR8, which means controller will use any length less than or equal to this INCR8. ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-02-10 15:30 ` Jerry Huang @ 2017-03-10 11:26 ` Felipe Balbi 2017-05-02 6:13 ` Jerry Huang 0 siblings, 1 reply; 10+ messages in thread From: Felipe Balbi @ 2017-03-10 11:26 UTC (permalink / raw) To: Jerry Huang, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat [-- Attachment #1: Type: text/plain, Size: 834 bytes --] Hi, Jerry Huang <jerry.huang@nxp.com> writes: >> >> -- >> >> 1.7.9.5 >> > Hi, Balbi and all guys, >> > Any comment for these patches? Can they be accepted? >> >> Rob had comments which you didn't reply yet. I cannot take this patchset >> yet ;-) >> > Balbi, > > I look into his mail again, which was based v3, and I replied it. > > He had different understanding for undefined length burst mode. > > It seems he think for this mode, just setting bit[0] (INCRBrstEna) and > don't need to set other field. > > However, according to the DWC USB3.0 controller databook, when it is > undefined length INCR burst mode, we still need to set one max burst > type, such as INCR8, which means controller will use any length less > than or equal to this INCR8. Rob, do you agree with the patch now? -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-03-10 11:26 ` Felipe Balbi @ 2017-05-02 6:13 ` Jerry Huang 2017-06-02 10:07 ` Felipe Balbi 0 siblings, 1 reply; 10+ messages in thread From: Jerry Huang @ 2017-05-02 6:13 UTC (permalink / raw) To: Felipe Balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat > -----Original Message----- > From: Felipe Balbi [mailto:balbi@kernel.org] > Sent: Friday, March 10, 2017 7:27 PM > To: Jerry Huang <jerry.huang@nxp.com>; robh+dt@kernel.org; > mark.rutland@arm.com; catalin.marinas@arm.com > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Rajesh > Bhagat <rajesh.bhagat@nxp.com> > Subject: RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst > type > > > Hi, > > Jerry Huang <jerry.huang@nxp.com> writes: > >> >> -- > >> >> 1.7.9.5 > >> > Hi, Balbi and all guys, > >> > Any comment for these patches? Can they be accepted? > >> > >> Rob had comments which you didn't reply yet. I cannot take this > >> patchset yet ;-) > >> > > Balbi, > > > > I look into his mail again, which was based v3, and I replied it. > > > > He had different understanding for undefined length burst mode. > > > > It seems he think for this mode, just setting bit[0] (INCRBrstEna) and > > don't need to set other field. > > > > However, according to the DWC USB3.0 controller databook, when it is > > undefined length INCR burst mode, we still need to set one max burst > > type, such as INCR8, which means controller will use any length less > > than or equal to this INCR8. > > Rob, do you agree with the patch now? > > -- > balbi Hi, Balbi, Any comment for these patches? Or any chance to merge them? ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-05-02 6:13 ` Jerry Huang @ 2017-06-02 10:07 ` Felipe Balbi 0 siblings, 0 replies; 10+ messages in thread From: Felipe Balbi @ 2017-06-02 10:07 UTC (permalink / raw) To: Jerry Huang, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat [-- Attachment #1: Type: text/plain, Size: 1279 bytes --] Hi, Jerry Huang <jerry.huang@nxp.com> writes: >> Jerry Huang <jerry.huang@nxp.com> writes: >> >> >> -- >> >> >> 1.7.9.5 >> >> > Hi, Balbi and all guys, >> >> > Any comment for these patches? Can they be accepted? >> >> >> >> Rob had comments which you didn't reply yet. I cannot take this >> >> patchset yet ;-) >> >> >> > Balbi, >> > >> > I look into his mail again, which was based v3, and I replied it. >> > >> > He had different understanding for undefined length burst mode. >> > >> > It seems he think for this mode, just setting bit[0] (INCRBrstEna) and >> > don't need to set other field. >> > >> > However, according to the DWC USB3.0 controller databook, when it is >> > undefined length INCR burst mode, we still need to set one max burst >> > type, such as INCR8, which means controller will use any length less >> > than or equal to this INCR8. >> >> Rob, do you agree with the patch now? >> >> -- >> balbi > > Hi, Balbi, > Any comment for these patches? Or any chance to merge them? I'm not sure you understand how development is carried out here. I *can't* apply patches touching Device Tree properties without an Acked-by from any of the Device Tree maintainers. Until then, there's nothing I can say/do. -- balbi [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst type 2017-02-10 8:44 ` Felipe Balbi 2017-02-10 15:30 ` Jerry Huang @ 2017-02-20 8:39 ` Jerry Huang 1 sibling, 0 replies; 10+ messages in thread From: Jerry Huang @ 2017-02-20 8:39 UTC (permalink / raw) To: Felipe Balbi, robh+dt, mark.rutland, catalin.marinas Cc: linux-usb, linux-kernel, devicetree, linux-arm-kernel, Rajesh Bhagat > -----Original Message----- > From: Jerry Huang > Sent: Friday, February 10, 2017 11:30 PM > To: 'Felipe Balbi' <balbi@kernel.org>; robh+dt@kernel.org; > mark.rutland@arm.com; catalin.marinas@arm.com > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Rajesh > Bhagat <rajesh.bhagat@nxp.com> > Subject: RE: [PATCH v4 3/3] USB3/DWC3: Enable undefined length INCR burst > type > > > >> -- > > >> 1.7.9.5 > > > Hi, Balbi and all guys, > > > Any comment for these patches? Can they be accepted? > > > > Rob had comments which you didn't reply yet. I cannot take this > > patchset yet ;-) > > > Balbi, > I look into his mail again, which was based v3, and I replied it. > He had different understanding for undefined length burst mode. > It seems he think for this mode, just setting bit[0] (INCRBrstEna) and don't > need to set other field. > However, according to the DWC USB3.0 controller databook, when it is > undefined length INCR burst mode, we still need to set one max burst type, > such as INCR8, which means controller will use any length less than or equal > to this INCR8. Any comment for it? Ten days passed away again :) ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-06-02 10:08 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-01-18 8:12 [PATCH v4 1/3] USB3/DWC3: Add definition for global soc bus configuration register Changming Huang 2017-01-18 8:12 ` [PATCH v4 2/3] USB3/DWC3: Add property "snps,incr-burst-type-adjustment" for INCR burst type Changming Huang 2017-01-18 8:12 ` [PATCH v4 3/3] USB3/DWC3: Enable undefined length " Changming Huang 2017-02-10 7:45 ` Jerry Huang 2017-02-10 8:44 ` Felipe Balbi 2017-02-10 15:30 ` Jerry Huang 2017-03-10 11:26 ` Felipe Balbi 2017-05-02 6:13 ` Jerry Huang 2017-06-02 10:07 ` Felipe Balbi 2017-02-20 8:39 ` Jerry Huang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).