linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Y.b. Lu" <yangbo.lu@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
Date: Mon, 8 Oct 2018 07:50:15 +0000	[thread overview]
Message-ID: <DB6PR0401MB22324A6ABEA3846585B3E1B6F8E60@DB6PR0401MB2232.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <DB6PR0401MB2232FA836E1C9139309D43D1F8E60@DB6PR0401MB2232.eurprd04.prod.outlook.com>

Let me just add an additional patch in v3.
I had sent the new v3 patch-set out. Please help to review.

Thanks a lot.

Best regards,
Yangbo Lu

> -----Original Message-----
> From: Y.b. Lu
> Sent: Monday, October 8, 2018 11:11 AM
> To: 'Andrew Lunn' <andrew@lunn.ch>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@nxp.com>
> Cc: linux-kernel@vger.kernel.org; devel@driverdev.osuosl.org;
> netdev@vger.kernel.org; Richard Cochran <richardcochran@gmail.com>;
> David S . Miller <davem@davemloft.net>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@nxp.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>
> Subject: RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
> 
> Hi Andrew,
> 
> Sorry for late. Just come back from holiday.
> 
> Hi Ioana,
> 
> Could you generate an additional patch for dpaa2_eth to address Andrew's
> comments?
> There was also a warning when checked patch. FSL_DPAA2_ETH needed more
> description.
> 
> WARNING: please write a paragraph that describes the config symbol fully
> #66: FILE: drivers/net/ethernet/freescale/dpaa2/Kconfig:1:
> +config FSL_DPAA2_ETH
> 
> Thanks a lot.
> 
> Best regards,
> Yangbo Lu
> 
> > -----Original Message-----
> > From: Andrew Lunn <andrew@lunn.ch>
> > Sent: Sunday, September 30, 2018 3:46 AM
> > To: Y.b. Lu <yangbo.lu@nxp.com>
> > Cc: linux-kernel@vger.kernel.org; devel@driverdev.osuosl.org;
> > netdev@vger.kernel.org; Richard Cochran <richardcochran@gmail.com>;
> > David S . Miller <davem@davemloft.net>; Ioana Ciocoi Radulescu
> > <ruxandra.radulescu@nxp.com>; Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org>
> > Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of
> > staging/
> >
> > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > > @@ -0,0 +1,15 @@
> > > +config FSL_DPAA2_ETH
> > > +	tristate "Freescale DPAA2 Ethernet"
> > > +	depends on FSL_MC_BUS && FSL_MC_DPIO
> >
> > Could you add in here COMPILE_TEST?
> >
> > > +	depends on NETDEVICES && ETHERNET
> >
> > With the move out of staging, i don't think these two are required.
> >
> >      Andrew

      reply	other threads:[~2018-10-08  7:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-29  7:26 [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/ Yangbo Lu
2018-09-29  7:26 ` [v2, 2/5] MAINTAINERS: update files maintained under DPAA2 PTP/ETHERNET Yangbo Lu
2018-09-29  7:26 ` [v2, 3/5] net: dpaa2: rename rtc as ptp in dpaa2-ptp driver Yangbo Lu
2018-09-29  7:26 ` [v2, 4/5] net: dpaa2: remove unused code for dprtc Yangbo Lu
2018-09-29  7:26 ` [v2, 5/5] net: dpaa2: fix and improve dpaa2-ptp driver Yangbo Lu
2018-09-29 19:46 ` [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/ Andrew Lunn
2018-10-08  3:11   ` Y.b. Lu
2018-10-08  7:50     ` Y.b. Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0401MB22324A6ABEA3846585B3E1B6F8E60@DB6PR0401MB2232.eurprd04.prod.outlook.com \
    --to=yangbo.lu@nxp.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=ruxandra.radulescu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).