From: Jacky Bai <ping.bai@nxp.com>
To: Francesco Dolcini <francesco.dolcini@toradex.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Peng Fan <peng.fan@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, kernel test robot <lkp@intel.com>
Subject: RE: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
Date: Tue, 6 Sep 2022 01:16:30 +0000 [thread overview]
Message-ID: <DB9PR04MB8412C5E5640C8119FC5FD742877E9@DB9PR04MB8412.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220905224408.346425-1-francesco.dolcini@toradex.com>
> Subject: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
>
> PINCTRL_IMX depends on OF, however the dependency is missed when
> selected by PINCTRL_IMX8M* (it does not follow the indirect 'select'
> statements), select it explicitly.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
...
> Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
BR
> ---
> Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
> ---
> drivers/pinctrl/freescale/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 365fcff8e470..7a32f77792d9 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
>
> config PINCTRL_IMX8MM
> tristate "IMX8MM pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> @@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
>
> config PINCTRL_IMX8MN
> tristate "IMX8MN pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> @@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
>
> config PINCTRL_IMX8MP
> tristate "IMX8MP pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> @@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
>
> config PINCTRL_IMX8MQ
> tristate "IMX8MQ pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> --
> 2.25.1
next prev parent reply other threads:[~2022-09-06 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 22:44 [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile Francesco Dolcini
2022-09-06 1:16 ` Jacky Bai [this message]
2022-09-08 8:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR04MB8412C5E5640C8119FC5FD742877E9@DB9PR04MB8412.eurprd04.prod.outlook.com \
--to=ping.bai@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).