* [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
@ 2022-09-05 22:44 Francesco Dolcini
2022-09-06 1:16 ` Jacky Bai
2022-09-08 8:07 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Francesco Dolcini @ 2022-09-05 22:44 UTC (permalink / raw)
To: linux-gpio
Cc: Francesco Dolcini, Dong Aisheng, Fabio Estevam, Shawn Guo,
Jacky Bai, Pengutronix Kernel Team, Linus Walleij, Peng Fan,
linux-kernel, Arnd Bergmann, kernel test robot
PINCTRL_IMX depends on OF, however the dependency is missed when selected
by PINCTRL_IMX8M* (it does not follow the indirect 'select' statements),
select it explicitly.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202209050605.fezJUgFH-lkp@intel.com/
Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
---
drivers/pinctrl/freescale/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
index 365fcff8e470..7a32f77792d9 100644
--- a/drivers/pinctrl/freescale/Kconfig
+++ b/drivers/pinctrl/freescale/Kconfig
@@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
config PINCTRL_IMX8MM
tristate "IMX8MM pinctrl driver"
+ depends on OF
depends on SOC_IMX8M
select PINCTRL_IMX
help
@@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
config PINCTRL_IMX8MN
tristate "IMX8MN pinctrl driver"
+ depends on OF
depends on SOC_IMX8M
select PINCTRL_IMX
help
@@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
config PINCTRL_IMX8MP
tristate "IMX8MP pinctrl driver"
+ depends on OF
depends on SOC_IMX8M
select PINCTRL_IMX
help
@@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
config PINCTRL_IMX8MQ
tristate "IMX8MQ pinctrl driver"
+ depends on OF
depends on SOC_IMX8M
select PINCTRL_IMX
help
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
2022-09-05 22:44 [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile Francesco Dolcini
@ 2022-09-06 1:16 ` Jacky Bai
2022-09-08 8:07 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Jacky Bai @ 2022-09-06 1:16 UTC (permalink / raw)
To: Francesco Dolcini, linux-gpio
Cc: Francesco Dolcini, Aisheng Dong, Fabio Estevam, Shawn Guo,
Pengutronix Kernel Team, Linus Walleij, Peng Fan, linux-kernel,
Arnd Bergmann, kernel test robot
> Subject: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
>
> PINCTRL_IMX depends on OF, however the dependency is missed when
> selected by PINCTRL_IMX8M* (it does not follow the indirect 'select'
> statements), select it explicitly.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
...
> Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
BR
> ---
> Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
> ---
> drivers/pinctrl/freescale/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index 365fcff8e470..7a32f77792d9 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -119,6 +119,7 @@ config PINCTRL_IMX7ULP
>
> config PINCTRL_IMX8MM
> tristate "IMX8MM pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> @@ -126,6 +127,7 @@ config PINCTRL_IMX8MM
>
> config PINCTRL_IMX8MN
> tristate "IMX8MN pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> @@ -133,6 +135,7 @@ config PINCTRL_IMX8MN
>
> config PINCTRL_IMX8MP
> tristate "IMX8MP pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> @@ -140,6 +143,7 @@ config PINCTRL_IMX8MP
>
> config PINCTRL_IMX8MQ
> tristate "IMX8MQ pinctrl driver"
> + depends on OF
> depends on SOC_IMX8M
> select PINCTRL_IMX
> help
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile
2022-09-05 22:44 [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile Francesco Dolcini
2022-09-06 1:16 ` Jacky Bai
@ 2022-09-08 8:07 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2022-09-08 8:07 UTC (permalink / raw)
To: Francesco Dolcini
Cc: linux-gpio, Dong Aisheng, Fabio Estevam, Shawn Guo, Jacky Bai,
Pengutronix Kernel Team, Peng Fan, linux-kernel, Arnd Bergmann,
kernel test robot
On Tue, Sep 6, 2022 at 12:44 AM Francesco Dolcini
<francesco.dolcini@toradex.com> wrote:
> PINCTRL_IMX depends on OF, however the dependency is missed when selected
> by PINCTRL_IMX8M* (it does not follow the indirect 'select' statements),
> select it explicitly.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202209050605.fezJUgFH-lkp@intel.com/
> Fixes: 87c2a29a6bf1 ("pinctrl: imx8m: kconfig: Depends on SOC_IMX8M")
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
> Linus: I did test on s390 and it's fine, but the topic is tricky for me ...
This is tricky for everyone, has to do with the Kconfig "language".
Thanks! Patch applied.
Yours,
LInus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-08 8:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-05 22:44 [PATCH] pinctrl: imx8m: kconfig: Fix build error on test compile Francesco Dolcini
2022-09-06 1:16 ` Jacky Bai
2022-09-08 8:07 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).