[PATCH] staging: comedi: comedi_8254.h: make self-reliant

[PATCH] staging: comedi: comedi_8254.h: make self-reliant

[Ian Abbott]

The Comedi "comedi_8254.h" header file is included by various Comedi
drivers with timer/counters based on the 8254 chip.  The drivers do not
compile cleanly if this header file is included first.  It uses pointers
to the `struct comedi_device`, `struct comedi_subdevice`, and `struct
comedi_insn` structures in various function prototypes, so declare those
as incomplete types.  It use the `bool` type, so include
<linux/types.h>.  It also uses the `__iomem` tag, but that seems to be
taken care of indirectly by including <linux/types.h>.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
---
 drivers/staging/comedi/drivers/comedi_8254.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/staging/comedi/drivers/comedi_8254.h b/drivers/staging/comedi/drivers/comedi_8254.h
index d89f6d9..f4610ea 100644
--- a/drivers/staging/comedi/drivers/comedi_8254.h
+++ b/drivers/staging/comedi/drivers/comedi_8254.h
@@ -20,6 +20,12 @@
 #ifndef _COMEDI_8254_H
 #define _COMEDI_8254_H
 
+#include <linux/types.h>
+
+struct comedi_device;
+struct comedi_insn;
+struct comedi_subdevice;
+
 /*
  * Common oscillator base values in nanoseconds
  */
-- 
2.1.4

RE: [PATCH] staging: comedi: comedi_8254.h: make self-reliant

[Hartley Sweeten]

On Friday, May 22, 2015 10:33 AM, Ian Abbott wrote:
> The Comedi "comedi_8254.h" header file is included by various Comedi
> drivers with timer/counters based on the 8254 chip.  The drivers do not
> compile cleanly if this header file is included first.  It uses pointers
> to the `struct comedi_device`, `struct comedi_subdevice`, and `struct
> comedi_insn` structures in various function prototypes, so declare those
> as incomplete types.  It use the `bool` type, so include
> <linux/types.h>.  It also uses the `__iomem` tag, but that seems to be
> taken care of indirectly by including <linux/types.h>.
>
> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>

Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>