* [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
@ 2012-11-14 11:47 Liu, Jinsong
0 siblings, 0 replies; 9+ messages in thread
From: Liu, Jinsong @ 2012-11-14 11:47 UTC (permalink / raw)
To: Brown, Len, Konrad Rzeszutek Wilk, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1759 bytes --]
>From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
From: Liu Jinsong <jinsong.liu@intel.com>
Date: Wed, 14 Nov 2012 18:52:06 +0800
Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
When memory hotadd, acpi_memory_enable_device has already been done
at drv->ops.add (acpi_memory_device_add), no need to do it again
at notify callback.
At acpi_memory_enable_device, acpi_memory_get_device_resources
is also a redundant action, since it has been done at drv->ops.add.
Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
---
drivers/acpi/acpi_memhotplug.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 24c807f..a6489fd 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
struct acpi_memory_info *info;
int node;
-
- /* Get the range from the _CRS */
- result = acpi_memory_get_device_resources(mem_device);
- if (result) {
- printk(KERN_ERR PREFIX "get_device_resources failed\n");
- mem_device->state = MEMORY_INVALID_STATE;
- return result;
- }
-
node = acpi_get_node(mem_device->device->handle);
/*
* Tell the VM there is more memory here...
@@ -357,14 +348,6 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
break;
}
- if (acpi_memory_check_device(mem_device))
- break;
-
- if (acpi_memory_enable_device(mem_device)) {
- printk(KERN_ERR PREFIX "Cannot enable memory device\n");
- break;
- }
-
ost_code = ACPI_OST_SC_SUCCESS;
break;
--
1.7.1
[-- Attachment #2: 0001-X86-acpi-remove-redundant-logic-of-acpi-memory-hotad.patch --]
[-- Type: application/octet-stream, Size: 1705 bytes --]
From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
From: Liu Jinsong <jinsong.liu@intel.com>
Date: Wed, 14 Nov 2012 18:52:06 +0800
Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
When memory hotadd, acpi_memory_enable_device has already been done
at drv->ops.add (acpi_memory_device_add), no need to do it again
at notify callback.
At acpi_memory_enable_device, acpi_memory_get_device_resources
is also a redundant action, since it has been done at drv->ops.add.
Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
---
drivers/acpi/acpi_memhotplug.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 24c807f..a6489fd 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
struct acpi_memory_info *info;
int node;
-
- /* Get the range from the _CRS */
- result = acpi_memory_get_device_resources(mem_device);
- if (result) {
- printk(KERN_ERR PREFIX "get_device_resources failed\n");
- mem_device->state = MEMORY_INVALID_STATE;
- return result;
- }
-
node = acpi_get_node(mem_device->device->handle);
/*
* Tell the VM there is more memory here...
@@ -357,14 +348,6 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
break;
}
- if (acpi_memory_check_device(mem_device))
- break;
-
- if (acpi_memory_enable_device(mem_device)) {
- printk(KERN_ERR PREFIX "Cannot enable memory device\n");
- break;
- }
-
ost_code = ACPI_OST_SC_SUCCESS;
break;
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
@ 2012-12-04 1:39 Liu, Jinsong
2012-12-06 15:58 ` Liu, Jinsong
2012-12-07 22:19 ` Rafael J. Wysocki
0 siblings, 2 replies; 9+ messages in thread
From: Liu, Jinsong @ 2012-12-04 1:39 UTC (permalink / raw)
To: Wysocki, Rafael J, lenb, linux-acpi, linux-kernel
Cc: Konrad Rzeszutek Wilk, Liu, Jinsong
[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]
Resend it, add Rafael and linux-acpi@vger.kernel.org
Thanks,
Jinsong
===============
>From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
From: Liu Jinsong <jinsong.liu@intel.com>
Date: Wed, 14 Nov 2012 18:52:06 +0800
Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
When memory hotadd, acpi_memory_enable_device has already been done
at drv->ops.add (acpi_memory_device_add), no need to do it again
at notify callback.
At acpi_memory_enable_device, acpi_memory_get_device_resources
is also a redundant action, since it has been done at drv->ops.add.
Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
---
drivers/acpi/acpi_memhotplug.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 24c807f..a6489fd 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
struct acpi_memory_info *info;
int node;
-
- /* Get the range from the _CRS */
- result = acpi_memory_get_device_resources(mem_device);
- if (result) {
- printk(KERN_ERR PREFIX "get_device_resources failed\n");
- mem_device->state = MEMORY_INVALID_STATE;
- return result;
- }
-
node = acpi_get_node(mem_device->device->handle);
/*
* Tell the VM there is more memory here...
@@ -357,14 +348,6 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
break;
}
- if (acpi_memory_check_device(mem_device))
- break;
-
- if (acpi_memory_enable_device(mem_device)) {
- printk(KERN_ERR PREFIX "Cannot enable memory device\n");
- break;
- }
-
ost_code = ACPI_OST_SC_SUCCESS;
break;
--
1.7.1
[-- Attachment #2: 0001-X86-acpi-remove-redundant-logic-of-acpi-memory-hotad.patch --]
[-- Type: application/octet-stream, Size: 1705 bytes --]
From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
From: Liu Jinsong <jinsong.liu@intel.com>
Date: Wed, 14 Nov 2012 18:52:06 +0800
Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
When memory hotadd, acpi_memory_enable_device has already been done
at drv->ops.add (acpi_memory_device_add), no need to do it again
at notify callback.
At acpi_memory_enable_device, acpi_memory_get_device_resources
is also a redundant action, since it has been done at drv->ops.add.
Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
---
drivers/acpi/acpi_memhotplug.c | 17 -----------------
1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 24c807f..a6489fd 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
struct acpi_memory_info *info;
int node;
-
- /* Get the range from the _CRS */
- result = acpi_memory_get_device_resources(mem_device);
- if (result) {
- printk(KERN_ERR PREFIX "get_device_resources failed\n");
- mem_device->state = MEMORY_INVALID_STATE;
- return result;
- }
-
node = acpi_get_node(mem_device->device->handle);
/*
* Tell the VM there is more memory here...
@@ -357,14 +348,6 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
break;
}
- if (acpi_memory_check_device(mem_device))
- break;
-
- if (acpi_memory_enable_device(mem_device)) {
- printk(KERN_ERR PREFIX "Cannot enable memory device\n");
- break;
- }
-
ost_code = ACPI_OST_SC_SUCCESS;
break;
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-04 1:39 Liu, Jinsong
@ 2012-12-06 15:58 ` Liu, Jinsong
2012-12-07 22:19 ` Rafael J. Wysocki
1 sibling, 0 replies; 9+ messages in thread
From: Liu, Jinsong @ 2012-12-06 15:58 UTC (permalink / raw)
To: Wysocki, Rafael J, lenb, linux-acpi, linux-kernel; +Cc: Konrad Rzeszutek Wilk
Ping?
Thanks,
Jinsong
Liu, Jinsong wrote:
> Resend it, add Rafael and linux-acpi@vger.kernel.org
>
> Thanks,
> Jinsong
>
> ===============
> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
> From: Liu Jinsong <jinsong.liu@intel.com>
> Date: Wed, 14 Nov 2012 18:52:06 +0800
> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory
> hotadd
>
> When memory hotadd, acpi_memory_enable_device has already been done
> at drv->ops.add (acpi_memory_device_add), no need to do it again
> at notify callback.
>
> At acpi_memory_enable_device, acpi_memory_get_device_resources
> is also a redundant action, since it has been done at drv->ops.add.
>
> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
> ---
> drivers/acpi/acpi_memhotplug.c | 17 -----------------
> 1 files changed, 0 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c
> b/drivers/acpi/acpi_memhotplug.c
> index 24c807f..a6489fd 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct
> acpi_memory_device *mem_device) struct acpi_memory_info *info;
> int node;
>
> -
> - /* Get the range from the _CRS */
> - result = acpi_memory_get_device_resources(mem_device);
> - if (result) {
> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
> - mem_device->state = MEMORY_INVALID_STATE;
> - return result;
> - }
> -
> node = acpi_get_node(mem_device->device->handle);
> /*
> * Tell the VM there is more memory here...
> @@ -357,14 +348,6 @@ static void
> acpi_memory_device_notify(acpi_handle handle, u32 event, void
> *data) break; }
>
> - if (acpi_memory_check_device(mem_device))
> - break;
> -
> - if (acpi_memory_enable_device(mem_device)) {
> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
> - break;
> - }
> -
> ost_code = ACPI_OST_SC_SUCCESS;
> break;
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-04 1:39 Liu, Jinsong
2012-12-06 15:58 ` Liu, Jinsong
@ 2012-12-07 22:19 ` Rafael J. Wysocki
2012-12-08 2:34 ` Wen Congyang
1 sibling, 1 reply; 9+ messages in thread
From: Rafael J. Wysocki @ 2012-12-07 22:19 UTC (permalink / raw)
To: Liu, Jinsong, Toshi Kani, Wen Congyang
Cc: Wysocki, Rafael J, lenb, linux-acpi, linux-kernel,
Konrad Rzeszutek Wilk, Jiang Liu
On Tuesday, December 04, 2012 01:39:54 AM Liu, Jinsong wrote:
> Resend it, add Rafael and linux-acpi@vger.kernel.org
I wonder what memory hotplug people think about that.
Thanks,
Rafael
> ===============
> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
> From: Liu Jinsong <jinsong.liu@intel.com>
> Date: Wed, 14 Nov 2012 18:52:06 +0800
> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
>
> When memory hotadd, acpi_memory_enable_device has already been done
> at drv->ops.add (acpi_memory_device_add), no need to do it again
> at notify callback.
>
> At acpi_memory_enable_device, acpi_memory_get_device_resources
> is also a redundant action, since it has been done at drv->ops.add.
>
> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
> ---
> drivers/acpi/acpi_memhotplug.c | 17 -----------------
> 1 files changed, 0 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index 24c807f..a6489fd 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> struct acpi_memory_info *info;
> int node;
>
> -
> - /* Get the range from the _CRS */
> - result = acpi_memory_get_device_resources(mem_device);
> - if (result) {
> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
> - mem_device->state = MEMORY_INVALID_STATE;
> - return result;
> - }
> -
> node = acpi_get_node(mem_device->device->handle);
> /*
> * Tell the VM there is more memory here...
> @@ -357,14 +348,6 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
> break;
> }
>
> - if (acpi_memory_check_device(mem_device))
> - break;
> -
> - if (acpi_memory_enable_device(mem_device)) {
> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
> - break;
> - }
> -
> ost_code = ACPI_OST_SC_SUCCESS;
> break;
>
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-07 22:19 ` Rafael J. Wysocki
@ 2012-12-08 2:34 ` Wen Congyang
2012-12-12 14:37 ` Liu, Jinsong
0 siblings, 1 reply; 9+ messages in thread
From: Wen Congyang @ 2012-12-08 2:34 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Liu, Jinsong, Toshi Kani, Wysocki, Rafael J, lenb, linux-acpi,
linux-kernel, Konrad Rzeszutek Wilk, Jiang Liu
At 12/08/2012 06:19 AM, Rafael J. Wysocki Wrote:
> On Tuesday, December 04, 2012 01:39:54 AM Liu, Jinsong wrote:
>> Resend it, add Rafael and linux-acpi@vger.kernel.org
>
> I wonder what memory hotplug people think about that.
>
> Thanks,
> Rafael
>
>
>> ===============
>> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00 2001
>> From: Liu Jinsong <jinsong.liu@intel.com>
>> Date: Wed, 14 Nov 2012 18:52:06 +0800
>> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
>>
>> When memory hotadd, acpi_memory_enable_device has already been done
>> at drv->ops.add (acpi_memory_device_add), no need to do it again
>> at notify callback.
>>
>> At acpi_memory_enable_device, acpi_memory_get_device_resources
>> is also a redundant action, since it has been done at drv->ops.add.
>>
>> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
>> ---
>> drivers/acpi/acpi_memhotplug.c | 17 -----------------
>> 1 files changed, 0 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
>> index 24c807f..a6489fd 100644
>> --- a/drivers/acpi/acpi_memhotplug.c
>> +++ b/drivers/acpi/acpi_memhotplug.c
>> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
>> struct acpi_memory_info *info;
>> int node;
>>
>> -
>> - /* Get the range from the _CRS */
>> - result = acpi_memory_get_device_resources(mem_device);
>> - if (result) {
>> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
>> - mem_device->state = MEMORY_INVALID_STATE;
>> - return result;
>> - }
>> -
>> node = acpi_get_node(mem_device->device->handle);
>> /*
>> * Tell the VM there is more memory here...
>> @@ -357,14 +348,6 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
>> break;
>> }
>>
>> - if (acpi_memory_check_device(mem_device))
>> - break;
Hmm, if acpi_memory_check_device() fails, it means the memory device disappears
I don't know if a real hardware uses this way to remove memory device.
>> -
>> - if (acpi_memory_enable_device(mem_device)) {
>> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
>> - break;
>> - }
If acpi_memory_get_device() doesn't fail, it means that the device has been managed
by this driver, so I think we can do this cleanup.
Thanks
Wen Congyang
>> -
>> ost_code = ACPI_OST_SC_SUCCESS;
>> break;
>>
>>
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-08 2:34 ` Wen Congyang
@ 2012-12-12 14:37 ` Liu, Jinsong
2012-12-13 2:36 ` Jiang Liu
0 siblings, 1 reply; 9+ messages in thread
From: Liu, Jinsong @ 2012-12-12 14:37 UTC (permalink / raw)
To: Wen Congyang, Rafael J. Wysocki
Cc: Toshi Kani, Wysocki, Rafael J, lenb, linux-acpi, linux-kernel,
Konrad Rzeszutek Wilk, Jiang Liu
Wen Congyang wrote:
> At 12/08/2012 06:19 AM, Rafael J. Wysocki Wrote:
>> On Tuesday, December 04, 2012 01:39:54 AM Liu, Jinsong wrote:
>>> Resend it, add Rafael and linux-acpi@vger.kernel.org
>>
>> I wonder what memory hotplug people think about that.
>>
>> Thanks,
>> Rafael
>>
>>
>>> ===============
>>> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00
>>> 2001
>>> From: Liu Jinsong <jinsong.liu@intel.com>
>>> Date: Wed, 14 Nov 2012 18:52:06 +0800
>>> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory
>>> hotadd
>>>
>>> When memory hotadd, acpi_memory_enable_device has already been done
>>> at drv->ops.add (acpi_memory_device_add), no need to do it again
>>> at notify callback.
>>>
>>> At acpi_memory_enable_device, acpi_memory_get_device_resources
>>> is also a redundant action, since it has been done at drv->ops.add.
>>>
>>> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
>>> ---
>>> drivers/acpi/acpi_memhotplug.c | 17 -----------------
>>> 1 files changed, 0 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/drivers/acpi/acpi_memhotplug.c
>>> b/drivers/acpi/acpi_memhotplug.c
>>> index 24c807f..a6489fd 100644
>>> --- a/drivers/acpi/acpi_memhotplug.c
>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct
>>> acpi_memory_device *mem_device) struct acpi_memory_info *info;
>>> int node;
>>>
>>> -
>>> - /* Get the range from the _CRS */
>>> - result = acpi_memory_get_device_resources(mem_device);
>>> - if (result) {
>>> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
>>> - mem_device->state = MEMORY_INVALID_STATE;
>>> - return result;
>>> - }
>>> -
>>> node = acpi_get_node(mem_device->device->handle); /*
>>> * Tell the VM there is more memory here...
>>> @@ -357,14 +348,6 @@ static void
>>> acpi_memory_device_notify(acpi_handle handle, u32 event, void
>>> *data) break; }
>>>
>>> - if (acpi_memory_check_device(mem_device))
>>> - break;
>
> Hmm, if acpi_memory_check_device() fails, it means the memory device
> disappears
> I don't know if a real hardware uses this way to remove memory device.
>
>>> -
>>> - if (acpi_memory_enable_device(mem_device)) {
>>> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
>>> - break;
>>> - }
>
> If acpi_memory_get_device() doesn't fail, it means that the device
> has been managed by this driver, so I think we can do this cleanup.
>
> Thanks
> Wen Congyang
>
Thanks! any comments from Huawei side, Jiang?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-12 14:37 ` Liu, Jinsong
@ 2012-12-13 2:36 ` Jiang Liu
2012-12-13 11:15 ` Rafael J. Wysocki
0 siblings, 1 reply; 9+ messages in thread
From: Jiang Liu @ 2012-12-13 2:36 UTC (permalink / raw)
To: Liu, Jinsong
Cc: Wen Congyang, Rafael J. Wysocki, Toshi Kani, Wysocki, Rafael J,
lenb, linux-acpi, linux-kernel, Konrad Rzeszutek Wilk
On 2012-12-12 22:37, Liu, Jinsong wrote:
> Wen Congyang wrote:
>> At 12/08/2012 06:19 AM, Rafael J. Wysocki Wrote:
>>> On Tuesday, December 04, 2012 01:39:54 AM Liu, Jinsong wrote:
>>>> Resend it, add Rafael and linux-acpi@vger.kernel.org
>>>
>>> I wonder what memory hotplug people think about that.
>>>
>>> Thanks,
>>> Rafael
>>>
>>>
>>>> ===============
>>>> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00
>>>> 2001
>>>> From: Liu Jinsong <jinsong.liu@intel.com>
>>>> Date: Wed, 14 Nov 2012 18:52:06 +0800
>>>> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory
>>>> hotadd
>>>>
>>>> When memory hotadd, acpi_memory_enable_device has already been done
>>>> at drv->ops.add (acpi_memory_device_add), no need to do it again
>>>> at notify callback.
>>>>
>>>> At acpi_memory_enable_device, acpi_memory_get_device_resources
>>>> is also a redundant action, since it has been done at drv->ops.add.
>>>>
>>>> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
>>>> ---
>>>> drivers/acpi/acpi_memhotplug.c | 17 -----------------
>>>> 1 files changed, 0 insertions(+), 17 deletions(-)
>>>>
>>>> diff --git a/drivers/acpi/acpi_memhotplug.c
>>>> b/drivers/acpi/acpi_memhotplug.c
>>>> index 24c807f..a6489fd 100644
>>>> --- a/drivers/acpi/acpi_memhotplug.c
>>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>>> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct
>>>> acpi_memory_device *mem_device) struct acpi_memory_info *info;
>>>> int node;
>>>>
>>>> -
>>>> - /* Get the range from the _CRS */
>>>> - result = acpi_memory_get_device_resources(mem_device);
>>>> - if (result) {
>>>> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
>>>> - mem_device->state = MEMORY_INVALID_STATE;
>>>> - return result;
>>>> - }
>>>> -
>>>> node = acpi_get_node(mem_device->device->handle); /*
>>>> * Tell the VM there is more memory here...
>>>> @@ -357,14 +348,6 @@ static void
>>>> acpi_memory_device_notify(acpi_handle handle, u32 event, void
>>>> *data) break; }
>>>>
>>>> - if (acpi_memory_check_device(mem_device))
>>>> - break;
>>
>> Hmm, if acpi_memory_check_device() fails, it means the memory device
>> disappears
>> I don't know if a real hardware uses this way to remove memory device.
>>
>>>> -
>>>> - if (acpi_memory_enable_device(mem_device)) {
>>>> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
>>>> - break;
>>>> - }
>>
>> If acpi_memory_get_device() doesn't fail, it means that the device
>> has been managed by this driver, so I think we can do this cleanup.
>>
>> Thanks
>> Wen Congyang
>>
>
> Thanks! any comments from Huawei side, Jiang?
Hi Jinsong,
We think it's ok.
acpi_memory_device_notify
acpi_memory_get_device
acpi_memory_device_add
acpi_memory_get_device_resources
acpi_memory_enable_device
acpi_memory_get_device_resources（redundant）
acpi_memory_check_device（redundant）
acpi_memory_enable_device（redundant）
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-13 2:36 ` Jiang Liu
@ 2012-12-13 11:15 ` Rafael J. Wysocki
2012-12-13 13:22 ` Liu, Jinsong
0 siblings, 1 reply; 9+ messages in thread
From: Rafael J. Wysocki @ 2012-12-13 11:15 UTC (permalink / raw)
To: Jiang Liu
Cc: Liu, Jinsong, Wen Congyang, Toshi Kani, Wysocki, Rafael J, lenb,
linux-acpi, linux-kernel, Konrad Rzeszutek Wilk
On Thursday, December 13, 2012 10:36:38 AM Jiang Liu wrote:
> On 2012-12-12 22:37, Liu, Jinsong wrote:
> > Wen Congyang wrote:
> >> At 12/08/2012 06:19 AM, Rafael J. Wysocki Wrote:
> >>> On Tuesday, December 04, 2012 01:39:54 AM Liu, Jinsong wrote:
> >>>> Resend it, add Rafael and linux-acpi@vger.kernel.org
> >>>
> >>> I wonder what memory hotplug people think about that.
> >>>
> >>> Thanks,
> >>> Rafael
> >>>
> >>>
> >>>> ===============
> >>>> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17 00:00:00
> >>>> 2001
> >>>> From: Liu Jinsong <jinsong.liu@intel.com>
> >>>> Date: Wed, 14 Nov 2012 18:52:06 +0800
> >>>> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory
> >>>> hotadd
> >>>>
> >>>> When memory hotadd, acpi_memory_enable_device has already been done
> >>>> at drv->ops.add (acpi_memory_device_add), no need to do it again
> >>>> at notify callback.
> >>>>
> >>>> At acpi_memory_enable_device, acpi_memory_get_device_resources
> >>>> is also a redundant action, since it has been done at drv->ops.add.
> >>>>
> >>>> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
> >>>> ---
> >>>> drivers/acpi/acpi_memhotplug.c | 17 -----------------
> >>>> 1 files changed, 0 insertions(+), 17 deletions(-)
> >>>>
> >>>> diff --git a/drivers/acpi/acpi_memhotplug.c
> >>>> b/drivers/acpi/acpi_memhotplug.c
> >>>> index 24c807f..a6489fd 100644
> >>>> --- a/drivers/acpi/acpi_memhotplug.c
> >>>> +++ b/drivers/acpi/acpi_memhotplug.c
> >>>> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct
> >>>> acpi_memory_device *mem_device) struct acpi_memory_info *info;
> >>>> int node;
> >>>>
> >>>> -
> >>>> - /* Get the range from the _CRS */
> >>>> - result = acpi_memory_get_device_resources(mem_device);
> >>>> - if (result) {
> >>>> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
> >>>> - mem_device->state = MEMORY_INVALID_STATE;
> >>>> - return result;
> >>>> - }
> >>>> -
> >>>> node = acpi_get_node(mem_device->device->handle); /*
> >>>> * Tell the VM there is more memory here...
> >>>> @@ -357,14 +348,6 @@ static void
> >>>> acpi_memory_device_notify(acpi_handle handle, u32 event, void
> >>>> *data) break; }
> >>>>
> >>>> - if (acpi_memory_check_device(mem_device))
> >>>> - break;
> >>
> >> Hmm, if acpi_memory_check_device() fails, it means the memory device
> >> disappears
> >> I don't know if a real hardware uses this way to remove memory device.
> >>
> >>>> -
> >>>> - if (acpi_memory_enable_device(mem_device)) {
> >>>> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
> >>>> - break;
> >>>> - }
> >>
> >> If acpi_memory_get_device() doesn't fail, it means that the device
> >> has been managed by this driver, so I think we can do this cleanup.
> >>
> >> Thanks
> >> Wen Congyang
> >>
> >
> > Thanks! any comments from Huawei side, Jiang?
> Hi Jinsong,
>
> We think it's ok.
>
> acpi_memory_device_notify
> acpi_memory_get_device
> acpi_memory_device_add
> acpi_memory_get_device_resources
> acpi_memory_enable_device
> acpi_memory_get_device_resources（redundant）
> acpi_memory_check_device（redundant）
> acpi_memory_enable_device（redundant）
OK, thanks.
I'll queue it up for submission as a fix later in the cycle.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd
2012-12-13 11:15 ` Rafael J. Wysocki
@ 2012-12-13 13:22 ` Liu, Jinsong
0 siblings, 0 replies; 9+ messages in thread
From: Liu, Jinsong @ 2012-12-13 13:22 UTC (permalink / raw)
To: Rafael J. Wysocki, Jiang Liu
Cc: Wen Congyang, Toshi Kani, Wysocki, Rafael J, lenb, linux-acpi,
linux-kernel, Konrad Rzeszutek Wilk
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 3521 bytes --]
Rafael J. Wysocki wrote:
> On Thursday, December 13, 2012 10:36:38 AM Jiang Liu wrote:
>> On 2012-12-12 22:37, Liu, Jinsong wrote:
>>> Wen Congyang wrote:
>>>> At 12/08/2012 06:19 AM, Rafael J. Wysocki Wrote:
>>>>> On Tuesday, December 04, 2012 01:39:54 AM Liu, Jinsong wrote:
>>>>>> Resend it, add Rafael and linux-acpi@vger.kernel.org
>>>>>
>>>>> I wonder what memory hotplug people think about that.
>>>>>
>>>>> Thanks,
>>>>> Rafael
>>>>>
>>>>>
>>>>>> ===============
>>>>>> From 1d39279e45c54ce531691da5ffe261e7689dd92c Mon Sep 17
>>>>>> 00:00:00 2001 From: Liu Jinsong <jinsong.liu@intel.com>
>>>>>> Date: Wed, 14 Nov 2012 18:52:06 +0800
>>>>>> Subject: [PATCH] X86/acpi: remove redundant logic of acpi memory
>>>>>> hotadd
>>>>>>
>>>>>> When memory hotadd, acpi_memory_enable_device has already been
>>>>>> done at drv->ops.add (acpi_memory_device_add), no need to do it
>>>>>> again at notify callback.
>>>>>>
>>>>>> At acpi_memory_enable_device, acpi_memory_get_device_resources
>>>>>> is also a redundant action, since it has been done at
>>>>>> drv->ops.add.
>>>>>>
>>>>>> Signed-off-by: Liu Jinsong <jinsong.liu@intel.com>
>>>>>> ---
>>>>>> drivers/acpi/acpi_memhotplug.c | 17 -----------------
>>>>>> 1 files changed, 0 insertions(+), 17 deletions(-)
>>>>>>
>>>>>> diff --git a/drivers/acpi/acpi_memhotplug.c
>>>>>> b/drivers/acpi/acpi_memhotplug.c
>>>>>> index 24c807f..a6489fd 100644
>>>>>> --- a/drivers/acpi/acpi_memhotplug.c
>>>>>> +++ b/drivers/acpi/acpi_memhotplug.c
>>>>>> @@ -220,15 +220,6 @@ static int acpi_memory_enable_device(struct
>>>>>> acpi_memory_device *mem_device) struct acpi_memory_info *info;
>>>>>> int node;
>>>>>>
>>>>>> -
>>>>>> - /* Get the range from the _CRS */
>>>>>> - result = acpi_memory_get_device_resources(mem_device);
>>>>>> - if (result) {
>>>>>> - printk(KERN_ERR PREFIX "get_device_resources failed\n");
>>>>>> - mem_device->state = MEMORY_INVALID_STATE;
>>>>>> - return result;
>>>>>> - }
>>>>>> -
>>>>>> node = acpi_get_node(mem_device->device->handle); /*
>>>>>> * Tell the VM there is more memory here...
>>>>>> @@ -357,14 +348,6 @@ static void
>>>>>> acpi_memory_device_notify(acpi_handle handle, u32 event, void
>>>>>> *data) break; }
>>>>>>
>>>>>> - if (acpi_memory_check_device(mem_device))
>>>>>> - break;
>>>>
>>>> Hmm, if acpi_memory_check_device() fails, it means the memory
>>>> device disappears I don't know if a real hardware uses this way to
>>>> remove memory device.
>>>>
>>>>>> -
>>>>>> - if (acpi_memory_enable_device(mem_device)) {
>>>>>> - printk(KERN_ERR PREFIX "Cannot enable memory device\n");
>>>>>> - break;
>>>>>> - }
>>>>
>>>> If acpi_memory_get_device() doesn't fail, it means that the device
>>>> has been managed by this driver, so I think we can do this cleanup.
>>>>
>>>> Thanks
>>>> Wen Congyang
>>>>
>>>
>>> Thanks! any comments from Huawei side, Jiang? Hi Jinsong,
>>
>> We think it's ok.
>>
>> acpi_memory_device_notify
>> acpi_memory_get_device
>> acpi_memory_device_add
>> acpi_memory_get_device_resources
>> acpi_memory_enable_device
>> acpi_memory_get_device_resources£¨redundant£©
>> acpi_memory_check_device£¨redundant£©
>> acpi_memory_enable_device£¨redundant£©
>
> OK, thanks.
>
> I'll queue it up for submission as a fix later in the cycle.
>
> Thanks,
> Rafael
Thank you all!
Jinsongÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-12-13 13:24 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-14 11:47 [PATCH] X86/acpi: remove redundant logic of acpi memory hotadd Liu, Jinsong
2012-12-04 1:39 Liu, Jinsong
2012-12-06 15:58 ` Liu, Jinsong
2012-12-07 22:19 ` Rafael J. Wysocki
2012-12-08 2:34 ` Wen Congyang
2012-12-12 14:37 ` Liu, Jinsong
2012-12-13 2:36 ` Jiang Liu
2012-12-13 11:15 ` Rafael J. Wysocki
2012-12-13 13:22 ` Liu, Jinsong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).