RE: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings

[KY Srinivasan <kys@microsoft.com>]

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Wednesday, August 31, 2016 4:13 PM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com;
> jasowang@redhat.com; leann.ogasawara@canonical.com
> Subject: Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around
> mappings
> 
> On Wed, Jul 06, 2016 at 05:25:02PM -0700, kys@exchange.microsoft.com
> wrote:
> > From: Vitaly Kuznetsov <vkuznets@redhat.com>
> >
> > In preparation for doing wrap around mappings for ring buffers cleanup
> > vmbus_open() function:
> > - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel
> >   drivers now);
> > - kfree(open_info) on error only after we kzalloc() it (not an issue as it
> >   is valid to call kfree(NULL);
> > - rename poorly named labels;
> > - use alloc_pages() instead of __get_free_pages() as we need struct page
> >   pointer for future.
> >
> > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > Tested-by: Dexuan Cui <decui@microsoft.com>
> > ---
> >  drivers/hv/channel.c |   43 +++++++++++++++++++++++--------------------
> >  1 files changed, 23 insertions(+), 20 deletions(-)
> 
> This patch doesn't apply to the tree due to the other hv patches you
> sent.  Can you respin this series and resend?

Will do.

Regards,

K. Y
> 
> thanks,
> 
> greg k-h