linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: kys@microsoft.com
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
	jasowang@redhat.com, leann.ogasawara@canonical.com
Subject: Re: [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings
Date: Wed, 31 Aug 2016 12:42:40 +0200	[thread overview]
Message-ID: <20160831104240.GA22573@kroah.com> (raw)
In-Reply-To: <1467851105-8773-1-git-send-email-kys@exchange.microsoft.com>

On Wed, Jul 06, 2016 at 05:25:02PM -0700, kys@exchange.microsoft.com wrote:
> From: Vitaly Kuznetsov <vkuznets@redhat.com>
> 
> In preparation for doing wrap around mappings for ring buffers cleanup
> vmbus_open() function:
> - check that ring sizes are PAGE_SIZE aligned (they are for all in-kernel
>   drivers now);
> - kfree(open_info) on error only after we kzalloc() it (not an issue as it
>   is valid to call kfree(NULL);
> - rename poorly named labels;
> - use alloc_pages() instead of __get_free_pages() as we need struct page
>   pointer for future.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Tested-by: Dexuan Cui <decui@microsoft.com>
> ---
>  drivers/hv/channel.c |   43 +++++++++++++++++++++++--------------------
>  1 files changed, 23 insertions(+), 20 deletions(-)

This patch doesn't apply to the tree due to the other hv patches you
sent.  Can you respin this series and resend?

thanks,

greg k-h

  parent reply	other threads:[~2016-08-31 10:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  0:24 [PATCH 0/4] Drivers: hv: vmbus: Make in-place consumption always possible kys
2016-07-07  0:25 ` [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings kys
2016-07-07  0:25   ` [PATCH 2/4] Drivers: hv: ring_buffer: wrap around mappings for ring buffers kys
2016-07-07  0:25   ` [PATCH 3/4] Drivers: hv: ring_buffer: use wrap around mappings in hv_copy{from,to}_ringbuffer() kys
2016-07-07  0:25   ` [PATCH 4/4] Drivers: hv: ring_buffer: count on wrap around mappings in get_next_pkt_raw() kys
2016-08-31 10:42   ` Greg KH [this message]
2016-08-31 17:55     ` [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings KY Srinivasan
  -- strict thread matches above, loose matches on Subject: below --
2016-06-10  9:47 [PATCH 0/4] Drivers: hv: ring_buffer: make in-place consumption always possible Vitaly Kuznetsov
2016-06-10  9:47 ` [PATCH 1/4] Drivers: hv: cleanup vmbus_open() for wrap around mappings Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160831104240.GA22573@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).