From: "Alex Ng (LIS)" <alexng@microsoft.com>
To: Olaf Hering <olaf@aepfle.de>, KY Srinivasan <kys@microsoft.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"apw@canonical.com" <apw@canonical.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>
Subject: RE: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.
Date: Tue, 13 Sep 2016 18:27:15 +0000 [thread overview]
Message-ID: <DM5PR03MB27300928557066E872D71B22D8FE0@DM5PR03MB2730.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20160913173816.GA29448@aepfle.de>
> On Thu, Sep 08, kys@exchange.microsoft.com wrote:
>
> > - default:
> > + case(VERSION_WIN10):
> > util_fw_version = UTIL_FW_VERSION;
> > sd_srv_version = SD_VERSION;
> > ts_srv_version = TS_VERSION;
> > hb_srv_version = HB_VERSION;
> > + break;
> > + default:
> > + util_fw_version = UTIL_FW_VERSION;
> > + sd_srv_version = SD_VERSION;
> > + ts_srv_version = TS_VERSION_3;
> > + hb_srv_version = HB_VERSION;
>
> Is this correct? An old kernel on a newer host would use the old protocol. I
> assume that new host will also know about the old protocol?
This is correct. An old kernel uses the old protocol even with the new host.
New hosts understand the old protocol.
> Perhaps a better approach would be to list the known existing hosts and use
> the new protocol for upcoming, unknown hosts via 'default:'.
This is a good idea. I will create another patch that addresses this.
>
> Olaf
next prev parent reply other threads:[~2016-09-13 20:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 12:23 [PATCH 0/3] Drivers: hv: util: Support the latest time synch protocol from the host kys
2016-09-08 12:24 ` [PATCH 1/3] Drivers: hv: utils: Rename version definitions to reflect protocol version kys
2016-09-08 12:24 ` [PATCH 2/3] Drivers: hv: utils: Use TimeSync samples to adjust the clock after boot kys
2016-09-08 12:24 ` [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples kys
2016-09-13 17:38 ` Olaf Hering
2016-09-13 18:27 ` Alex Ng (LIS) [this message]
2016-09-14 12:57 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR03MB27300928557066E872D71B22D8FE0@DM5PR03MB2730.namprd03.prod.outlook.com \
--to=alexng@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).