linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: kys@microsoft.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, apw@canonical.com,
	vkuznets@redhat.com, jasowang@redhat.com,
	leann.ogasawara@canonical.com, alexng@microsoft.com,
	Alex Ng <alexng@messages.microsoft.com>
Subject: Re: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.
Date: Tue, 13 Sep 2016 19:38:16 +0200	[thread overview]
Message-ID: <20160913173816.GA29448@aepfle.de> (raw)
In-Reply-To: <1473337454-6097-3-git-send-email-kys@exchange.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

On Thu, Sep 08, kys@exchange.microsoft.com wrote:

> -	default:
> +	case(VERSION_WIN10):
>  		util_fw_version = UTIL_FW_VERSION;
>  		sd_srv_version = SD_VERSION;
>  		ts_srv_version = TS_VERSION;
>  		hb_srv_version = HB_VERSION;
> +		break;
> +	default:
> +		util_fw_version = UTIL_FW_VERSION;
> +		sd_srv_version = SD_VERSION;
> +		ts_srv_version = TS_VERSION_3;
> +		hb_srv_version = HB_VERSION;

Is this correct? An old kernel on a newer host would use the old
protocol. I assume that new host will also know about the old protocol?
Perhaps a better approach would be to list the known existing hosts and
use the new protocol for upcoming, unknown hosts via 'default:'.

Olaf

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

  reply	other threads:[~2016-09-13 17:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 12:23 [PATCH 0/3] Drivers: hv: util: Support the latest time synch protocol from the host kys
2016-09-08 12:24 ` [PATCH 1/3] Drivers: hv: utils: Rename version definitions to reflect protocol version kys
2016-09-08 12:24   ` [PATCH 2/3] Drivers: hv: utils: Use TimeSync samples to adjust the clock after boot kys
2016-09-08 12:24   ` [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples kys
2016-09-13 17:38     ` Olaf Hering [this message]
2016-09-13 18:27       ` Alex Ng (LIS)
2016-09-14 12:57         ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160913173816.GA29448@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=alexng@messages.microsoft.com \
    --cc=alexng@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).