* Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle
@ 2020-06-24 4:11 Phu Luu
2020-06-24 5:03 ` gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Phu Luu @ 2020-06-24 4:11 UTC (permalink / raw)
To: johan, gregkh, linux-usb, linux-kernel; +Cc: Brant Merryman, Richard Hendricks
Assign the .throttle and .unthrottle functions to be generic function
in the driver structure to prevent data loss that can otherwise occur
if the host does not enable USB throttling.
Signed-off-by: Phu Luu An <phu.luu@silabs.com>
Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
---
06/09/2020: Patch v3 1/2 Modified based on feedback from Johan Hovold <johan@kernel.org>
12/18/2019: Patch v2 Broken into two patches and modified based on feedback from Johan Hovold <johan@kernel.org>
12/09/2019: Initial submission of patch "Proper RTS control when buffers fill"
drivers/usb/serial/cp210x.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f5143eedbc48..bcceb4ad8be0 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -272,6 +272,8 @@ static struct usb_serial_driver cp210x_device = {
.break_ctl = cp210x_break_ctl,
.set_termios = cp210x_set_termios,
.tx_empty = cp210x_tx_empty,
+ .throttle = usb_serial_generic_throttle,
+ .unthrottle = usb_serial_generic_unthrottle,
.tiocmget = cp210x_tiocmget,
.tiocmset = cp210x_tiocmset,
.attach = cp210x_attach,
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle
2020-06-24 4:11 Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle Phu Luu
@ 2020-06-24 5:03 ` gregkh
0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2020-06-24 5:03 UTC (permalink / raw)
To: Phu Luu; +Cc: johan, linux-usb, linux-kernel, Brant Merryman, Richard Hendricks
On Wed, Jun 24, 2020 at 04:11:21AM +0000, Phu Luu wrote:
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
>
> Signed-off-by: Phu Luu An <phu.luu@silabs.com>
> Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
Why does your Subject: line have "Subject:" in it again?
Can you please fix up and resend these patches?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-24 5:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-24 4:11 Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle Phu Luu
2020-06-24 5:03 ` gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).