* [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
@ 2021-03-05 9:25 Gustavo A. R. Silva
2021-04-20 20:08 ` Gustavo A. R. Silva
2021-04-21 14:51 ` Xue, Ying
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 9:25 UTC (permalink / raw)
To: Jon Maloy, Ying Xue, David S. Miller, Jakub Kicinski
Cc: netdev, tipc-discussion, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/tipc/link.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/link.c b/net/tipc/link.c
index 115109259430..bcc426e16725 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
break;
case LINK_FAILOVER_BEGIN_EVT:
l->state = LINK_FAILINGOVER;
+ break;
case LINK_FAILURE_EVT:
case LINK_RESET_EVT:
case LINK_ESTABLISH_EVT:
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
2021-03-05 9:25 [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:08 ` Gustavo A. R. Silva
2021-04-21 14:51 ` Xue, Ying
1 sibling, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:08 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jon Maloy, Ying Xue, David S. Miller,
Jakub Kicinski
Cc: netdev, tipc-discussion, linux-kernel, linux-hardening
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:25, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/tipc/link.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/tipc/link.c b/net/tipc/link.c
> index 115109259430..bcc426e16725 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
> break;
> case LINK_FAILOVER_BEGIN_EVT:
> l->state = LINK_FAILINGOVER;
> + break;
> case LINK_FAILURE_EVT:
> case LINK_RESET_EVT:
> case LINK_ESTABLISH_EVT:
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
2021-03-05 9:25 [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:08 ` Gustavo A. R. Silva
@ 2021-04-21 14:51 ` Xue, Ying
2021-05-18 1:09 ` Gustavo A. R. Silva
1 sibling, 1 reply; 4+ messages in thread
From: Xue, Ying @ 2021-04-21 14:51 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jon Maloy, David S. Miller, Jakub Kicinski
Cc: netdev, tipc-discussion, linux-kernel, linux-hardening
This patch looks good to me.
-----Original Message-----
From: Gustavo A. R. Silva <gustavoars@kernel.org>
Sent: Friday, March 5, 2021 5:25 PM
To: Jon Maloy <jmaloy@redhat.com>; Xue, Ying <Ying.Xue@windriver.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>; linux-hardening@vger.kernel.org
Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/tipc/link.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644
--- a/net/tipc/link.c
+++ b/net/tipc/link.c
@@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
break;
case LINK_FAILOVER_BEGIN_EVT:
l->state = LINK_FAILINGOVER;
+ break;
case LINK_FAILURE_EVT:
case LINK_RESET_EVT:
case LINK_ESTABLISH_EVT:
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
2021-04-21 14:51 ` Xue, Ying
@ 2021-05-18 1:09 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-05-18 1:09 UTC (permalink / raw)
To: Xue, Ying, Gustavo A. R. Silva, Jon Maloy, David S. Miller,
Jakub Kicinski
Cc: netdev, tipc-discussion, linux-kernel, linux-hardening
Hi all,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/21/21 09:51, Xue, Ying wrote:
> This patch looks good to me.
>
> -----Original Message-----
> From: Gustavo A. R. Silva <gustavoars@kernel.org>
> Sent: Friday, March 5, 2021 5:25 PM
> To: Jon Maloy <jmaloy@redhat.com>; Xue, Ying <Ying.Xue@windriver.com>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org; Gustavo A. R. Silva <gustavoars@kernel.org>; linux-hardening@vger.kernel.org
> Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/tipc/link.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
> break;
> case LINK_FAILOVER_BEGIN_EVT:
> l->state = LINK_FAILINGOVER;
> + break;
> case LINK_FAILURE_EVT:
> case LINK_RESET_EVT:
> case LINK_ESTABLISH_EVT:
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-18 1:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:25 [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:08 ` Gustavo A. R. Silva
2021-04-21 14:51 ` Xue, Ying
2021-05-18 1:09 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).