From: "Cao, Bingbu" <bingbu.cao@intel.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] media: ov2740: select regmap
Date: Tue, 6 Oct 2020 03:22:35 +0000 [thread overview]
Message-ID: <DM6PR11MB3995D488E86C6AD842AF090E990D0@DM6PR11MB3995.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200930011322.97179-1-sergey.senozhatsky@gmail.com>
Sergey, thanks for your patch.
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
________________________
BRs,
Bingbu Cao
> -----Original Message-----
> From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Sent: Wednesday, September 30, 2020 9:13 AM
> To: Mauro Carvalho Chehab <mchehab@kernel.org>; Cao, Bingbu
> <bingbu.cao@intel.com>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>; linux-media@vger.kernel.org;
> linux-kernel@vger.kernel.org; Sergey Senozhatsky
> <sergey.senozhatsky@gmail.com>
> Subject: [PATCH] media: ov2740: select regmap
>
> Fix OV2740 build breakage by selecting REGMAP_I2C config:
>
> ov2740.c:1011:23: error: variable has incomplete type 'struct regmap_config'
> struct regmap_config regmap_config = { };
> ^
> ov2740.c:1011:9: note: forward declaration of 'struct regmap_config'
> struct regmap_config regmap_config = { };
> ^
> ov2740.c:1028:11: error: implicit declaration of function
> 'devm_regmap_init_i2c'
> regmap = devm_regmap_init_i2c(client, ®map_config);
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
> drivers/media/i2c/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index
> 878f66ef2719..c64326ca331c 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -877,6 +877,7 @@ config VIDEO_OV2740
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> + select REGMAP_I2C
> help
> This is a Video4Linux2 sensor driver for the OmniVision
> OV2740 camera.
> --
> 2.28.0
prev parent reply other threads:[~2020-10-06 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 1:13 [PATCH] media: ov2740: select regmap Sergey Senozhatsky
2020-10-06 3:22 ` Cao, Bingbu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3995D488E86C6AD842AF090E990D0@DM6PR11MB3995.namprd11.prod.outlook.com \
--to=bingbu.cao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).