* [PATCH] scsi: qedf: style: Simplify bool comparison
@ 2021-01-11 9:29 YANG LI
2021-01-11 9:46 ` [EXT] " Saurav Kashyap
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YANG LI @ 2021-01-11 9:29 UTC (permalink / raw)
To: jejb
Cc: martin.petersen, skashyap, jhasan, GR-QLogic-Storage-Upstream,
linux, linux-scsi, linux-kernel, netdev, YANG LI
Fix the following coccicheck warning:
./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci Robot<abaci@linux.alibaba.com>
---
drivers/scsi/qedf/qedf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 46d185c..cec27f2 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int mode)
else
fc_fabric_logoff(qedf->lport);
- if (qedf_wait_for_upload(qedf) == false)
+ if (!qedf_wait_for_upload(qedf))
QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");
#ifdef CONFIG_DEBUG_FS
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison
2021-01-11 9:29 [PATCH] scsi: qedf: style: Simplify bool comparison YANG LI
@ 2021-01-11 9:46 ` Saurav Kashyap
2021-01-13 5:34 ` Martin K. Petersen
2021-01-15 4:08 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Saurav Kashyap @ 2021-01-11 9:46 UTC (permalink / raw)
To: YANG LI, jejb
Cc: martin.petersen, Javed Hasan, GR-QLogic-Storage-Upstream, linux,
linux-scsi, linux-kernel, netdev
Hi,
Thanks for a patch.
> -----Original Message-----
> From: YANG LI <abaci-bugfix@linux.alibaba.com>
> Sent: Monday, January 11, 2021 2:59 PM
> To: jejb@linux.ibm.com
> Cc: martin.petersen@oracle.com; Saurav Kashyap <skashyap@marvell.com>;
> Javed Hasan <jhasan@marvell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@marvell.com>; linux@armlinux.org.uk; linux-
> scsi@vger.kernel.org; linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
> YANG LI <abaci-bugfix@linux.alibaba.com>
> Subject: [EXT] [PATCH] scsi: qedf: style: Simplify bool comparison
>
> External Email
>
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
> ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
> ---
> drivers/scsi/qedf/qedf_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index 46d185c..cec27f2 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -3713,7 +3713,7 @@ static void __qedf_remove(struct pci_dev *pdev, int
> mode)
> else
> fc_fabric_logoff(qedf->lport);
>
> - if (qedf_wait_for_upload(qedf) == false)
> + if (!qedf_wait_for_upload(qedf))
> QEDF_ERR(&qedf->dbg_ctx, "Could not upload all sessions.\n");
>
> #ifdef CONFIG_DEBUG_FS
> --
> 1.8.3.1
Acked-by: Saurav Kashyap <skashyap@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qedf: style: Simplify bool comparison
2021-01-11 9:29 [PATCH] scsi: qedf: style: Simplify bool comparison YANG LI
2021-01-11 9:46 ` [EXT] " Saurav Kashyap
@ 2021-01-13 5:34 ` Martin K. Petersen
2021-01-15 4:08 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-01-13 5:34 UTC (permalink / raw)
To: YANG LI
Cc: jejb, martin.petersen, skashyap, jhasan,
GR-QLogic-Storage-Upstream, linux, linux-scsi, linux-kernel,
netdev
Yang,
> Fix the following coccicheck warning:
> ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: qedf: style: Simplify bool comparison
2021-01-11 9:29 [PATCH] scsi: qedf: style: Simplify bool comparison YANG LI
2021-01-11 9:46 ` [EXT] " Saurav Kashyap
2021-01-13 5:34 ` Martin K. Petersen
@ 2021-01-15 4:08 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-01-15 4:08 UTC (permalink / raw)
To: jejb, YANG LI
Cc: Martin K . Petersen, GR-QLogic-Storage-Upstream, linux, jhasan,
linux-scsi, netdev, linux-kernel, skashyap
On Mon, 11 Jan 2021 17:29:28 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/scsi/qedf/qedf_main.c:3716:5-31: WARNING: Comparison to bool
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: qedf: style: Simplify bool comparison
https://git.kernel.org/mkp/scsi/c/ac341c2d2f1f
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-15 4:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 9:29 [PATCH] scsi: qedf: style: Simplify bool comparison YANG LI
2021-01-11 9:46 ` [EXT] " Saurav Kashyap
2021-01-13 5:34 ` Martin K. Petersen
2021-01-15 4:08 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).