* [PATCH] scsi: qla2xxx: Fix the return value
@ 2020-08-29 7:57 Xianting Tian
2020-08-31 11:41 ` [EXT] " Nilesh Javali
2020-09-09 2:09 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Xianting Tian @ 2020-08-29 7:57 UTC (permalink / raw)
To: njavali, GR-QLogic-Storage-Upstream, jejb, martin.petersen
Cc: linux-scsi, linux-kernel, Xianting Tian
A negative error code should be returned.
Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index fbb80a043..612e001cc 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)
"multiple abort. %p transport_state %x, t_state %x, "
"se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state,
cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags);
- return EIO;
+ return -EIO;
}
cmd->aborted = 1;
cmd->trc_flags |= TRC_ABORT;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
2020-08-29 7:57 [PATCH] scsi: qla2xxx: Fix the return value Xianting Tian
@ 2020-08-31 11:41 ` Nilesh Javali
2020-09-09 2:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Nilesh Javali @ 2020-08-31 11:41 UTC (permalink / raw)
To: Xianting Tian, martin.petersen, jejb, GR-QLogic-Storage-Upstream
Cc: linux-scsi, linux-kernel
Xianting Tian,
Thanks for the patch.
> -----Original Message-----
> From: Xianting Tian <tian.xianting@h3c.com>
> Sent: Saturday, August 29, 2020 1:28 PM
> To: Nilesh Javali <njavali@marvell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@marvell.com>; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Xianting Tian
> <tian.xianting@h3c.com>
> Subject: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
>
> External Email
>
> ----------------------------------------------------------------------
> A negative error code should be returned.
>
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c
> b/drivers/scsi/qla2xxx/qla_target.c
> index fbb80a043..612e001cc 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)
> "multiple abort. %p transport_state %x, t_state %x, "
> "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state,
> cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags);
> - return EIO;
> + return -EIO;
> }
> cmd->aborted = 1;
> cmd->trc_flags |= TRC_ABORT;
> --
> 2.17.1
Acked-by: Nilesh Javali <njavali@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix the return value
2020-08-29 7:57 [PATCH] scsi: qla2xxx: Fix the return value Xianting Tian
2020-08-31 11:41 ` [EXT] " Nilesh Javali
@ 2020-09-09 2:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-09 2:09 UTC (permalink / raw)
To: GR-QLogic-Storage-Upstream, njavali, jejb, Xianting Tian
Cc: Martin K . Petersen, linux-scsi, linux-kernel
On Sat, 29 Aug 2020 15:57:46 +0800, Xianting Tian wrote:
> A negative error code should be returned.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Fix the return value
https://git.kernel.org/mkp/scsi/c/e5f48ac42cc9
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 2:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-29 7:57 [PATCH] scsi: qla2xxx: Fix the return value Xianting Tian
2020-08-31 11:41 ` [EXT] " Nilesh Javali
2020-09-09 2:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).