* [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
@ 2022-03-15 8:24 Abel Vesa
2022-03-15 8:26 ` Peng Fan
2022-03-15 21:45 ` Stephen Boyd
0 siblings, 2 replies; 4+ messages in thread
From: Abel Vesa @ 2022-03-15 8:24 UTC (permalink / raw)
To: Abel Vesa, Mike Turquette, Peng Fan, Stephen Boyd
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-clk,
linux-arm-kernel, Linux Kernel Mailing List, kernel test robot
Most of the i.MX clock generic API is built by selecting MXC_CLK.
Without it, the i.MX93 clock driver will fail to build:
aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
undefined reference to `imx_obtain_fixed_clk_hw'
So fix this by selecting MXC_CLK for the CLK_IMX93.
Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
Reported-by: kernel test robot <lkp@intel.com>
---
drivers/clk/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index cc464a42d646..25785ec9c276 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -109,6 +109,7 @@ config CLK_IMX8ULP
config CLK_IMX93
tristate "IMX93 CCM Clock Driver"
depends on ARCH_MXC || COMPILE_TEST
+ select MXC_CLK
help
Build the driver for i.MX93 CCM Clock Driver
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
2022-03-15 8:24 [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver Abel Vesa
@ 2022-03-15 8:26 ` Peng Fan
2022-03-15 21:11 ` Abel Vesa
2022-03-15 21:45 ` Stephen Boyd
1 sibling, 1 reply; 4+ messages in thread
From: Peng Fan @ 2022-03-15 8:26 UTC (permalink / raw)
To: Abel Vesa, Mike Turquette, Stephen Boyd
Cc: Pengutronix Kernel Team, dl-linux-imx, linux-clk,
linux-arm-kernel, Linux Kernel Mailing List, kernel test robot
> Subject: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
>
> Most of the i.MX clock generic API is built by selecting MXC_CLK.
> Without it, the i.MX93 clock driver will fail to build:
>
> aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
> in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
> undefined reference to `imx_obtain_fixed_clk_hw'
>
> So fix this by selecting MXC_CLK for the CLK_IMX93.
>
> Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/clk/imx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> cc464a42d646..25785ec9c276 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -109,6 +109,7 @@ config CLK_IMX8ULP
> config CLK_IMX93
> tristate "IMX93 CCM Clock Driver"
> depends on ARCH_MXC || COMPILE_TEST
> + select MXC_CLK
> help
> Build the driver for i.MX93 CCM Clock Driver
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
2022-03-15 8:26 ` Peng Fan
@ 2022-03-15 21:11 ` Abel Vesa
0 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2022-03-15 21:11 UTC (permalink / raw)
To: Peng Fan
Cc: Mike Turquette, Stephen Boyd, Pengutronix Kernel Team,
dl-linux-imx, linux-clk, linux-arm-kernel,
Linux Kernel Mailing List, kernel test robot
On 22-03-15 10:26:43, Peng Fan wrote:
> > Subject: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
> >
> > Most of the i.MX clock generic API is built by selecting MXC_CLK.
> > Without it, the i.MX93 clock driver will fail to build:
> >
> > aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
> > in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
> > undefined reference to `imx_obtain_fixed_clk_hw'
> >
> > So fix this by selecting MXC_CLK for the CLK_IMX93.
> >
> > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > Reported-by: kernel test robot <lkp@intel.com>
>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Thanks, Peng.
Stephen, can you please pick this up?
>
> > ---
> > drivers/clk/imx/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> > cc464a42d646..25785ec9c276 100644
> > --- a/drivers/clk/imx/Kconfig
> > +++ b/drivers/clk/imx/Kconfig
> > @@ -109,6 +109,7 @@ config CLK_IMX8ULP
> > config CLK_IMX93
> > tristate "IMX93 CCM Clock Driver"
> > depends on ARCH_MXC || COMPILE_TEST
> > + select MXC_CLK
> > help
> > Build the driver for i.MX93 CCM Clock Driver
> >
> > --
> > 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver
2022-03-15 8:24 [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver Abel Vesa
2022-03-15 8:26 ` Peng Fan
@ 2022-03-15 21:45 ` Stephen Boyd
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2022-03-15 21:45 UTC (permalink / raw)
To: Abel Vesa, Mike Turquette, Peng Fan
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-clk,
linux-arm-kernel, Linux Kernel Mailing List, kernel test robot
Quoting Abel Vesa (2022-03-15 01:24:46)
> Most of the i.MX clock generic API is built by selecting MXC_CLK.
> Without it, the i.MX93 clock driver will fail to build:
>
> aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
> in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
> undefined reference to `imx_obtain_fixed_clk_hw'
>
> So fix this by selecting MXC_CLK for the CLK_IMX93.
>
> Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-15 21:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-15 8:24 [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver Abel Vesa
2022-03-15 8:26 ` Peng Fan
2022-03-15 21:11 ` Abel Vesa
2022-03-15 21:45 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).