[PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
compatible.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V2:
 Rebased on linux-next, remove power-domains from v1

 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index be36956af53b..fefd6610ab45 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -30,11 +30,13 @@ allOf:
 
 properties:
   compatible:
-    contains:
-      oneOf:
-        - const: snps,dwc3
-        - const: synopsys,dwc3
-          deprecated: true
+    oneOf:
+      - items:
+          - const: fsl,imx8mq-dwc3
+          - const: snps,dwc3
+      - const: snps,dwc3
+      - const: synopsys,dwc3
+        deprecated: true
 
   reg:
     maxItems: 1
-- 
2.37.1

Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Rob Herring]

On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> compatible.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V2:
>  Rebased on linux-next, remove power-domains from v1
> 
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3399-dwc3', 'snps,dwc3'] is too long
	'fsl,imx8mq-dwc3' was expected
	'snps,dwc3' was expected
	'synopsys,dwc3' was expected
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: Unevaluated properties are not allowed ('compatible' was unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3399-dwc3', 'snps,dwc3'] is too long
	'fsl,imx8mq-dwc3' was expected
	'snps,dwc3' was expected
	'synopsys,dwc3' was expected
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: Unevaluated properties are not allowed ('compatible' was unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: Unevaluated properties are not allowed ('dr_mode' was unexpected)
	From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230203014526.1461386-1-peng.fan@oss.nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

RE: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Peng Fan]

Hi Rob,

> Subject: Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> 
> 
> On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> > compatible.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > V2:
> >  Rebased on linux-next, remove power-domains from v1
> >
> >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12
> > +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> >
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m
> dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:

The error is not related my patch, I could help add rochchip and LSx support later,
this patch is just for i.MX8MQ.

Thanks,
Peng.
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.d
> tb: usb@fe800000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['rockchip,rk3399-dwc3', 'snps,dwc3'] is too long
> 	'fsl,imx8mq-dwc3' was expected
> 	'snps,dwc3' was expected
> 	'synopsys,dwc3' was expected
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.d
> tb: usb@fe800000: Unevaluated properties are not allowed ('compatible'
> was unexpected)
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.d
> tb: usb@fe800000: compatible: 'oneOf' conditional failed, one must be fixed:
> 	['rockchip,rk3399-dwc3', 'snps,dwc3'] is too long
> 	'fsl,imx8mq-dwc3' was expected
> 	'snps,dwc3' was expected
> 	'synopsys,dwc3' was expected
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.d
> tb: usb@fe800000: Unevaluated properties are not allowed ('compatible'
> was unexpected)
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
> /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.d
> tb: usb@fe800000: Unevaluated properties are not allowed ('dr_mode' was
> unexpected)
> 	From schema: /builds/robherring/dt-review-
> ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
> hwork.ozlabs.org%2Fproject%2Fdevicetree-
> bindings%2Fpatch%2F20230203014526.1461386-1-
> peng.fan%40oss.nxp.com&data=05%7C01%7Cpeng.fan%40nxp.com%7Cee5
> 16452b425433a617808db05edd0a4%7C686ea1d3bc2b4c6fa92cd99c5c30163
> 5%7C0%7C0%7C638110291187788208%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000%7C%7C%7C&sdata=K6Ys5viPQON7rwwF5Vf29oBSYHWxuP3X%2Fm
> Bl29S%2FQ7U%3D&reserved=0
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself.
> Note that DT_SCHEMA_FILES can be set to your schema file to speed up
> checking your schema. However, it must be unset to test all examples with
> your schema.

RE: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Peng Fan]

Ping..

> Subject: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> compatible.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V2:
>  Rebased on linux-next, remove power-domains from v1
> 
>  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> index be36956af53b..fefd6610ab45 100644
> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
> @@ -30,11 +30,13 @@ allOf:
> 
>  properties:
>    compatible:
> -    contains:
> -      oneOf:
> -        - const: snps,dwc3
> -        - const: synopsys,dwc3
> -          deprecated: true
> +    oneOf:
> +      - items:
> +          - const: fsl,imx8mq-dwc3
> +          - const: snps,dwc3
> +      - const: snps,dwc3
> +      - const: synopsys,dwc3
> +        deprecated: true
> 
>    reg:
>      maxItems: 1
> --
> 2.37.1

Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Krzysztof Kozlowski]

On 03/02/2023 02:45, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> compatible.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Rob Herring]

On Fri, Feb 3, 2023 at 5:49 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Rob,
>
> > Subject: Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> >
> >
> > On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> > > compatible.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > V2:
> > >  Rebased on linux-next, remove power-domains from v1
> > >
> > >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12
> > > +++++++-----
> > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
>
> The error is not related my patch, I could help add rochchip and LSx support later,
> this patch is just for i.MX8MQ.

It is related. You must pass 'make dt_binding_check' without setting
DT_SCHEMA_FILES. Your schema is being applied to the
rockchip,dwc3.yaml example. Most likely you need a custom 'select'
entry to avoid applying to all 'snps,dwc3' compatibles.

Rob

Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

[Rob Herring]

On Tue, Mar 14, 2023 at 1:56 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Feb 3, 2023 at 5:49 PM Peng Fan <peng.fan@nxp.com> wrote:
> >
> > Hi Rob,
> >
> > > Subject: Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ
> > >
> > >
> > > On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> > > > compatible.
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > ---
> > > >
> > > > V2:
> > > >  Rebased on linux-next, remove power-domains from v1
> > > >
> > > >  Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12
> > > > +++++++-----
> > > >  1 file changed, 7 insertions(+), 5 deletions(-)
> > > >
> > >
> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m
> > > dt_binding_check'
> > > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > >
> > > yamllint warnings/errors:
> >
> > The error is not related my patch, I could help add rochchip and LSx support later,
> > this patch is just for i.MX8MQ.
>
> It is related. You must pass 'make dt_binding_check' without setting
> DT_SCHEMA_FILES. Your schema is being applied to the
> rockchip,dwc3.yaml example. Most likely you need a custom 'select'
> entry to avoid applying to all 'snps,dwc3' compatibles.

This is now failing in linux-next. Please send an incremental fix.

Rob