* [PATCH] Input: elan_i2c - Use iap_version to get firmware information
@ 2015-09-02 1:03 duson
2015-09-03 16:57 ` Dmitry Torokhov
0 siblings, 1 reply; 6+ messages in thread
From: duson @ 2015-09-02 1:03 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, dusonlin
When driver get exception ic type (0xFF), maybe occurred from wrong
I2C protocol communication, system crash or other unknown situation,
instead of ic_type we use iap_version to get firmware information.
Signed-off-by: Duson Lin <dusonlin@emc.com.tw>
---
drivers/input/mouse/elan_i2c_core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index 5b5f403..d99d40c 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -4,7 +4,7 @@
* Copyright (c) 2013 ELAN Microelectronics Corp.
*
* Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
- * Version: 1.5.9
+ * Version: 1.6.0
*
* Based on cyapa driver:
* copyright (c) 2011-2012 Cypress Semiconductor, Inc.
@@ -40,7 +40,7 @@
#include "elan_i2c.h"
#define DRIVER_NAME "elan_i2c"
-#define ELAN_DRIVER_VERSION "1.5.9"
+#define ELAN_DRIVER_VERSION "1.6.0"
#define ETP_MAX_PRESSURE 255
#define ETP_FWIDTH_REDUCE 90
#define ETP_FINGER_WIDTH 15
@@ -261,11 +261,11 @@ static int elan_query_device_info(struct elan_tp_data *data)
if (error)
return error;
- error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
+ error = elan_get_fwinfo(data->iap_version, &data->fw_vaildpage_count,
&data->fw_signature_address);
if (error) {
dev_err(&data->client->dev,
- "unknown ic type %d\n", data->ic_type);
+ "unknown ic type %d\n", data->iap_version);
return error;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Input: elan_i2c - Use iap_version to get firmware information
2015-09-02 1:03 [PATCH] Input: elan_i2c - Use iap_version to get firmware information duson
@ 2015-09-03 16:57 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2015-09-03 16:57 UTC (permalink / raw)
To: duson; +Cc: linux-input, linux-kernel
On Wed, Sep 02, 2015 at 09:03:46AM +0800, duson wrote:
> When driver get exception ic type (0xFF), maybe occurred from wrong
> I2C protocol communication, system crash or other unknown situation,
> instead of ic_type we use iap_version to get firmware information.
>
> Signed-off-by: Duson Lin <dusonlin@emc.com.tw>
> ---
> drivers/input/mouse/elan_i2c_core.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
> index 5b5f403..d99d40c 100644
> --- a/drivers/input/mouse/elan_i2c_core.c
> +++ b/drivers/input/mouse/elan_i2c_core.c
> @@ -4,7 +4,7 @@
> * Copyright (c) 2013 ELAN Microelectronics Corp.
> *
> * Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
> - * Version: 1.5.9
> + * Version: 1.6.0
> *
> * Based on cyapa driver:
> * copyright (c) 2011-2012 Cypress Semiconductor, Inc.
> @@ -40,7 +40,7 @@
> #include "elan_i2c.h"
>
> #define DRIVER_NAME "elan_i2c"
> -#define ELAN_DRIVER_VERSION "1.5.9"
> +#define ELAN_DRIVER_VERSION "1.6.0"
> #define ETP_MAX_PRESSURE 255
> #define ETP_FWIDTH_REDUCE 90
> #define ETP_FINGER_WIDTH 15
> @@ -261,11 +261,11 @@ static int elan_query_device_info(struct elan_tp_data *data)
> if (error)
> return error;
>
> - error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
> + error = elan_get_fwinfo(data->iap_version, &data->fw_vaildpage_count,
> &data->fw_signature_address);
> if (error) {
> dev_err(&data->client->dev,
> - "unknown ic type %d\n", data->ic_type);
> + "unknown ic type %d\n", data->iap_version);
Applied but changed the working here to "unknown iap version" and also
changed argument name in elan_get_fwinfo.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Input: elan_i2c - Use iap_version to get firmware information
2015-09-02 0:45 duson
@ 2015-09-02 0:55 ` DusonLin
0 siblings, 0 replies; 6+ messages in thread
From: DusonLin @ 2015-09-02 0:55 UTC (permalink / raw)
To: 'Dmitry Torokhov'; +Cc: linux-input, linux-kernel
Hi Dmitry,
Please ignore this patch, I will send a right again. Thank you.
Duson
-----Original Message-----
From: duson [mailto:dusonlin@emc.com.tw]
Sent: Wednesday, September 02, 2015 8:45 AM
To: Dmitry Torokhov
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; dusonlin@emc.
com.tw
Subject: [PATCH] Input: elan_i2c - Use iap_version to get firmware
information
When driver get exception ic type (0xFF), maybe occurred from wrong I2C
protocol communication, system crash or other unknown situation, instead of
ic_type we use iap_version to get firmware information.
Signed-off-by: Duson Lin <dusonlin@emc.com.tw>
---
drivers/input/mouse/elan_i2c_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/mouse/elan_i2c_core.c
index 5b5f403..494858c 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -4,7 +4,7 @@
* Copyright (c) 2013 ELAN Microelectronics Corp.
*
* Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
- * Version: 1.5.9
+ * Version: 1.6.0
*
* Based on cyapa driver:
* copyright (c) 2011-2012 Cypress Semiconductor, Inc.
@@ -40,7 +40,7 @@
#include "elan_i2c.h"
#define DRIVER_NAME "elan_i2c"
-#define ELAN_DRIVER_VERSION "1.5.9"
+#define ELAN_DRIVER_VERSION "1.6.0"
#define ETP_MAX_PRESSURE 255
#define ETP_FWIDTH_REDUCE 90
#define ETP_FINGER_WIDTH 15
@@ -261,7 +261,7 @@ static int elan_query_device_info(struct elan_tp_data
*data)
if (error)
return error;
- error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
+ error = elan_get_fwinfo(data->iap_version,
&data->fw_vaildpage_count,
&data->fw_signature_address);
if (error) {
dev_err(&data->client->dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] Input: elan_i2c - Use iap_version to get firmware information
2015-09-02 0:38 duson
@ 2015-09-02 0:55 ` DusonLin
0 siblings, 0 replies; 6+ messages in thread
From: DusonLin @ 2015-09-02 0:55 UTC (permalink / raw)
To: 'Dmitry Torokhov'; +Cc: linux-input, linux-kernel
Hi Dmitry,
Please ignore this patch, I will send a right again. Thank you.
Duson
-----Original Message-----
From: duson [mailto:dusonlin@emc.com.tw]
Sent: Wednesday, September 02, 2015 8:38 AM
To: Dmitry Torokhov
Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; dusonlin@emc.
com.tw
Subject: [PATCH] Input: elan_i2c - Use iap_version to get firmware
information
When driver get exception ic type (0xFF), maybe occurred from wrong I2C
protocol communication, system crash or other unknown situation, instead of
ic_type we use iap_version to get firmware information.
---
drivers/input/mouse/elan_i2c_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c
b/drivers/input/mouse/elan_i2c_core.c
index 5b5f403..494858c 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -4,7 +4,7 @@
* Copyright (c) 2013 ELAN Microelectronics Corp.
*
* Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
- * Version: 1.5.9
+ * Version: 1.6.0
*
* Based on cyapa driver:
* copyright (c) 2011-2012 Cypress Semiconductor, Inc.
@@ -40,7 +40,7 @@
#include "elan_i2c.h"
#define DRIVER_NAME "elan_i2c"
-#define ELAN_DRIVER_VERSION "1.5.9"
+#define ELAN_DRIVER_VERSION "1.6.0"
#define ETP_MAX_PRESSURE 255
#define ETP_FWIDTH_REDUCE 90
#define ETP_FINGER_WIDTH 15
@@ -261,7 +261,7 @@ static int elan_query_device_info(struct elan_tp_data
*data)
if (error)
return error;
- error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
+ error = elan_get_fwinfo(data->iap_version,
&data->fw_vaildpage_count,
&data->fw_signature_address);
if (error) {
dev_err(&data->client->dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Input: elan_i2c - Use iap_version to get firmware information
@ 2015-09-02 0:45 duson
2015-09-02 0:55 ` DusonLin
0 siblings, 1 reply; 6+ messages in thread
From: duson @ 2015-09-02 0:45 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, dusonlin
When driver get exception ic type (0xFF), maybe occurred from wrong
I2C protocol communication, system crash or other unknown situation,
instead of ic_type we use iap_version to get firmware information.
Signed-off-by: Duson Lin <dusonlin@emc.com.tw>
---
drivers/input/mouse/elan_i2c_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index 5b5f403..494858c 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -4,7 +4,7 @@
* Copyright (c) 2013 ELAN Microelectronics Corp.
*
* Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
- * Version: 1.5.9
+ * Version: 1.6.0
*
* Based on cyapa driver:
* copyright (c) 2011-2012 Cypress Semiconductor, Inc.
@@ -40,7 +40,7 @@
#include "elan_i2c.h"
#define DRIVER_NAME "elan_i2c"
-#define ELAN_DRIVER_VERSION "1.5.9"
+#define ELAN_DRIVER_VERSION "1.6.0"
#define ETP_MAX_PRESSURE 255
#define ETP_FWIDTH_REDUCE 90
#define ETP_FINGER_WIDTH 15
@@ -261,7 +261,7 @@ static int elan_query_device_info(struct elan_tp_data *data)
if (error)
return error;
- error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
+ error = elan_get_fwinfo(data->iap_version, &data->fw_vaildpage_count,
&data->fw_signature_address);
if (error) {
dev_err(&data->client->dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] Input: elan_i2c - Use iap_version to get firmware information
@ 2015-09-02 0:38 duson
2015-09-02 0:55 ` DusonLin
0 siblings, 1 reply; 6+ messages in thread
From: duson @ 2015-09-02 0:38 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, linux-kernel, dusonlin
When driver get exception ic type (0xFF), maybe occurred from wrong
I2C protocol communication, system crash or other unknown situation,
instead of ic_type we use iap_version to get firmware information.
---
drivers/input/mouse/elan_i2c_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c
index 5b5f403..494858c 100644
--- a/drivers/input/mouse/elan_i2c_core.c
+++ b/drivers/input/mouse/elan_i2c_core.c
@@ -4,7 +4,7 @@
* Copyright (c) 2013 ELAN Microelectronics Corp.
*
* Author: 林政維 (Duson Lin) <dusonlin@emc.com.tw>
- * Version: 1.5.9
+ * Version: 1.6.0
*
* Based on cyapa driver:
* copyright (c) 2011-2012 Cypress Semiconductor, Inc.
@@ -40,7 +40,7 @@
#include "elan_i2c.h"
#define DRIVER_NAME "elan_i2c"
-#define ELAN_DRIVER_VERSION "1.5.9"
+#define ELAN_DRIVER_VERSION "1.6.0"
#define ETP_MAX_PRESSURE 255
#define ETP_FWIDTH_REDUCE 90
#define ETP_FINGER_WIDTH 15
@@ -261,7 +261,7 @@ static int elan_query_device_info(struct elan_tp_data *data)
if (error)
return error;
- error = elan_get_fwinfo(data->ic_type, &data->fw_vaildpage_count,
+ error = elan_get_fwinfo(data->iap_version, &data->fw_vaildpage_count,
&data->fw_signature_address);
if (error) {
dev_err(&data->client->dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-03 16:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-02 1:03 [PATCH] Input: elan_i2c - Use iap_version to get firmware information duson
2015-09-03 16:57 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2015-09-02 0:45 duson
2015-09-02 0:55 ` DusonLin
2015-09-02 0:38 duson
2015-09-02 0:55 ` DusonLin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).