linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@arcor.de>
To: Richard Zidlicky <rz@linux-m68k.org>,
	Roman Zippel <zippel@linux-m68k.org>
Cc: Linux m68k <linux-m68k@lists.linux-m68k.org>,
	linux-kernel@vger.kernel.org
Subject: Re: 2.4 mm trouble [possible lru race]
Date: Tue, 1 Oct 2002 12:26:42 +0200	[thread overview]
Message-ID: <E17wKEl-0005tB-00@starship> (raw)
In-Reply-To: <20021001112229.A235@linux-m68k.org>

The theoretical lru race possibly spotted in the wild...

On Tuesday 01 October 2002 11:22, Richard Zidlicky wrote:
> On Sat, Sep 28, 2002 at 04:38:50PM +0200, Roman Zippel wrote:
> > Hi,
> > 
> > On Wed, 25 Sep 2002, Richard Zidlicky wrote:
> > 
> > > First I suspected a stale TLB entry so I've added pretty many
> > > extra flushes througout the code. This does very much reduce the
> > > risk of the problem, but the problem still happens if swapping is
> > > increased so it might very well be something else.
> > >
> > > Any ideas?
> > 
> > It sounds like a cache problem. I had to fix one early 2.4, so maybe there
> > is another one.
> > It would help a lot if you could reproduce it within gdb to get some more
> > information about the context of the crash (e.g. invalid data or code, the
> > type of mapping (from /proc/<pid>/maps)).
> 
> hm, I am now testing the appended patch, which is a backport to 2.4.19
> of this:
> 
<<<<<<<<<<<<
>
> From: Daniel Phillips <phillips@arcor.de>
> To: Marcelo Tosatti <marcelo@conectiva.com.br>,
>         "Christian Ehrhardt" <ehrhardt@mathematik.uni-ulm.de>
> Subject: [CFT] [PATCH] LRU race fix
> Date: 	Tue, 17 Sep 2002 19:03:19 +0200
> X-Mailer: KMail [version 1.3.2]
> Cc: <linux-kernel@vger.kernel.org>
> 
> This patch against 2.4.20-pre7 fixes a theoretical race where a page could
> possibly be freed while still on the lru list.  The details have been
> discussed at length earlier, see "[RFC] [PATCH] Include LRU in page count".
> 
> The race may not even be that theoretical, it's just so rare that when it
> does happen, it might be dismissed as a driver problem or similar...
>
> [...]
>
>>>>>>>>>>>>

> Somehow this does completely fix my problem, I have taken out all
> the tlb related hacks and the testcase that caused the problem 100%
> now runs without any sign of problems :))
>
> Now I am wondering if that is just coincidence or why m68k hit that 
> error so reliably.. is it supposed to have any effect at all on
> UP?

Are you running UP+preempt?

-- 
Daniel

       reply	other threads:[~2002-10-01 10:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20020925122439.C198@linux-m68k.org>
     [not found] ` <Pine.LNX.4.44.0209281634240.338-100000@serv>
     [not found]   ` <20021001112229.A235@linux-m68k.org>
2002-10-01 10:26     ` Daniel Phillips [this message]
2002-10-01 14:20 Richard.Zidlicky
2002-10-01 15:12 ` Daniel Phillips
2002-10-01 15:29 ` Daniel Phillips
2002-10-01 16:56   ` Rik van Riel
2002-10-01 17:10     ` Daniel Phillips
2002-10-01 17:31       ` Jens Axboe
2002-10-01 18:01         ` Daniel Phillips
2002-10-01 18:04           ` Jens Axboe
2002-10-01 18:14             ` Daniel Phillips
2002-10-01 18:22               ` Rik van Riel
2002-10-02 12:07               ` Geert Uytterhoeven
2002-10-02  9:45           ` Richard Zidlicky
2002-10-20 14:37 Richard Zidlicky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E17wKEl-0005tB-00@starship \
    --to=phillips@arcor.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=rz@linux-m68k.org \
    --cc=zippel@linux-m68k.org \
    --subject='Re: 2.4 mm trouble [possible lru race]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).