* checkpatch gives false positives for include/trace/events/*.h
@ 2011-06-06 13:56 Theodore Ts'o
0 siblings, 0 replies; only message in thread
From: Theodore Ts'o @ 2011-06-06 13:56 UTC (permalink / raw)
To: Andy Whitcroft, linux-kernel
The format used for trace/events/*.h files makes checkpatch very
unhappy.
Fortunately the trivial patch brigade haven't (yet) started sending
pointless patches to fix checkpatch "errors".
- Ted
ERROR: space prohibited after that open parenthesis '('
#64: FILE: include/trace/events/ext4.h:29:
+ __field( __u64, blocks )
ERROR: space prohibited before that close parenthesis ')'
#64: FILE: include/trace/events/ext4.h:29:
+ __field( __u64, blocks )
ERROR: space prohibited after that open parenthesis '('
#224: FILE: include/trace/events/ext4.h:649:
+ __field( __u32, logical )
ERROR: space prohibited before that close parenthesis ')'
#224: FILE: include/trace/events/ext4.h:649:
+ __field( __u32, logical )
ERROR: space prohibited after that open parenthesis '('
#225: FILE: include/trace/events/ext4.h:650:
+ __field( __u32, lleft )
ERROR: space prohibited before that close parenthesis ')'
#225: FILE: include/trace/events/ext4.h:650:
+ __field( __u32, lleft )
ERROR: space prohibited after that open parenthesis '('
#226: FILE: include/trace/events/ext4.h:651:
+ __field( __u32, lright )
ERROR: space prohibited before that close parenthesis ')'
#226: FILE: include/trace/events/ext4.h:651:
+ __field( __u32, lright )
ERROR: space prohibited after that open parenthesis '('
#262: FILE: include/trace/events/ext4.h:690:
+ __field( __u32, logical )
ERROR: space prohibited before that close parenthesis ')'
#262: FILE: include/trace/events/ext4.h:690:
+ __field( __u32, logical )
ERROR: space prohibited after that open parenthesis '('
#263: FILE: include/trace/events/ext4.h:691:
+ __field( __u32, lleft )
ERROR: space prohibited before that close parenthesis ')'
#263: FILE: include/trace/events/ext4.h:691:
+ __field( __u32, lleft )
ERROR: space prohibited after that open parenthesis '('
#264: FILE: include/trace/events/ext4.h:692:
+ __field( __u32, lright )
ERROR: space prohibited before that close parenthesis ')'
#264: FILE: include/trace/events/ext4.h:692:
+ __field( __u32, lright )
ERROR: space prohibited after that open parenthesis '('
#300: FILE: include/trace/events/ext4.h:730:
+ __field( umode_t, mode )
ERROR: space prohibited before that close parenthesis ')'
#300: FILE: include/trace/events/ext4.h:730:
+ __field( umode_t, mode )
ERROR: space prohibited after that open parenthesis '('
#304: FILE: include/trace/events/ext4.h:733:
+ __field( int, flags )
ERROR: space prohibited before that close parenthesis ')'
#304: FILE: include/trace/events/ext4.h:733:
+ __field( int, flags )
ERROR: space prohibited after that open parenthesis '('
#420: FILE: include/trace/events/ext4.h:1288:
+ __field( unsigned int, blocks )
ERROR: space prohibited before that close parenthesis ')'
#420: FILE: include/trace/events/ext4.h:1288:
+ __field( unsigned int, blocks )
ERROR: space prohibited after that open parenthesis '('
#460: FILE: include/trace/events/ext4.h:1363:
+ __field( __u64, blocks )
ERROR: space prohibited before that close parenthesis ')'
#460: FILE: include/trace/events/ext4.h:1363:
+ __field( __u64, blocks )
ERROR: space prohibited after that open parenthesis '('
#491: FILE: include/trace/events/ext4.h:1401:
+ __field( unsigned int, len )
ERROR: space prohibited before that close parenthesis ')'
#491: FILE: include/trace/events/ext4.h:1401:
+ __field( unsigned int, len )
ERROR: space prohibited after that open parenthesis '('
#492: FILE: include/trace/events/ext4.h:1402:
+ __field( unsigned int, flags )
ERROR: space prohibited before that close parenthesis ')'
#492: FILE: include/trace/events/ext4.h:1402:
+ __field( unsigned int, flags )
ERROR: space prohibited after that open parenthesis '('
#519: FILE: include/trace/events/ext4.h:1444:
+ __field( unsigned int, len )
ERROR: space prohibited before that close parenthesis ')'
#519: FILE: include/trace/events/ext4.h:1444:
+ __field( unsigned int, len )
total: 28 errors, 0 warnings, 468 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-06-06 13:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-06 13:56 checkpatch gives false positives for include/trace/events/*.h Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).