[PATCH 0/2] ASoC: cq93vc: enable compiling on COMPILE_TEST

[PATCH 0/2] ASoC: cq93vc: enable compiling on COMPILE_TEST

[Kuninori Morimoto]

Hi Lee, Mark

Current cq93vc sound codec indicates that it has
MFD_DAVINCI_VOICECODEC dependency, but it doesn't.
This means we can compile it from non DAVINCE environment
by COMPILE_TEST.
These patches solve this issue.
I tested this on ARCH=x86 + make allyesconfig, and
ARCH=ARM + shmobile_defconfig + COMPILE_TEST.

Kuninori Morimoto (2):
      mfd: davinci_voicecodec: tidyup header difinitions
      ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for CQ0093VC

 drivers/mfd/davinci_voicecodec.c       | 1 +
 include/linux/mfd/davinci_voicecodec.h | 4 ----
 sound/soc/codecs/Kconfig               | 2 +-
 3 files changed, 2 insertions(+), 5 deletions(-)

-- 
1.9.1

[PATCH 1/2] mfd: davinci_voicecodec: tidyup header difinitions

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

mach/hardware.h is needed on C source code side, not header.
And struct davinci_vc is duplicated definition.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/mfd/davinci_voicecodec.c       | 1 +
 include/linux/mfd/davinci_voicecodec.h | 4 ----
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/mfd/davinci_voicecodec.c b/drivers/mfd/davinci_voicecodec.c
index dff2f19..4d0a5f3 100644
--- a/drivers/mfd/davinci_voicecodec.c
+++ b/drivers/mfd/davinci_voicecodec.c
@@ -32,6 +32,7 @@
 #include <sound/pcm.h>
 
 #include <linux/mfd/davinci_voicecodec.h>
+#include <mach/hardware.h>
 
 static const struct regmap_config davinci_vc_regmap = {
 	.reg_bits = 32,
diff --git a/include/linux/mfd/davinci_voicecodec.h b/include/linux/mfd/davinci_voicecodec.h
index 8e1cdbe..2c0127c 100644
--- a/include/linux/mfd/davinci_voicecodec.h
+++ b/include/linux/mfd/davinci_voicecodec.h
@@ -28,8 +28,6 @@
 #include <linux/mfd/core.h>
 #include <linux/platform_data/edma.h>
 
-#include <mach/hardware.h>
-
 struct regmap;
 
 /*
@@ -99,8 +97,6 @@ struct davinci_vcif {
 	dma_addr_t dma_rx_addr;
 };
 
-struct davinci_vc;
-
 struct davinci_vc {
 	/* Device data */
 	struct device *dev;
-- 
1.9.1

[PATCH 2/2] ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency from CQ0093VC

[Kuninori Morimoto]

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

CQ0093VC is no longer dependent on MFD_DAVINCI_VOICECODEC,
let's remove it. Otherwise, we can't compile it by COMPILE_TEST
on non-DAVINCE platform

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index b3fd110..a892937 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -45,7 +45,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_ALC5623 if I2C
 	select SND_SOC_ALC5632 if I2C
 	select SND_SOC_BT_SCO
-	select SND_SOC_CQ0093VC if MFD_DAVINCI_VOICECODEC
+	select SND_SOC_CQ0093VC
 	select SND_SOC_CS35L32 if I2C
 	select SND_SOC_CS35L33 if I2C
 	select SND_SOC_CS42L51_I2C if I2C
-- 
1.9.1

Re: [PATCH 2/2] ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency from CQ0093VC

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Thu, Oct 27, 2016 at 08:38:45AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> CQ0093VC is no longer dependent on MFD_DAVINCI_VOICECODEC,
> let's remove it. Otherwise, we can't compile it by COMPILE_TEST
> on non-DAVINCE platform

Acked-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH 1/2] mfd: davinci_voicecodec: tidyup header difinitions

[Lee Jones]

On Thu, 27 Oct 2016, Kuninori Morimoto wrote:

> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Please use `git send-mail` to submit your patches.

> mach/hardware.h is needed on C source code side, not header.
> And struct davinci_vc is duplicated definition.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/mfd/davinci_voicecodec.c       | 1 +
>  include/linux/mfd/davinci_voicecodec.h | 4 ----
>  2 files changed, 1 insertion(+), 4 deletions(-)

Nice.

Applied, thanks.

> diff --git a/drivers/mfd/davinci_voicecodec.c b/drivers/mfd/davinci_voicecodec.c
> index dff2f19..4d0a5f3 100644
> --- a/drivers/mfd/davinci_voicecodec.c
> +++ b/drivers/mfd/davinci_voicecodec.c
> @@ -32,6 +32,7 @@
>  #include <sound/pcm.h>
>  
>  #include <linux/mfd/davinci_voicecodec.h>
> +#include <mach/hardware.h>
>  
>  static const struct regmap_config davinci_vc_regmap = {
>  	.reg_bits = 32,
> diff --git a/include/linux/mfd/davinci_voicecodec.h b/include/linux/mfd/davinci_voicecodec.h
> index 8e1cdbe..2c0127c 100644
> --- a/include/linux/mfd/davinci_voicecodec.h
> +++ b/include/linux/mfd/davinci_voicecodec.h
> @@ -28,8 +28,6 @@
>  #include <linux/mfd/core.h>
>  #include <linux/platform_data/edma.h>
>  
> -#include <mach/hardware.h>
> -
>  struct regmap;
>  
>  /*
> @@ -99,8 +97,6 @@ struct davinci_vcif {
>  	dma_addr_t dma_rx_addr;
>  };
>  
> -struct davinci_vc;
> -
>  struct davinci_vc {
>  	/* Device data */
>  	struct device *dev;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 0/2] ASoC: cq93vc: enable compiling on COMPILE_TEST

[Lee Jones]

On Thu, 24 Nov 2016, Kuninori Morimoto wrote:

> 
> Hi Lee, Mark
> 
> > > Current cq93vc sound codec indicates that it has
> > > MFD_DAVINCI_VOICECODEC dependency, but it doesn't.
> > > This means we can compile it from non DAVINCE environment
> > > by COMPILE_TEST.
> > > These patches solve this issue.
> > > I tested this on ARCH=x86 + make allyesconfig, and
> > > ARCH=ARM + shmobile_defconfig + COMPILE_TEST.
> > > 
> > > Kuninori Morimoto (2):
> > >       mfd: davinci_voicecodec: tidyup header difinitions
> > >       ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for CQ0093VC
> > 
> > I know [2/2] had Acked-by from Mark, and [1/2] was accepted by Lee.
> > I could find [1/2] patch on linux-next tree today.
> > But, I'm afraid I can't find [2/2] patch on linux-next.
> 
> I mean, I (and Mark too?) thought Lee can handle [2/2] patch,
> but it seems not (?). So, my question is who can handle it ?

I didn't see anything build-time dependant.

Unless I missed something?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Applied "ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for CQ0093VC" to the asoc tree

[Mark Brown]

The patch

   ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for CQ0093VC

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 4de429888c5b534f43a3d693e3627021b17e900c Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Fri, 2 Dec 2016 04:01:22 +0000
Subject: [PATCH] ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for
 CQ0093VC

CQ0093VC is no longer dependent on MFD_DAVINCI_VOICECODEC,
let's remove it. Otherwise, we can't compile it by COMPILE_TEST
on non-DAVINCE platform

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index c67667bb970f..cb195b07e7d2 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -45,7 +45,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_ALC5623 if I2C
 	select SND_SOC_ALC5632 if I2C
 	select SND_SOC_BT_SCO
-	select SND_SOC_CQ0093VC if MFD_DAVINCI_VOICECODEC
+	select SND_SOC_CQ0093VC
 	select SND_SOC_CS35L32 if I2C
 	select SND_SOC_CS35L33 if I2C
 	select SND_SOC_CS42L51_I2C if I2C
-- 
2.10.2