* Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device [not found] <20190723002052.2878847-1-vijaykhemka@fb.com> @ 2019-07-23 2:18 ` Joel Stanley 2019-07-23 14:50 ` Rob Herring 1 sibling, 0 replies; 6+ messages in thread From: Joel Stanley @ 2019-07-23 2:18 UTC (permalink / raw) To: Vijay Khemka Cc: Rob Herring, Mark Rutland, Jiri Kosina, Guenter Roeck, Herbert Xu, Patrick Venture, Ard Biesheuvel, Anson Huang, Jeremy Gebben, devicetree, Linux Kernel Mailing List, openbmc @ lists . ozlabs . org, linux-aspeed, Sai Dasari On Tue, 23 Jul 2019 at 00:46, Vijay Khemka <vijaykhemka@fb.com> wrote: > > The pxe1610 is a voltage regulator from Infineon. It also supports > other VRs pxe1110 and pxm1310 from Infineon. > > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> Acked-by: Joel Stanley <joel@jms.id.au> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device [not found] <20190723002052.2878847-1-vijaykhemka@fb.com> 2019-07-23 2:18 ` [PATCH] dt-bindings: Add pxe1610 as a trivial device Joel Stanley @ 2019-07-23 14:50 ` Rob Herring 2019-07-23 14:52 ` Rob Herring 1 sibling, 1 reply; 6+ messages in thread From: Rob Herring @ 2019-07-23 14:50 UTC (permalink / raw) To: Vijay Khemka Cc: Mark Rutland, Jiri Kosina, Guenter Roeck, Herbert Xu, Patrick Venture, Ard Biesheuvel, Anson Huang, Jeremy Gebben, devicetree, linux-kernel, openbmc @ lists . ozlabs . org, Joel Stanley, linux-aspeed, sdasari On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <vijaykhemka@fb.com> wrote: > > The pxe1610 is a voltage regulator from Infineon. It also supports > other VRs pxe1110 and pxm1310 from Infineon. > > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 2e742d399e87..1be648828a31 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -99,6 +99,8 @@ properties: > # Infineon IR38064 Voltage Regulator > - infineon,ir38064 > # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > + - infineon,pxe1610 > + # Infineon PXE1610, PXE1110 and PXM1310 Voltage Regulators The comment goes above the entry. > - infineon,slb9635tt > # Infineon SLB9645 I2C TPM (new protocol, max 400khz) > - infineon,slb9645tt > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device 2019-07-23 14:50 ` Rob Herring @ 2019-07-23 14:52 ` Rob Herring 2019-07-23 17:13 ` Vijay Khemka 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2019-07-23 14:52 UTC (permalink / raw) To: Vijay Khemka Cc: Mark Rutland, Jiri Kosina, Guenter Roeck, Herbert Xu, Patrick Venture, Ard Biesheuvel, Anson Huang, Jeremy Gebben, devicetree, linux-kernel, openbmc @ lists . ozlabs . org, Joel Stanley, linux-aspeed, sdasari On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <vijaykhemka@fb.com> wrote: > > > > The pxe1610 is a voltage regulator from Infineon. It also supports > > other VRs pxe1110 and pxm1310 from Infineon. What happened to the other compatibles? S/w doesn't need to know the differences? > > > > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 2e742d399e87..1be648828a31 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -99,6 +99,8 @@ properties: > > # Infineon IR38064 Voltage Regulator > > - infineon,ir38064 > > # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > > + - infineon,pxe1610 > > + # Infineon PXE1610, PXE1110 and PXM1310 Voltage Regulators > > The comment goes above the entry. > > > - infineon,slb9635tt > > # Infineon SLB9645 I2C TPM (new protocol, max 400khz) > > - infineon,slb9645tt > > -- > > 2.17.1 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device 2019-07-23 14:52 ` Rob Herring @ 2019-07-23 17:13 ` Vijay Khemka 2019-08-02 6:31 ` Joel Stanley 0 siblings, 1 reply; 6+ messages in thread From: Vijay Khemka @ 2019-07-23 17:13 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, Jiri Kosina, Guenter Roeck, Herbert Xu, Patrick Venture, Ard Biesheuvel, Anson Huang, Jeremy Gebben, devicetree, linux-kernel, openbmc @ lists . ozlabs . org, Joel Stanley, linux-aspeed, Sai Dasari On 7/23/19, 7:53 AM, "Rob Herring" <robh+dt@kernel.org> wrote: On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <robh+dt@kernel.org> wrote: > > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <vijaykhemka@fb.com> wrote: > > > > The pxe1610 is a voltage regulator from Infineon. It also supports > > other VRs pxe1110 and pxm1310 from Infineon. What happened to the other compatibles? S/w doesn't need to know the differences? As far as driver is concerned, it doesn't need to know differences. > > > > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com> > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 2e742d399e87..1be648828a31 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -99,6 +99,8 @@ properties: > > # Infineon IR38064 Voltage Regulator > > - infineon,ir38064 > > # Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz) > > + - infineon,pxe1610 > > + # Infineon PXE1610, PXE1110 and PXM1310 Voltage Regulators > > The comment goes above the entry. > > > - infineon,slb9635tt > > # Infineon SLB9645 I2C TPM (new protocol, max 400khz) > > - infineon,slb9645tt > > -- > > 2.17.1 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device 2019-07-23 17:13 ` Vijay Khemka @ 2019-08-02 6:31 ` Joel Stanley 2019-08-06 20:35 ` Vijay Khemka 0 siblings, 1 reply; 6+ messages in thread From: Joel Stanley @ 2019-08-02 6:31 UTC (permalink / raw) To: Vijay Khemka Cc: Rob Herring, Mark Rutland, Jiri Kosina, Guenter Roeck, Herbert Xu, Patrick Venture, Ard Biesheuvel, Anson Huang, Jeremy Gebben, devicetree, linux-kernel, openbmc @ lists . ozlabs . org, linux-aspeed, Sai Dasari Add pxe1610 as a trivial device On Tue, 23 Jul 2019 at 17:14, Vijay Khemka <vijaykhemka@fb.com> wrote: > > On 7/23/19, 7:53 AM, "Rob Herring" <robh+dt@kernel.org> wrote: > > On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <robh+dt@kernel.org> wrote: > > > > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <vijaykhemka@fb.com> wrote: > > > > > > The pxe1610 is a voltage regulator from Infineon. It also supports > > > other VRs pxe1110 and pxm1310 from Infineon. > > What happened to the other compatibles? S/w doesn't need to know the > differences? > As far as driver is concerned, it doesn't need to know differences. You have these three IDs in the driver: pxm1310 pxm1310 pxe1610 So all three could be listed in the documentation? Rob, is this what you wanted Vijay to do? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: Add pxe1610 as a trivial device 2019-08-02 6:31 ` Joel Stanley @ 2019-08-06 20:35 ` Vijay Khemka 0 siblings, 0 replies; 6+ messages in thread From: Vijay Khemka @ 2019-08-06 20:35 UTC (permalink / raw) To: Joel Stanley Cc: Rob Herring, Mark Rutland, Jiri Kosina, Guenter Roeck, Herbert Xu, Patrick Venture, Ard Biesheuvel, Anson Huang, Jeremy Gebben, devicetree, linux-kernel, openbmc @ lists . ozlabs . org, linux-aspeed, Sai Dasari Joel, I have added all 3 id in the documentation patch and I am not sure if that patch has been applied or not. Regards -Vijay On 8/1/19, 11:31 PM, "Joel Stanley" <joel@jms.id.au> wrote: Add pxe1610 as a trivial device On Tue, 23 Jul 2019 at 17:14, Vijay Khemka <vijaykhemka@fb.com> wrote: > > On 7/23/19, 7:53 AM, "Rob Herring" <robh+dt@kernel.org> wrote: > > On Tue, Jul 23, 2019 at 8:50 AM Rob Herring <robh+dt@kernel.org> wrote: > > > > On Mon, Jul 22, 2019 at 6:46 PM Vijay Khemka <vijaykhemka@fb.com> wrote: > > > > > > The pxe1610 is a voltage regulator from Infineon. It also supports > > > other VRs pxe1110 and pxm1310 from Infineon. > > What happened to the other compatibles? S/w doesn't need to know the > differences? > As far as driver is concerned, it doesn't need to know differences. You have these three IDs in the driver: pxm1310 pxm1310 pxe1610 So all three could be listed in the documentation? Rob, is this what you wanted Vijay to do? ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-06 20:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190723002052.2878847-1-vijaykhemka@fb.com>
2019-07-23 2:18 ` [PATCH] dt-bindings: Add pxe1610 as a trivial device Joel Stanley
2019-07-23 14:50 ` Rob Herring
2019-07-23 14:52 ` Rob Herring
2019-07-23 17:13 ` Vijay Khemka
2019-08-02 6:31 ` Joel Stanley
2019-08-06 20:35 ` Vijay Khemka
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).